Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Georgi Djakov <djakov@kernel.org>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Odelu Kukatla <odelu.kukatla@oss.qualcomm.com>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] interconnect: qcom: eliza: Add SDCC1 slave node
Date: Thu, 14 May 2026 12:52:21 +0300	[thread overview]
Message-ID: <0aa79750-ac75-4111-ac82-ad5672157c90@kernel.org> (raw)
In-Reply-To: <20260512-eliza-interconnect-add-missing-sdcc1-slave-node-v1-2-b1edf81bac3b@oss.qualcomm.com>

On 5/12/26 3:18 PM, Abel Vesa wrote:
> The Eliza interconnect provider is missing the SDCC1 CNOC CFG slave
> node. Add qhs_sdc1 to the provider node table and qsm_cfg links so
> SDCC1 interconnect paths can resolve to a provider node.
> 
> Bump the qsm_cfg link count to match the new entry.
> 
> Fixes: a39efc80ff50 ("interconnect: qcom: Add Eliza interconnect provider driver")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
>   drivers/interconnect/qcom/eliza.c | 11 +++++++++--
>   1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/interconnect/qcom/eliza.c b/drivers/interconnect/qcom/eliza.c
> index a4f7903f0524..6d12a1c3c034 100644
> --- a/drivers/interconnect/qcom/eliza.c
> +++ b/drivers/interconnect/qcom/eliza.c
> @@ -127,6 +127,12 @@ static struct qcom_icc_node qhs_qup2 = {
>   	.buswidth = 4,
>   };
>   
> +static struct qcom_icc_node qhs_sdc1 = {
> +	.name = "qhs_sdc1",
> +	.channels = 1,
> +	.buswidth = 4,
> +};
> +
>   static struct qcom_icc_node qhs_sdc2 = {
>   	.name = "qhs_sdc2",
>   	.channels = 1,
> @@ -383,7 +389,7 @@ static struct qcom_icc_node qsm_cfg = {
>   	.name = "qsm_cfg",
>   	.channels = 1,
>   	.buswidth = 4,
> -	.num_links = 29,
> +	.num_links = 30,
>   	.link_nodes = { &qhs_ahb2phy0, &qhs_ahb2phy1,
>   			&qhs_camera_cfg, &qhs_clk_ctl,
>   			&qhs_crypto0_cfg, &qhs_display_cfg,
> @@ -392,7 +398,7 @@ static struct qcom_icc_node qsm_cfg = {
>   			&qhs_mss_cfg, &qhs_pcie_0_cfg,
>   			&qhs_prng, &qhs_qdss_cfg,
>   			&qhs_qspi, &qhs_qup1,
> -			&qhs_qup2, &qhs_sdc2,
> +			&qhs_qup2, &qhs_sdc1, &qhs_sdc2,
>   			&qhs_tcsr, &qhs_tlmm,
>   			&qhs_ufs_mem_cfg, &qhs_usb3_0,
>   			&qhs_venus_cfg, &qhs_vsense_ctrl_cfg,

Should we also add the sdc1 to some BCM?

Thanks,
Georgi

  parent reply	other threads:[~2026-05-14  9:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 12:18 [PATCH 0/2] interconnect: qcom: eliza: Add missing SDCC1 slave Abel Vesa
2026-05-12 12:18 ` [PATCH 1/2] dt-bindings: interconnect: qcom,eliza-rpmh: Add " Abel Vesa
2026-05-14  5:44   ` Krzysztof Kozlowski
2026-05-14 10:46     ` Abel Vesa
2026-05-14 11:44       ` Krzysztof Kozlowski
2026-05-14 12:03         ` Abel Vesa
2026-05-12 12:18 ` [PATCH 2/2] interconnect: qcom: eliza: Add SDCC1 slave node Abel Vesa
2026-05-13 14:24   ` Dmitry Baryshkov
2026-05-14  9:52   ` Georgi Djakov [this message]
2026-05-14 10:39     ` Abel Vesa
2026-05-14 13:01       ` Abel Vesa
2026-05-14 13:09       ` Mike Tipton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aa79750-ac75-4111-ac82-ad5672157c90@kernel.org \
    --to=djakov@kernel.org \
    --cc=abel.vesa@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=odelu.kukatla@oss.qualcomm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox