From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB13C77B73 for ; Tue, 6 Jun 2023 19:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239397AbjFFTIS (ORCPT ); Tue, 6 Jun 2023 15:08:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239395AbjFFTHY (ORCPT ); Tue, 6 Jun 2023 15:07:24 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 698672107 for ; Tue, 6 Jun 2023 12:05:13 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4f3ba703b67so7963289e87.1 for ; Tue, 06 Jun 2023 12:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686078292; x=1688670292; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gtFgxYwjpUt68r3YPqakTIdPhlEwVeuW3nCboOazwYw=; b=hC5RWVnOExAfo1+RCwZD04IMwg7WZ8kKQK6HVJCvLuu5xXsnFGnn1bPKZA6UCn90Cs /kGaLoAvXe6lD6gqi9YHIsWSvBfuQIavrLXsBRFUdb0GRsQfduxItmUIqFnIYNRZOLMb 3JNaaugZQCcdU7NIQ02HLzjOxmv/PMCH+vCzuvZv4/qwDorzdSNTxEqSKjcfIYIWxxDT uevZ3i2n1xw1iaKTIZqs0AXnw9+fBltRRAH7Ucjte3sCiuFAkRWmbfX1r08SNhRn+8xW +XZQxOUhxIjF554m09kK08wbe/xUqHgX7YQcBLxz2XmD7VV9L6pwkXdncvy6pUZDbAjh z6Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686078292; x=1688670292; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gtFgxYwjpUt68r3YPqakTIdPhlEwVeuW3nCboOazwYw=; b=Cysg3qXfz3XgNTsiyiKixpbUYQfqoJxyTZtS1v1TnHqu1SEFnf4EDQG1yIagwm/idO qW3KuV0T4OTKoTswe9Ux6QKtQzRc1z0DOpy14KRx6xsafB847bzbhSMcSeHO264R2dYq qq7MUVgfYZe5tPJ949+iMA304hxeklyP1+H2unV4RILREFvjhc9nUb+yXArCLxOOjxyU ZCCxIXNU9YCB7a6OE6lsdKmvLv7fre61zgdVGaCu8h2TikdunVQ7ni8S0sgKgIeI4b95 iM1hjByqdUmZa8ORjMAmrbsFF9IXv5/kOD8oLoA8SpMqsCAxQeYeGrJpmT4N3OFCnREB tgsQ== X-Gm-Message-State: AC+VfDzKCb5PxAl1Pfq4IzRyc7DVBAZxSgLvSPdfVHPbeFbAEbOm/Waw XLqT/LoCza59lAzr5wdRgAoFgg== X-Google-Smtp-Source: ACHHUZ6bgt/R2v8mJhbothbqAYtjCEQJuoHpVxJyzRnUW3hd73sKHWap/htT50fIsZIcT2Nm54StGw== X-Received: by 2002:ac2:43b3:0:b0:4f3:b32d:f744 with SMTP id t19-20020ac243b3000000b004f3b32df744mr1289528lfl.11.1686078292036; Tue, 06 Jun 2023 12:04:52 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id f2-20020ac25322000000b004cb14fa604csm1537514lfh.262.2023.06.06.12.04.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jun 2023 12:04:51 -0700 (PDT) Message-ID: <0ab30652-4ee5-e4e8-9802-d8211dfb8d67@linaro.org> Date: Tue, 6 Jun 2023 22:04:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v16] drm/msm/dpu: add DSC blocks to the catalog of MSM8998 and SC8180X Content-Language: en-GB To: Kuogee Hsieh , robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@gmail.com, agross@kernel.org, andersson@kernel.org, marijn.suijten@somainline.org Cc: quic_abhinavk@quicinc.com, quic_jesszhan@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1686076299-11504-1-git-send-email-quic_khsieh@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <1686076299-11504-1-git-send-email-quic_khsieh@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 06/06/2023 21:31, Kuogee Hsieh wrote: > From: Abhinav Kumar > > Some platforms have DSC blocks which have not been declared in the catalog. > Complete DSC 1.1 support for all platforms by adding the missing blocks to > MSM8998 and SC8180X. > > Changes in v9: > -- add MSM8998 and SC8180x to commit title > > Changes in v10: > -- fix grammar at commit text > > Changes in v12: > -- fix "titil" with "title" at changes in v9 > > Changes in v14: > -- "dsc" tp "DSC" at commit title > > Changes in v15: > -- fix merge conflicts at dpu_5_1_sc8180x.h > > Changes in v16 > -- fix cherry-pick error by deleting both redundant .dsc and .dsc_count > assignment from dpu_5_1_sc8180x.h > > Signed-off-by: Abhinav Kumar > Reviewed-by: Dmitry Baryshkov > Reviewed-by: Marijn Suijten The patch was changed significantly. Thus the review-by's do not apply anymore. Please take care to drop reviewed-by and acked-by tags when you change the patch was changed in a sensible manner. Otherwise it would be impossible to understand if the patch was really reviewed or not. > --- > drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h > index 3c732a0..7d0d0e7 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h > @@ -126,6 +126,11 @@ static const struct dpu_pingpong_cfg msm8998_pp[] = { > DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 15)), > }; > > +static const struct dpu_dsc_cfg msm8998_dsc[] = { > + DSC_BLK("dsc_0", DSC_0, 0x80000, 0), > + DSC_BLK("dsc_1", DSC_1, 0x80400, 0), > +}; > + > static const struct dpu_dspp_cfg msm8998_dspp[] = { > DSPP_BLK("dspp_0", DSPP_0, 0x54000, DSPP_SC7180_MASK, > &msm8998_dspp_sblk), > @@ -199,6 +204,8 @@ const struct dpu_mdss_cfg dpu_msm8998_cfg = { > .dspp = msm8998_dspp, > .pingpong_count = ARRAY_SIZE(msm8998_pp), > .pingpong = msm8998_pp, > + .dsc_count = ARRAY_SIZE(msm8998_dsc), > + .dsc = msm8998_dsc, > .intf_count = ARRAY_SIZE(msm8998_intf), > .intf = msm8998_intf, > .vbif_count = ARRAY_SIZE(msm8998_vbif), -- With best wishes Dmitry