From: Sinan Kaya <okaya@codeaurora.org>
To: Robin Murphy <robin.murphy@arm.com>,
dmaengine@vger.kernel.org, timur@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] dmaengine: qcom_hidma: add support for the new revision
Date: Mon, 6 Nov 2017 13:15:43 -0500 [thread overview]
Message-ID: <0b24eb03-1f0e-ec65-b12b-65036ef7addc@codeaurora.org> (raw)
In-Reply-To: <428c7106-8ebe-0c12-4576-1cfac422923e@arm.com>
On 11/6/2017 1:03 PM, Robin Murphy wrote:
>> #ifdef CONFIG_ACPI
>> ret = strcmp(acpi_device_hid(adev), "QCOM8062");
>> + if (ret)
>> + ret = strcmp(acpi_device_hid(adev), "QCOM8063");
> This string-juggling looks to have already hit the point at which it
> doesn't scale well - it would be a lot nicer to make use of
> of_device_get_match_data() and the ACPI equivalent to abstract the
> version-specific data appropriately.
Sure, let me do some research.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-11-06 18:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 17:26 [PATCH 1/3] Documentation: DT: qcom_hidma: bump HW revision for the bugfixed HW Sinan Kaya
2017-11-06 17:26 ` [PATCH 2/3] dmaengine: qcom_hidma: add support for the new revision Sinan Kaya
2017-11-06 18:03 ` Robin Murphy
2017-11-06 18:15 ` Sinan Kaya [this message]
2017-11-06 22:09 ` Sinan Kaya
2017-11-08 5:47 ` Vinod Koul
2017-11-06 17:26 ` [PATCH 3/3] dmaengine: qcom_hidma: add identity register support Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b24eb03-1f0e-ec65-b12b-65036ef7addc@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox