From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63B973D3CEE for ; Wed, 25 Feb 2026 14:28:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772029725; cv=none; b=VOItxH4oMuiu/RuerdQnva5wOkFA2XhUhy5Ix0KZPovOBrLDyRQxtIWfYerGZxNgVzkLz9r++Rids8xmXxpOveb45VCsR6x+jgGAuZaflCM24rkZaTfjwbpWxGBM1yUW/wit7eNm3Hbr0egAPugah6PlEDVTcBK4+DexYCTLqTE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772029725; c=relaxed/simple; bh=AULsyK6QnjWs4F4LCW08KjpiOXM6EU826reVsXkv+Go=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cdfj0i2ceLKpzu92k/QASVNudhhf/G9zgmWf+0MY3LSG0uca0CplFjGYLlOja61MCNgssvAU85gVLBy17ssVLXJ862qVWIapNx50UFBW9ILWfMSwq9WJRFMGfXC6/DHaxiYwwj4psg6Cw2XVt3j22O8wAh5K+Q7qs46eV3pDHFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KWOISrIl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Kw4VCwOh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KWOISrIl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Kw4VCwOh" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61P9SsT42127719 for ; Wed, 25 Feb 2026 14:28:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zQmCtuOcHIia8KQum6i+PSa+8224BgJXHMjC5fyWebQ=; b=KWOISrIlUVSyrFWa QTRCag2nm+6GjYlPMM1upa1ZeWYHl2BqYM74aQ6cyhr4I8aVmNJGFuMv+d8ORH0S 77XGdHumt5ycaN3ZuWl5M6y6IhESbsxxeW5tmSMh2RmVVubR0uhhBNsoDsU64Ey5 tRZVaMSggTLOi3x/i+5FVf+57XV6dsC11Tdn+FyjhUYKVayEl+t90HQMYQ2wHAqk fraFIwRjHW4nBRQ/9T45cN/FWKwxcYonCf7dGp102/23LF3i7h85bwT87XWcTDmO MRRUmH+ZHk0KnSlsCi4ZmkY/AlLuEyAzlcvgIPPJc6Q0FZ3LzMaOCvyj8IrY1q+1 IjYR3A== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4chexekrv6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Feb 2026 14:28:42 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb50dfd542so613104485a.0 for ; Wed, 25 Feb 2026 06:28:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772029722; x=1772634522; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zQmCtuOcHIia8KQum6i+PSa+8224BgJXHMjC5fyWebQ=; b=Kw4VCwOhruTcY4WbfetbB4JoKxCZeEodgl1thbnK7aZn3kbP/R0J1545/MR3BNR28+ TarDHaHV889Wdo9vFmW4l2Dg+o4lakBEgaF583UxITgD5Kzl2uOH88akwtAg7oFBabss whCPatn3hnboX1kw9U01SR/dIz5PWoBGMEQLBl6YAfw1k//RjGoXe2bl9umcJ/CiTO8p QJnMDZYxkiHbnnOpIGJrbYWC9K9r87f4mXGln38Tp8++3EaGqxAUkHgVPkF7En8MGrD7 JOwJSomS7LbnwiFhCgznSyfKF4Evxx3arDXPrF1bGzgnciOsF7Hojqk2XWNRV5c/4BBc IazA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772029722; x=1772634522; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zQmCtuOcHIia8KQum6i+PSa+8224BgJXHMjC5fyWebQ=; b=kPlmGdCMlbWWijxb8cIIZExtdnzJJi76o098zhPOK4zvaxCbQ3v5nTIrWmNaMRGllu 9stMYSO1Ell9c0VpzHC4TibvhWdMOQom6IRjsk88vLRLLKxjE1Xk40yi3CAhbKmAUpjY 4p9Mudj2w+lqtuLsIngNLTKjBzrOiIlybjTgrYwekWn1ZhG0F2yl6aKvZMoydQf6W2uw g52Z6xomrz9OLyIlberSfK/qUJPRzcCxgo/YfQzCF1BC8QxsDIaITg9rAcTQKevRDkcY r4Z0mzGp7i2e0dqpGqfIHw27vzXaKU2eHYBhNxUL2WsSBKEI7yCcRX+o6R/E/thpbU7g CbNg== X-Forwarded-Encrypted: i=1; AJvYcCWnz3Wo1Z018AVXC9HFy1NSLc58sVaeoGaLIscmCuF/xe0PmLEnsdbfDb4JR8uA9mLTISQZzNapD2vuUFcG@vger.kernel.org X-Gm-Message-State: AOJu0YxNggqwd+O/n/4z/Fz+s/piFzbWOFKwfod5CrOpAJlQFcRvNpke sZqWMQw/5qdf8wO4I/l/qgaUFkKp/l1h0tXtN+D6O4GZW/Rq5BSEx5FOEqVLRH8YlCEfqiXuVH/ GgXQSDVRWKjGQbKIB5qBYdrp7R6EOojiGka2wtK0PdS40yTH8chttCLClycl1O63RmNMK X-Gm-Gg: ATEYQzwKzNX6GE+qz4Fa/VAWR/aqzEbL1hsstsnWQWfQvbIZsQBGEP/vbb0Mp7ZW+W6 mzLKVvCxBUX5ZSAxvZMegBXHnRTNy4+h4EMe8/+Euyz73IKikZ8UqARnI0VRd1W6+9EtrTe9qaO /88l4WBsKZjivD9JC/O2noW4qOa58LM6vT/kQuo696PgPEYKu3uzPXMpNUaz3+6cNmjghbEYyQx ncPis6WANkwEi1xQpVCJU3yVDjyTK/qQtwixbnqVvrwY/OOXCDX4nfi70YBxqBneaVdo721cDk2 iETb6Os7RLWBm9A7yJCwFcVI8x7mbVQbpWkKgPsJMQD4Ghn5cYy2neno6PTQ55oYUlcnm4HhSIJ NDdbtOL3wPKMy8kQBhFWROv4wRhIkn4r2IvEfjmLdBrlW3QX7vrYrMQocRDf9gvm/UXv4YX8q+O z/XFI= X-Received: by 2002:a05:620a:400d:b0:8c5:3892:a554 with SMTP id af79cd13be357-8cb8c9dffcdmr1658343285a.3.1772029721249; Wed, 25 Feb 2026 06:28:41 -0800 (PST) X-Received: by 2002:a05:620a:400d:b0:8c5:3892:a554 with SMTP id af79cd13be357-8cb8c9dffcdmr1658336885a.3.1772029720467; Wed, 25 Feb 2026 06:28:40 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65eab9a077asm4444053a12.4.2026.02.25.06.28.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Feb 2026 06:28:38 -0800 (PST) Message-ID: <0b969abe-d9ce-4a87-be61-212a1b8cc8a9@oss.qualcomm.com> Date: Wed, 25 Feb 2026 15:28:36 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/13] soc: qcom: geni-se: Introduce helper APIs for performance control To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, chiluka.harish@oss.qualcomm.com References: <20260206174112.4149893-1-praveen.talari@oss.qualcomm.com> <20260206174112.4149893-8-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260206174112.4149893-8-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI1MDEzOCBTYWx0ZWRfXz1PcK+Dd5Bgv tzO0zuOPwPUGRtelAWDr5EAmfVex5S/ga2/2v/J8ASglisEUQhHg+YH1d2l3LRZ6I/xcPMy6rXe MZTkFqVOSEjLVjHs4sBcDrbEfSJiOnvWlPC+PTLc66KnuiolhUr8II6LVICnRolaZPiVA1vaK3g 1vdfHEMZhZmeTw+a+fAuzfrgVG/M8rauef6jnTNVxwqKJD6zA29FPOkQ7NvfOqx1HBuHvnPvt5s qv+OWNScPA20bqqP6ajedP+8MyDRjYcdlypES7N8b50E/o7CY+3WUtD9fQThmDUE3qMn5NFgcM3 zd70aOdiI/Plv9+JI5P+wvCQb2eZF24z0vSVxHKS03GjRCcDBj7Iwo15JM7RflcQWn2z7S3GaO4 +8VmZE5sIGWXZTx9S4osLIA5ynh/wcA6VuRdy8rKY5K0lKLn0PVq1s44rzcKlReLAjlLTNfwmoA PUNL5Xh84rmBqsXMQog== X-Authority-Analysis: v=2.4 cv=V85wEOni c=1 sm=1 tr=0 ts=699f071a cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=_nBXEjQIeNtNfcHD0-QA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: HsKRcGKRvXm7EXzAn5_2CtzYHLliOMui X-Proofpoint-ORIG-GUID: HsKRcGKRvXm7EXzAn5_2CtzYHLliOMui X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-25_01,2026-02-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602250138 On 2/6/26 6:41 PM, Praveen Talari wrote: > The GENI Serial Engine (SE) drivers (I2C, SPI, and SERIAL) currently > manage performance levels and operating points directly. This resulting > in code duplication across drivers. such as configuring a specific level > or find and apply an OPP based on a clock frequency. > > Introduce two new helper APIs, geni_se_set_perf_level() and > geni_se_set_perf_opp(), addresses this issue by providing a streamlined > method for the GENI Serial Engine (SE) drivers to find and set the OPP > based on the desired performance level, thereby eliminating redundancy. > > Signed-off-by: Praveen Talari > --- [...] > +/** > + * geni_se_set_perf_level() - Set performance level for GENI SE. > + * @se: Pointer to the struct geni_se instance. > + * @level: The desired performance level. > + * > + * Sets the performance level by directly calling dev_pm_opp_set_level > + * on the performance device associated with the SE. > + * > + * Return: 0 on success, or a negative error code on failure. > + */ > +int geni_se_set_perf_level(struct geni_se *se, unsigned long level) > +{ > + return dev_pm_opp_set_level(se->pd_list->pd_devs[DOMAIN_IDX_PERF], level); > +} My only remaining concern with this patch is this export - on v3 you mentioned that it'd be used in the UART driver (which currently does more or less the same thing, open-coded) - are we unable to leverage dev_pm_opp_set_rate there too? i.e. are the OPP tables produced by the SCMI servers not populating the rate field for UART specifically? Konrad