From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeffrey Hugo <jhugo@codeaurora.org>
Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: msm8998: correct xo clock name
Date: Wed, 5 Dec 2018 09:38:10 -0700
Message-ID: <0ba54ffd-1d47-5ae9-ae9c-4a03d57e6ff3@codeaurora.org>
References: <1542314695-24071-1-git-send-email-jhugo@codeaurora.org>
 <1542314695-24071-2-git-send-email-jhugo@codeaurora.org>
 <b50bc3d4-f80b-6adb-c28b-1be254eb7e16@free.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org>
In-Reply-To: <b50bc3d4-f80b-6adb-c28b-1be254eb7e16@free.fr>
Content-Language: en-US
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Stephen Boyd <sboyd@kernel.org>, MSM <linux-arm-msm@vger.kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Andy Gross <andy.gross@linaro.org>, Georgi Djakov <georgi.djakov@linaro.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>
List-Id: linux-arm-msm@vger.kernel.org

On 12/5/2018 9:12 AM, Marc Gonzalez wrote:
> On 15/11/2018 21:44, Jeffrey Hugo wrote:
> 
>> The root parent clock of most msm8998 clock is the "xo" clock.  The DT node
>> is incorrectly named "xo_board", which prevents Linux from correctly
>> parsing the clock tree, resulting in most clocks being unparented and
>> unable to be manipulated.  The end result is that we can't turn on clocks
>> for peripherals like SD, so init usually fails.
>>
>> Fixes: 4807c71cc688 (arm64: dts: Add msm8998 SoC and MTP board support)
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>>   arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> index 78227cc..a948d4b 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> @@ -53,7 +53,7 @@
>>   	};
>>   
>>   	clocks {
>> -		xo_board {
>> +		xo {
>>   			compatible = "fixed-clock";
>>   			#clock-cells = <0>;
>>   			clock-frequency = <19200000>;
>>
> 
> Isn't there going to be a problem for msm8998 in drivers/clk/qcom/clk-smd-rpm.c
> which uses "xo_board" for parent_names?

Looks like you are right.  This doesn't seem to be the correct way to 
address the issue then.  I'll have to dig in and take another look.


-- 
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.