Re: [PATCH 1/7] media: dt-bindings: qcom-kaanapali-iris: Add kaanapali video codec binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/02/2026 16:34, Vikash Garodia wrote:
> 
> On 2/17/2026 8:06 PM, Dmitry Baryshkov wrote:
>> On Tue, Feb 17, 2026 at 07:13:39PM +0530, Vikash Garodia wrote:
>>>
>>> On 1/27/2026 8:39 PM, Dmitry Baryshkov wrote:
>>>> On Mon, Jan 26, 2026 at 05:55:44PM +0530, Vikash Garodia wrote:
>>>>> Kaanapali SOC brings in the new generation of video IP i.e iris4. When
>>>>> compared to previous generation, iris3x, it has,
>>>>> - separate power domains for stream and pixel processing hardware blocks
>>>>>     (bse and vpp).
>>>>> - additional power domain for apv codec.
>>>>> - power domains for individual pipes (VPPx).
>>>>> - different clocks and reset lines.
>>>>>
>>>>> iommu-map include all the different stream-ids which can be possibly
>>>>> generated by vpu4 hardware.
>>>>
>>>> It's not how it can be defined.
>>>
>>> Do you mean to elaborate the different entries within iommu-map or to
>>> elaborate the different stream ids and how they are grouped into different
>>> functions ?
>>
>> The comment was sent three weeks ago.
> 
> yeah, if you could still recollect, you can comment.
> 
>>
>>>
>>>>
>>>>>
>>>>> Signed-off-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
>>>>> ---
>>>>>    .../bindings/media/qcom,kaanapali-iris.yaml        | 234 +++++++++++++++++++++
>>>>>    1 file changed, 234 insertions(+)
>>>>>
>>>>> +
>>>>> +  iommu-map: true
>>>>
>>>> This is totally underspecifified.
>>>
>>> oneof would be a better approach describing the possible stream-ids.
>>
>> oneOf of what? It is items with the definition of each item.
> 
> something like below,
> 
> properties:
>    iommu-map:
>      description: |
>        List of IOMMU stream IDs corresponding to hardware function IDs.
>        The number of entries depends on the SoC variant.
>      type: array
>      oneOf:
>        - minItems: 8
>          maxItems: 8
>          items:
>            type: integer
>            description: IOMMU stream IDs
> 
>        - minItems: 9
>          maxItems: 9
>          items:
>            type: integer
>            description: IOMMU stream IDs


This gives no useful description. Can it be something else than IOMMU
stream ID? No, it cannot. Saying then that this is stream ID is like
saying listing clocks and calling them "clock input".

This should be list of descriptions explaining their function/purpose or
whatever region is there mapped.

Best regards,
Krzysztof