Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: sram: Describe the IMEM present in Qualcomm IPQ SoCs
Date: Wed, 4 Mar 2026 16:46:57 +0530	[thread overview]
Message-ID: <0be1b15f-df0a-4ff0-ac97-8aaa46dd9b7c@oss.qualcomm.com> (raw)
In-Reply-To: <78d08114-d573-42be-9cff-39c228c68848@oss.qualcomm.com>


On 3/3/2026 4:18 PM, Konrad Dybcio wrote:
> On 3/2/26 5:33 PM, Krzysztof Kozlowski wrote:
>> On 02/03/2026 15:56, Konrad Dybcio wrote:
>>> On 3/2/26 3:54 PM, Krzysztof Kozlowski wrote:
>>>> On 02/03/2026 15:10, Konrad Dybcio wrote:
>>>>>> Also not accurate - "sram" is not the reboot reason, which has node name
>>>>>> called "reboot-mode".
>>>>> What I was referring to is:
>>>>>
>>>>> patternProperties:
>>>>>    "^([a-z0-9]*-)?sram(-section)?@[a-f0-9]+$":
>>>>>
>>>>> where the 'sram' (not 'smem' as I typo'd above) is obligatory
>>>> I know and sram is not part of "reboot-mode" name. It is "reboot-mode"
>>>> in existing binding and DTS, not "reboot-mode-sram".
>>> In any case, I believe it'd be good to drop that requirement
>> Ah, and one more thing, the syscon-reboot-mode is Linux driver with its
>> own Linux requirements - syscon - so probably not working with sram
>> bindings. That's another reason full binding should be posted and tested
>> - I speculate it simply does not work.
> It won't even probe, we talked about that a long time ago on a similar
> occasion
>
> https://lore.kernel.org/linux-arm-msm/f6b16d1d-3730-46d1-81aa-bfaf09c20754@oss.qualcomm.com/


Sorry, TBH, I'm confused here...

I agree that, DT node should be as simple as below for now until the 
child node is added.

sram@8600000 {
    compatible = "qcom,ipq5332-imem", "mmio-sram";
    reg = <0x08600000 0x14000>;
    no-memory-wc;
};

When I add the child node, it will eventually become like

sram@8600000 {
         compatible = "qcom,ipq5332-imem", "mmio-sram";
         reg = <0 0x08600000 0 0x1c000>;
         ranges = <0 0 0x08600000 0x1c000>;

         no-memory-wc;

         #address-cells = <1>;
         #size-cells = <1>;

         restart_reason: restartreason-sram@7b0 {
                 reg = <0x7b0 0x4>;
         };
};

which seems to be matching with the binding requirements.

and the consumer can reference to this node like

sram = <&restart_reason>;

I'm not following what's being suggested here. Can you please help me to 
understand further on this.


>
> Konrad

  reply	other threads:[~2026-03-04 11:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28 13:07 [PATCH v3 0/6] Describe the IMEM present in Qualcomm IPQ SoC's Kathiravan Thirumoorthy
2026-02-28 13:08 ` [PATCH v3 1/6] dt-bindings: sram: Describe the IMEM present in Qualcomm IPQ SoCs Kathiravan Thirumoorthy
2026-03-01 11:27   ` Krzysztof Kozlowski
2026-03-02 13:52     ` Konrad Dybcio
2026-03-02 13:56       ` Krzysztof Kozlowski
2026-03-02 14:10         ` Konrad Dybcio
2026-03-02 14:54           ` Krzysztof Kozlowski
2026-03-02 14:56             ` Konrad Dybcio
2026-03-02 16:33               ` Krzysztof Kozlowski
2026-03-03 10:48                 ` Konrad Dybcio
2026-03-04 11:16                   ` Kathiravan Thirumoorthy [this message]
2026-03-04 11:29                     ` Krzysztof Kozlowski
2026-03-04 11:38                       ` Konrad Dybcio
2026-03-04 11:44                         ` Krzysztof Kozlowski
2026-02-28 13:08 ` [PATCH v3 2/6] arm64: dts: qcom: ipq8074: Add the IMEM node Kathiravan Thirumoorthy
2026-03-01 11:29   ` Krzysztof Kozlowski
2026-02-28 13:08 ` [PATCH v3 3/6] arm64: dts: qcom: ipq6018: " Kathiravan Thirumoorthy
2026-02-28 13:08 ` [PATCH v3 4/6] arm64: dts: qcom: ipq5018: " Kathiravan Thirumoorthy
2026-02-28 13:08 ` [PATCH v3 5/6] arm64: dts: qcom: ipq9574: " Kathiravan Thirumoorthy
2026-02-28 13:08 ` [PATCH v3 6/6] arm64: dts: qcom: ipq5332: " Kathiravan Thirumoorthy
2026-03-01 11:28   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0be1b15f-df0a-4ff0-ac97-8aaa46dd9b7c@oss.qualcomm.com \
    --to=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox