From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 912EDC433F5 for ; Mon, 28 Feb 2022 19:24:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229473AbiB1TZH (ORCPT ); Mon, 28 Feb 2022 14:25:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbiB1TZF (ORCPT ); Mon, 28 Feb 2022 14:25:05 -0500 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DC0EFEB02; Mon, 28 Feb 2022 11:24:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1646076259; x=1677612259; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ioyGMTrNhrI2bIJcwf/tXVAAjhbSRoppoUAEm+1hobw=; b=SXaKL9oZ6aveOqnzV6wMsmh2bKLgIpTPszkNW1BhuQ4K/uXoDG6ya98/ vchz6FNa1nLNNtxq4x/XFSy52dI7GWC/+7lsQgTHJdPdUiXYUT8JJ1shv +YOOJW9soN20NEwkSgbQyW57ijZggyCRzoEdr6IG9PVm1HW2LrcQUrusf o=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 28 Feb 2022 11:24:19 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 11:24:18 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Mon, 28 Feb 2022 11:24:18 -0800 Received: from [10.216.31.79] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Mon, 28 Feb 2022 11:24:15 -0800 Message-ID: <0beb0083-d82b-dc24-6d07-565f9eaeebff@quicinc.com> Date: Tue, 1 Mar 2022 00:53:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/5] irqchip/qcom-pdc: Kill PDC_NO_PARENT_IRQ To: Marc Zyngier , CC: Andy Gross , Bjorn Andersson , Thomas Gleixner , References: <20220224101226.88373-1-maz@kernel.org> <20220224101226.88373-2-maz@kernel.org> From: "Maulik Shah (mkshah)" In-Reply-To: <20220224101226.88373-2-maz@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On 2/24/2022 3:42 PM, Marc Zyngier wrote: > PDC_NO_PARENT_IRQ is pretty pointless, as all it indicates is > that the PDC terminates the interrupt hierarchy. Which is > exactly the same as not having a mapping in the GIC space. > This is also bad practice to treat the absence of a hwirq > as a hwirq itself. > > Just explicitly use the region mapping pointer, and drop > the definition. > > Signed-off-by: Marc Zyngier Reviewed-by: Maulik Shah Thanks, Maulik > --- > drivers/irqchip/qcom-pdc.c | 34 +++++++++++++++++----------------- > 1 file changed, 17 insertions(+), 17 deletions(-) > >