From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF266C433EF for ; Thu, 7 Oct 2021 20:28:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA6EA61074 for ; Thu, 7 Oct 2021 20:28:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241154AbhJGUaQ (ORCPT ); Thu, 7 Oct 2021 16:30:16 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:37166 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231594AbhJGUaN (ORCPT ); Thu, 7 Oct 2021 16:30:13 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633638499; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=aRwlxy5PdutcRVJLUCyFixnkZpZ7NhnTb589zPa6lVM=; b=XMBXnooQAUd271sLq004noWLosmLAuATA43nYYnKjMUchhMYCOmBqOOwhEXz0kee/zAZM7jA I+gvLmVwnWeHBjJKjt7gQ2Nq0IRkAgvw+K2iifLmPD/+L2r9Vn0VBmkFCGd0BZM0VrfCxh53 c5ci0xAWfr7X6wb69NITw79axgA= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-west-2.postgun.com with SMTP id 615f585e03355859c8823cf1 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 07 Oct 2021 20:28:14 GMT Sender: khsieh=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 008ADC4361B; Thu, 7 Oct 2021 20:28:13 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: khsieh) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4C702C4360D; Thu, 7 Oct 2021 20:28:12 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 07 Oct 2021 13:28:12 -0700 From: khsieh@codeaurora.org To: Bjorn Andersson Cc: Stephen Boyd , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sankeerth Billakanti Subject: Re: [PATCH] drm/msm/dp: Shorten SETUP timeout In-Reply-To: References: <20211005023750.2037631-1-bjorn.andersson@linaro.org> <3dbe0fe48da88af9dee396a85b940e76@codeaurora.org> <9dc50145fb3e9b189fd38857b20f326a@codeaurora.org> Message-ID: <0c72f3fd8c49cdada09bb6ee366b53a6@codeaurora.org> X-Sender: khsieh@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2021-10-07 13:06, Bjorn Andersson wrote: > On Thu 07 Oct 12:51 PDT 2021, khsieh@codeaurora.org wrote: > >> On 2021-10-06 10:31, Bjorn Andersson wrote: >> > On Wed 06 Oct 08:37 PDT 2021, khsieh@codeaurora.org wrote: >> > >> > > On 2021-10-05 19:10, Bjorn Andersson wrote: >> > > > On Tue 05 Oct 16:04 PDT 2021, khsieh@codeaurora.org wrote: >> > > > >> > > > > On 2021-10-05 15:36, Stephen Boyd wrote: >> > > > > > Quoting Bjorn Andersson (2021-10-05 14:40:38) >> > > > > > > On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: >> > > > > > > >> > > > > > > > Quoting Bjorn Andersson (2021-10-04 19:37:50) >> > > > > > > > > Found in the middle of a patch from Sankeerth was the reduction of the >> > > > > > > > > INIT_SETUP timeout from 10s to 100ms. Upon INIT_SETUP timeout the host >> > > > > > > > > is initalized and HPD interrupt start to be serviced, so in the case of >> > > > > > > > > eDP this reduction improves the user experience dramatically - i.e. >> > > > > > > > > removes 9.9s of bland screen time at boot. >> > > > > > > > > >> > > > > > > > > Suggested-by: Sankeerth Billakanti >> > > > > > > > > Signed-off-by: Bjorn Andersson >> > > > > > > > > --- >> > > > > > > > >> > > > > > > > Any Fixes tag? BTW, the delay design is pretty convoluted. I had to go >> > > > > > > > re-read the code a couple times to understand that it's waiting 100ms >> > > > > > > > times the 'delay' number. Whaaaaat? >> > > > > > > > >> > > > > > > >> > > > > > > I assume you're happy with the current 10s delay on the current >> > > > > > > devices, so I don't think we should push for this to be backported. >> > > > > > > I have no need for it to be backported on my side at least. >> > > > > > > >> > > > > > >> > > > > > Sure. Fixes tag != backported to stable trees but it is close. >> > > > > > >> > > > > > > > Reviewed-by: Stephen Boyd >> > > > > > > >> > > > > dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 1); <== to 100ms >> > > > > >> > > > > This patch will prevent usb3 from working due to dp driver >> > > > > initialize phy >> > > > > earlier than usb3 which cause timeout error at power up usb3 phy >> > > > > when both >> > > > > edp and dp are enabled. >> > > > >> > > > Can you please help me understand what you mean here, I use this on my >> > > > sc8180x with both eDP and USB-C/DP right now. What is it that doesn't >> > > > work? Or am I just lucky in some race condition? >> > > > >> > > > Thanks, >> > > > Bjorn >> > > > >> > > The problem is seen at sc7280. >> > > Apple dongle have both hdmi and usb port. >> > > plug Apple dongle into type-c, then plug DP into apple's hdmi port >> > > and usb >> > > mouse into apple's usb port. >> > > If edp enabled at this time, then usb mouse will not work due to >> > > timeout at >> > > phy power up. >> > > >> > >> > Okay, so you're saying that if the DP driver invokes phy_power_on() >> > before the USB driver does, USB initialization fails (or at least USB >> > doesn't work)? >> >> if dp driver call qcom_qmp_phy_init() before usb3 call >> qcom_qmp_phy_init(), >> usb3 driver will timeout at readl_poll_timeout(status, val, (val & >> mask) == >> ready, 10, PHY_INIT_COMPLETE_TIMEOUT) of qcom_qmp_phy_power_on(). > > Thanks, I will try to reproduce this on my side. So the 10 seconds here > is strictly to give good enough time for the dwc3 driver to probe... > > Any idea why you're saying that this is specific to sc7280, what > changed > from sc7180? I did not have sc7180 with edp before so that i am not sure it will happen on sc7180 or not. The usb3 does not work when both edp and dp enabled I just seen at sc7280. Current at sc7280 EC is not boot up correctly when system power up. I have to manual reboot EC from linux kernel shell before DP/usb3 can work. I am not sure this contribute to this problem or not. > >> > >> > Sounds like something we need to work out in the QMP phy driver. Do you >> > have any more details about what's going wrong. >> > >> > >> > Also, I've seen various references to said "Apple dongle", do you have a >> > link to the exact one you're testing with so I can pick one up for >> > testing purposes as well? >> >> Apple A2119 hdmi+usb dongle. >> https://www.amazon.com/Apple-USB-C-Digital-Multiport-Adapter/dp/B07WF96FY5/ref=sr_1_2?dchild=1&keywords=apple+a2119&qid=1633636227&sr=8-2 >> > > Thanks, > Bjorn > >> > >> > Regards, >> > Bjorn >> > >> > > > > I had prepared a patch (drm/msm/dp: do not initialize combo phy >> > > > > until plugin >> > > > > interrupt) to fix this problem. >> > > > > Unfortunately, my patch is depend on Bjorn's patch (PATCH v3 3/5] >> > > > > drm/msm/dp: Support up to 3 DP controllers). >> > > > > I will submit my patch for review once Bjorn's patches merged in. >> > > > > Therefore I would think this patch should go after both Bjorn's >> > > > > patches and >> > > > > my patch. >> > > > > >> > > > > >> > > > >