From mboxrd@z Thu Jan 1 00:00:00 1970 From: Georgi Djakov Subject: Re: [PATCH 2/4] OPP: Add support for parsing the interconnect bandwidth Date: Tue, 9 Apr 2019 17:37:12 +0300 Message-ID: <0cb2d777-4d05-2b06-e458-755d171b3436@linaro.org> References: <20190313090010.20534-1-georgi.djakov@linaro.org> <20190313090010.20534-3-georgi.djakov@linaro.org> <20190314063047.urmzez52bdyrkdsu@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190314063047.urmzez52bdyrkdsu@vireshk-i7> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: vireshk@kernel.org, sboyd@kernel.org, nm@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, rjw@rjwysocki.net, jcrouse@codeaurora.org, vincent.guittot@linaro.org, bjorn.andersson@linaro.org, amit.kucheria@linaro.org, seansw@qti.qualcomm.com, daidavid1@codeaurora.org, evgreen@chromium.org, sibis@codeaurora.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org Hi Viresh, On 3/14/19 08:30, Viresh Kumar wrote: > On 13-03-19, 11:00, Georgi Djakov wrote: >> The OPP bindings now support bandwidth values, so add support to parse it >> from device tree and store it into the new dev_pm_opp_icc_bw struct, which >> is part of the dev_pm_opp. >> >> Also add and export the dev_pm_opp_set_path() and dev_pm_opp_put_path() >> helpers, to set (and release) an interconnect path to a device. The >> bandwidth of this path will be updated when the OPPs are switched. >> >> Signed-off-by: Georgi Djakov >> --- >> drivers/opp/core.c | 67 ++++++++++++++++++++++++++++++++++++++++++ >> drivers/opp/of.c | 44 +++++++++++++++++++++++++++ >> drivers/opp/opp.h | 6 ++++ >> include/linux/pm_opp.h | 14 +++++++++ >> 4 files changed, 131 insertions(+) >> >> diff --git a/drivers/opp/core.c b/drivers/opp/core.c >> index e06a0ab05ad6..4b019cecaa07 100644 >> --- a/drivers/opp/core.c >> +++ b/drivers/opp/core.c >> @@ -19,6 +19,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -1645,6 +1646,72 @@ void dev_pm_opp_put_clkname(struct opp_table *opp_table) >> } >> EXPORT_SYMBOL_GPL(dev_pm_opp_put_clkname); >> >> +/** >> + * dev_pm_opp_set_path() - Set interconnect path for a device >> + * @dev: Device for which interconnect path is being set. >> + * @name: Interconnect path name or NULL. >> + * >> + * This must be called before any OPPs are initialized for the device. >> + */ >> +struct opp_table *dev_pm_opp_set_path(struct device *dev, const char *name) > > Maybe the OPP core can do it itself in a similar way to how we do > clk_get() today ? Do you mean to directly call of_icc_get() in _allocate_opp_table()? [..] >> +static int opp_parse_icc_bw(struct dev_pm_opp *opp, struct device *dev, >> + struct opp_table *opp_table) >> +{ >> + struct property *prop = NULL; >> + char name[NAME_MAX]; >> + int count; >> + u32 avg = 0; >> + u32 peak = 0; > > Why init to 0 ? Right, seems not necessary. >> + >> + /* Search for "opp-bw-MBs" */ >> + sprintf(name, "opp-bw-MBs"); >> + prop = of_find_property(opp->np, name, NULL); >> + >> + /* Missing property is not a problem */ >> + if (!prop) { >> + dev_dbg(dev, "%s: Missing opp-bw-MBs\n", __func__); >> + return 0; >> + } >> + >> + count = of_property_count_u32_elems(opp->np, name); >> + if (count != 2) { >> + dev_err(dev, "%s: Invalid number of elements in %s property\n", >> + __func__, name); >> + return -EINVAL; >> + } >> + >> + opp->bandwidth = kzalloc(sizeof(*opp->bandwidth), GFP_KERNEL); > > You forgot to free it. Will fix. [..]>> +/** >> + * struct dev_pm_opp_icc_bw - Interconnect bandwidth values >> + * @avg: Average bandwidth corresponding to this OPP (in icc units) >> + * @peak: Peak bandwidth corresponding to this OPP (in icc units) >> + * >> + * This structure stores the bandwidth values for a single interconnect path. >> + */ >> +struct dev_pm_opp_icc_bw { >> + u32 avg; >> + u32 peak; >> +}; > > There is only one user of this structure, maybe we can directly add > the elements in teh dev_pm_opp structure. Ok, will do it. Thanks, Georgi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3916C282DA for ; Tue, 9 Apr 2019 14:37:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 698D62084B for ; Tue, 9 Apr 2019 14:37:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sMri3+l3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726461AbfDIOhV (ORCPT ); Tue, 9 Apr 2019 10:37:21 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:35361 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbfDIOhV (ORCPT ); Tue, 9 Apr 2019 10:37:21 -0400 Received: by mail-lj1-f196.google.com with SMTP id t4so14709049ljc.2 for ; Tue, 09 Apr 2019 07:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=H6HmPYaPwOpwJuCKqBKpSpAi4qM33mYGqixAwWsXtEU=; b=sMri3+l3lSootdyI+pEqPFlNJ0B6q/UO2VCW2e3LQlbpFcbhYlHHOrMuSAM38/5AdN tcFQY1VS+YSWvFxK+BCqZTd0g1pmaGeScQRAUZ8mN7TbjYc5IoTiX36UBggZ3QYjyxY0 UwYWHtsXgACO+Zy5HKhNf/cqadlbMG4ZO3sk+0s223uQBP2ZIvmZRwPeAI00MtI0eXnq ETBZiYFYW9SK6zPbnFlqKPNzaGYjDExes/EgE4f7co3DkpL3VaCmdm7z2Ve0WEvNPYbn yIklBrvFUf+1/RLUURbMFb6ftu0Lcgf+DJGOmwDGDodRjT23YMJOAywYNi72xE6gLVwE xb9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=H6HmPYaPwOpwJuCKqBKpSpAi4qM33mYGqixAwWsXtEU=; b=Da+y+jpTn4MHMR5bz9SpqMy4Hq4R/mEEaGr4aoR45VNcoJLxhADB3aaXvC3NPaNeda 8bLEQpDSROIAEKsuPdVHZ9uSkDFNuZIliIWpCGAKKdWKEutC8vTNWNK+RsHgKZxrcXhf qcC3QZLtCW6ef59Zvp2RXagF49W0bNVjG7crAI9iVbDgth69mFZV7iYLPFInJ4eUgsKS OKn9XJt8RlML2h3B4boSbJ570eP0J73HWJHnJxQKfeAZFOBPlcBk59kUd0DGR0+DP3nD wTzCaTFsBe5SU77pMgKC01v0Xh74XhttKh/F8D6lkUJyS1C8YRWFpv5o7/Fk8UQWCuJS eGvg== X-Gm-Message-State: APjAAAVdSxFDokzKWQvE1JDjs3nusqawOZR5ZdglvdE80KNHpb4gQ/D5 3XUXvUO+IxnJPIBzno17cyMqWYhScRc= X-Google-Smtp-Source: APXvYqzwW7zlyCMhIUIkhsBXrPbFbSt/Zw2O3ElzbECHfa7nxXKJk4qkhEiuOj7eNFti0vmDmjJVEQ== X-Received: by 2002:a2e:3c0a:: with SMTP id j10mr19502815lja.164.1554820637857; Tue, 09 Apr 2019 07:37:17 -0700 (PDT) Received: from [10.44.66.8] ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id 13sm6596433lfy.2.2019.04.09.07.37.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Apr 2019 07:37:17 -0700 (PDT) Subject: Re: [PATCH 2/4] OPP: Add support for parsing the interconnect bandwidth To: Viresh Kumar Cc: vireshk@kernel.org, sboyd@kernel.org, nm@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, rjw@rjwysocki.net, jcrouse@codeaurora.org, vincent.guittot@linaro.org, bjorn.andersson@linaro.org, amit.kucheria@linaro.org, seansw@qti.qualcomm.com, daidavid1@codeaurora.org, evgreen@chromium.org, sibis@codeaurora.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20190313090010.20534-1-georgi.djakov@linaro.org> <20190313090010.20534-3-georgi.djakov@linaro.org> <20190314063047.urmzez52bdyrkdsu@vireshk-i7> From: Georgi Djakov Openpgp: preference=signencrypt Autocrypt: addr=georgi.djakov@linaro.org; prefer-encrypt=mutual; keydata= mQINBFjTuRcBEACyAOVzghvyN19Sa/Nit4LPBWkICi5W20p6bwiZvdjhtuh50H5q4ktyxJtp 1+s8dMSa/j58hAWhrc2SNL3fttOCo+MM1bQWwe8uMBQJP4swgXf5ZUYkSssQlXxGKqBSbWLB uFHOOBTzaQBaNgsdXo+mQ1h8UCgM0zQOmbs2ort8aHnH2i65oLs5/Xgv/Qivde/FcFtvEFaL 0TZ7odM67u+M32VetH5nBVPESmnEDjRBPw/DOPhFBPXtal53ZFiiRr6Bm1qKVu3dOEYXHHDt nF13gB+vBZ6x5pjl02NUEucSHQiuCc2Aaavo6xnuBc3lnd4z/xk6GLBqFP3P/eJ56eJv4d0B 0LLgQ7c1T3fU4/5NDRRCnyk6HJ5+HSxD4KVuluj0jnXW4CKzFkKaTxOp7jE6ZD/9Sh74DM8v etN8uwDjtYsM07I3Szlh/I+iThxe/4zVtUQsvgXjwuoOOBWWc4m4KKg+W4zm8bSCqrd1DUgL f67WiEZgvN7tPXEzi84zT1PiUOM98dOnmREIamSpKOKFereIrKX2IcnZn8jyycE12zMkk+Sc ASMfXhfywB0tXRNmzsywdxQFcJ6jblPNxscnGMh2VlY2rezmqJdcK4G4Lprkc0jOHotV/6oJ mj9h95Ouvbq5TDHx+ERn8uytPygDBR67kNHs18LkvrEex/Z1cQARAQABtChHZW9yZ2kgRGph a292IDxnZW9yZ2kuZGpha292QGxpbmFyby5vcmc+iQI+BBMBAgAoBQJY07kXAhsDBQkHhM4A BgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRCyi/eZcnWWUuvsD/4miikUeAO6fU2Xy3fT l7RUCeb2Uuh1/nxYoE1vtXcow6SyAvIVTD32kHXucJJfYy2zFzptWpvD6Sa0Sc58qe4iLY4j M54ugOYK7XeRKkQHFqqR2T3g/toVG1BOLS2atooXEU+8OFbpLkBXbIdItqJ1M1SEw8YgKmmr JlLAaKMq3hMb5bDQx9erq7PqEKOB/Va0nNu17IL58q+Q5Om7S1x54Oj6LiG/9kNOxQTklOQZ t61oW1Ewjbl325fW0/Lk0QzmfLCrmGXXiedFEMRLCJbVImXVKdIt/Ubk6SAAUrA5dFVNBzm2 L8r+HxJcfDeEpdOZJzuwRyFnH96u1Xz+7X2V26zMU6Wl2+lhvr2Tj7spxjppR+nuFiybQq7k MIwyEF0mb75RLhW33sdGStCZ/nBsXIGAUS7OBj+a5fm47vQKv6ekg60oRTHWysFSJm1mlRyq exhI6GwUo5GM/vE36rIPSJFRRgkt6nynoba/1c4VXxfhok2rkP0x3CApJ5RimbvITTnINY0o CU6f1ng1I0A1UTi2YcLjFq/gmCdOHExT4huywfu1DDf0p1xDyPA1FJaii/gJ32bBP3zK53hM dj5S7miqN7F6ZpvGSGXgahQzkGyYpBR5pda0m0k8drV2IQn+0W8Qwh4XZ6/YdfI81+xyFlXc CJjljqsMCJW6PdgEH7kCDQRY07kXARAAvupGd4Jdd8zRRiF+jMpv6ZGz8L55Di1fl1YRth6m lIxYTLwGf0/p0oDLIRldKswena3fbWh5bbTMkJmRiOQ/hffhPSNSyyh+WQeLY2kzl6geiHxD zbw37e2hd3rWAEfVFEXOLnmenaUeJFyhA3Wd8OLdRMuoV+RaLhNfeHctiEn1YGy2gLCq4VNb 4Wj5hEzABGO7+LZ14hdw3hJIEGKtQC65Jh/vTayGD+qdwedhINnIqslk9tCQ33a+jPrCjXLW X29rcgqigzsLHH7iVHWA9R5Aq7pCy5hSFsl4NBn1uV6UHlyOBUuiHBDVwTIAUnZ4S8EQiwgv WQxEkXEWLM850V+G6R593yZndTr3yydPgYv0xEDACd6GcNLR/x8mawmHKzNmnRJoOh6Rkfw2 fSiVGesGo83+iYq0NZASrXHAjWgtZXO1YwjW9gCQ2jYu9RGuQM8zIPY1VDpQ6wJtjO/KaOLm NehSR2R6tgBJK7XD9it79LdbPKDKoFSqxaAvXwWgXBj0Oz+Y0BqfClnAbxx3kYlSwfPHDFYc R/ppSgnbR5j0Rjz/N6Lua3S42MDhQGoTlVkgAi1btbdV3qpFE6jglJsJUDlqnEnwf03EgjdJ 6KEh0z57lyVcy5F/EUKfTAMZweBnkPo+BF2LBYn3Qd+CS6haZAWaG7vzVJu4W/mPQzsAEQEA AYkCJQQYAQIADwUCWNO5FwIbDAUJB4TOAAAKCRCyi/eZcnWWUhlHD/0VE/2x6lKh2FGP+QHH UTKmiiwtMurYKJsSJlQx0T+j/1f+zYkY3MDX+gXa0d0xb4eFv8WNlEjkcpSPFr+pQ7CiAI33 99kAVMQEip/MwoTYvM9NXSMTpyRJ/asnLeqa0WU6l6Z9mQ41lLzPFBAJ21/ddT4xeBDv0dxM GqaH2C6bSnJkhSfSja9OxBe+F6LIAZgCFzlogbmSWmUdLBg+sh3K6aiBDAdZPUMvGHzHK3fj gHK4GqGCFK76bFrHQYgiBOrcR4GDklj4Gk9osIfdXIAkBvRGw8zg1zzUYwMYk+A6v40gBn00 OOB13qJe9zyKpReWMAhg7BYPBKIm/qSr82aIQc4+FlDX2Ot6T/4tGUDr9MAHaBKFtVyIqXBO xOf0vQEokkUGRKWBE0uA3zFVRfLiT6NUjDQ0vdphTnsdA7h01MliZLQ2lLL2Mt5lsqU+6sup Tfql1omgEpjnFsPsyFebzcKGbdEr6vySGa3Cof+miX06hQXKe99a5+eHNhtZJcMAIO89wZmj 7ayYJIXFqjl/X0KBcCbiAl4vbdBw1bqFnO4zd1lMXKVoa29UHqby4MPbQhjWNVv9kqp8A39+ E9xw890l1xdERkjVKX6IEJu2hf7X3MMl9tOjBK6MvdOUxvh1bNNmXh7OlBL1MpJYY/ydIm3B KEmKjLDvB0pePJkdTw== Message-ID: <0cb2d777-4d05-2b06-e458-755d171b3436@linaro.org> Date: Tue, 9 Apr 2019 17:37:12 +0300 MIME-Version: 1.0 In-Reply-To: <20190314063047.urmzez52bdyrkdsu@vireshk-i7> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Message-ID: <20190409143712.YsWlPHAECDlncSKIAZ3YpHfb-WAbAXgHDQhcvO9ZrOE@z> Hi Viresh, On 3/14/19 08:30, Viresh Kumar wrote: > On 13-03-19, 11:00, Georgi Djakov wrote: >> The OPP bindings now support bandwidth values, so add support to parse it >> from device tree and store it into the new dev_pm_opp_icc_bw struct, which >> is part of the dev_pm_opp. >> >> Also add and export the dev_pm_opp_set_path() and dev_pm_opp_put_path() >> helpers, to set (and release) an interconnect path to a device. The >> bandwidth of this path will be updated when the OPPs are switched. >> >> Signed-off-by: Georgi Djakov >> --- >> drivers/opp/core.c | 67 ++++++++++++++++++++++++++++++++++++++++++ >> drivers/opp/of.c | 44 +++++++++++++++++++++++++++ >> drivers/opp/opp.h | 6 ++++ >> include/linux/pm_opp.h | 14 +++++++++ >> 4 files changed, 131 insertions(+) >> >> diff --git a/drivers/opp/core.c b/drivers/opp/core.c >> index e06a0ab05ad6..4b019cecaa07 100644 >> --- a/drivers/opp/core.c >> +++ b/drivers/opp/core.c >> @@ -19,6 +19,7 @@ >> #include >> #include >> #include >> +#include >> #include >> #include >> >> @@ -1645,6 +1646,72 @@ void dev_pm_opp_put_clkname(struct opp_table *opp_table) >> } >> EXPORT_SYMBOL_GPL(dev_pm_opp_put_clkname); >> >> +/** >> + * dev_pm_opp_set_path() - Set interconnect path for a device >> + * @dev: Device for which interconnect path is being set. >> + * @name: Interconnect path name or NULL. >> + * >> + * This must be called before any OPPs are initialized for the device. >> + */ >> +struct opp_table *dev_pm_opp_set_path(struct device *dev, const char *name) > > Maybe the OPP core can do it itself in a similar way to how we do > clk_get() today ? Do you mean to directly call of_icc_get() in _allocate_opp_table()? [..] >> +static int opp_parse_icc_bw(struct dev_pm_opp *opp, struct device *dev, >> + struct opp_table *opp_table) >> +{ >> + struct property *prop = NULL; >> + char name[NAME_MAX]; >> + int count; >> + u32 avg = 0; >> + u32 peak = 0; > > Why init to 0 ? Right, seems not necessary. >> + >> + /* Search for "opp-bw-MBs" */ >> + sprintf(name, "opp-bw-MBs"); >> + prop = of_find_property(opp->np, name, NULL); >> + >> + /* Missing property is not a problem */ >> + if (!prop) { >> + dev_dbg(dev, "%s: Missing opp-bw-MBs\n", __func__); >> + return 0; >> + } >> + >> + count = of_property_count_u32_elems(opp->np, name); >> + if (count != 2) { >> + dev_err(dev, "%s: Invalid number of elements in %s property\n", >> + __func__, name); >> + return -EINVAL; >> + } >> + >> + opp->bandwidth = kzalloc(sizeof(*opp->bandwidth), GFP_KERNEL); > > You forgot to free it. Will fix. [..]>> +/** >> + * struct dev_pm_opp_icc_bw - Interconnect bandwidth values >> + * @avg: Average bandwidth corresponding to this OPP (in icc units) >> + * @peak: Peak bandwidth corresponding to this OPP (in icc units) >> + * >> + * This structure stores the bandwidth values for a single interconnect path. >> + */ >> +struct dev_pm_opp_icc_bw { >> + u32 avg; >> + u32 peak; >> +}; > > There is only one user of this structure, maybe we can directly add > the elements in teh dev_pm_opp structure. Ok, will do it. Thanks, Georgi