Re: [PATCH v2 7/8] PCI: qcom: Add support for host_stop_link() & host_start_link()

Dmitry Baryshkov
2024-09-02T18:32:44Z

On Mon, Sep 02, 2024 at 12:21:22PM GMT, Krishna Chaitanya Chundru wrote:
>
>
> On 8/7/2024 12:42 AM, Bjorn Helgaas wrote:
> > On Sat, Aug 03, 2024 at 08:52:53AM +0530, Krishna chaitanya chundru wrote:
> > > For the switches like QPS615 which needs to configure it before
> > > the PCIe link is established.
> > >
> > > if the link is not up assert the PERST# and disable LTSSM bit so
> > > that PCIe controller will not participate in the link training
> > > as part of host_stop_link().
> > >
> > > De-assert the PERST# and enable LTSSM bit back in host_start_link().
> > >
> > > Introduce ltssm_disable function op to stop the link training.
> >
> > pcie-qcom.c is a driver for a PCIe host controller. Apparently QPS615
> > is a switch in a hierarchy that could be below any PCIe host
> > controller, so I'm missing the connection with pcie-qcom.c.
> >
> > Does this fix a problem that only occurs with pcie-qcom.c? What
> > happens if you put a QPS615 below some other controller?
> >
> Hi Bjorn,
>
> The qps615 is the qualcomm in-house PCIe switch it is not available to
> others. so we are trying to add for qualcomm soc's only.

Any guarantee that the status quo will stay so in future? Or that it
won't appear on Qualcomm platform with the virtualized PCIe controller?

--
With best wishes
Dmitry