From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E83C77B7D for ; Fri, 5 May 2023 19:15:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233226AbjEETPw (ORCPT ); Fri, 5 May 2023 15:15:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233232AbjEETPt (ORCPT ); Fri, 5 May 2023 15:15:49 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65BAD226B8 for ; Fri, 5 May 2023 12:15:48 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4efe9a98736so2503288e87.1 for ; Fri, 05 May 2023 12:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683314146; x=1685906146; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wiVwRTZ+QB0butBciUvZ61eG+cEutYbIrZIhBCvhP3o=; b=a1zUZVp7P+Bh2nA8KmCkZNONcnTB4MHeOE46Lo5mSrQI7toRazkTUA/yoQshat7VO+ VYhXS2FVhwq4dCXLY7FoPSN4NUQql0J8rOGYLunllmhQINLPecUim+rBM984BeTvyy8P D163wkf4ur+WUeZ+Ed8kkDv4Lv0BjdjLdxgkdLKdKyHgvl/KJjyDIU0gSKLJMd1nVcJO F8yRGaUESmmvlx6cJwB39T+UhQNqJo0NvkrGIllPrtwhYo1dV5HMd6guXUPAE8o+HnPU woDk8YjWyuQxMgG45Cgj+veypYdjUeVuW2unFsFLnIHhVSdF3ifPc9OKTosUsUAADO7B qQGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683314146; x=1685906146; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wiVwRTZ+QB0butBciUvZ61eG+cEutYbIrZIhBCvhP3o=; b=bQUlPuPNHZENQ3idH17hB1hBjIJgEnG5Cpy4gPateaCNoULOXwU1r/wCuNxyv6QSms ohRcaA+OwFg4K0W4/sTdjfE071S/d3+04jjbJ5ihYXz788QP4iPHcsaoBJW9CnN/ddXE SZ41eYU5/d02iuFjZEJ8c+fuIz4yJTvuHbAq3kcLxPQ+/vPArau7oSt6PLrIky3d2UJx KPT40eH8kyPEeh8H6KtnUKUdDFB8W8dR6Rtt1U2HVc3uXPeYvxw5jfr8vjdidX/e31Lz b+6OSP4Jmp+claewfJJb7pMDMgbI8H5dkSfCut+Kbumf/qp/+SUj2rh35PRKbV3zhIhq Qixg== X-Gm-Message-State: AC+VfDzxioyWYrPY/ckCYKz84i6yDONOP6yZGJyHl3C0/YZGn/DicRp2 Hljif3G6opicAKzAR+04wiW3Dg== X-Google-Smtp-Source: ACHHUZ64wwwFvhhC2i/OrhPzCndZiD4HH05o172Xk4jIKTQodmELoGOw0jIZCLOE94OPowrcDs4dAA== X-Received: by 2002:ac2:47ea:0:b0:4e0:fe29:9313 with SMTP id b10-20020ac247ea000000b004e0fe299313mr715981lfp.15.1683314146638; Fri, 05 May 2023 12:15:46 -0700 (PDT) Received: from [192.168.1.101] (abyl248.neoplus.adsl.tpnet.pl. [83.9.31.248]) by smtp.gmail.com with ESMTPSA id x20-20020ac24894000000b004db0d26adb4sm383136lfc.182.2023.05.05.12.15.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 12:15:46 -0700 (PDT) Message-ID: <0cfbb9ed-1bb0-ea9e-9896-9d3896ae18ff@linaro.org> Date: Fri, 5 May 2023 21:15:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 15/18] media: venus: vdec: Fix version check in vdec_set_work_route() Content-Language: en-US To: Vikash Garodia , Stanimir Varbanov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Bryan O'Donoghue , Mansur Alisha Shaik , Jonathan Marek , Hans Verkuil , Dikshita Agarwal Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten References: <20230228-topic-venus-v2-0-d95d14949c79@linaro.org> <20230228-topic-venus-v2-15-d95d14949c79@linaro.org> <2d1f85f2-42c5-1d88-7f0f-f464babfabbc@quicinc.com> From: Konrad Dybcio In-Reply-To: <2d1f85f2-42c5-1d88-7f0f-f464babfabbc@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 5.05.2023 16:02, Vikash Garodia wrote: > > On 5/4/2023 1:31 PM, Konrad Dybcio wrote: >> This is not so much V6-dependent as it's IRIS(1|2|2_1). Fix it. > Again, why is it marked as fix ? It corrects the logic but does not manifest on currently supported hardware. I'll reword it and drop the fixes tag. >> >> Fixes: 6483a8cbea54 ("media: venus: vdec: set work route to fw") >> Reviewed-by: Bryan O'Donoghue >> Signed-off-by: Konrad Dybcio >> --- >>   drivers/media/platform/qcom/venus/vdec.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c >> index 51a53bf82bd3..33e3f7208b1a 100644 >> --- a/drivers/media/platform/qcom/venus/vdec.c >> +++ b/drivers/media/platform/qcom/venus/vdec.c >> @@ -701,7 +701,7 @@ static int vdec_set_work_route(struct venus_inst *inst) >>       u32 ptype = HFI_PROPERTY_PARAM_WORK_ROUTE; >>       struct hfi_video_work_route wr; >>   -    if (!IS_V6(inst->core)) >> +    if (!(IS_IRIS1(inst->core) || IS_IRIS2(inst->core) || IS_IRIS2_1(inst->core))) > > Not a good idea to add IRIS1 just for deciding work route and not at other places in driver. Add IRIS1 relevant > > code in other aspects as well, if the patch needs to handle anything w.r.t IRIS1. I'd say that correcting this condition is fair regardless. I can however delay this patch until IRIS1 enablement if you'd prefer that. Konrad > >>           return 0; >>         wr.video_work_route = inst->core->res->num_vpp_pipes; >>