From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 151F1C64ED6 for ; Tue, 28 Feb 2023 15:58:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbjB1P6L (ORCPT ); Tue, 28 Feb 2023 10:58:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbjB1P5z (ORCPT ); Tue, 28 Feb 2023 10:57:55 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA96132E4E for ; Tue, 28 Feb 2023 07:57:24 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id bt28so10278591wrb.8 for ; Tue, 28 Feb 2023 07:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677599843; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RqxMJVUtV8W8U5LwK4W0E7Nqt6EcI+7j0jBpdLfc6FI=; b=dHcRetYKZpZwKmbStg0r3ZkEmFL+g5BMZWPfLmyviRO6WCRwXQPieM9jxtbSRaZ+FB 1CsLf77A9JaBilyOKuH7mxAzw49gJR/1tSxFwhhtp92/siWCSfEWUVvpgiqXbnPQZZlp KPpfnvV0cn8N+zwrzj0uZ+RAg53XQJ+PSPeAXlTbVwPfuvF95P1rfNS6Auy5BJiggi4b 1qo0l7juw9DyQSf/PlLLYi6o1+HbkTns17Kg8kylpKwBqMcFqx/4k8PT6RTJ/XFXjsU7 nK05qZVbYtXrr8P9BqH9PAJrguUVbJOJe/TidVltrXEFXErucl5KeTmZTlVVTjdjei8l rpLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677599843; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RqxMJVUtV8W8U5LwK4W0E7Nqt6EcI+7j0jBpdLfc6FI=; b=WgYJZmJni0ePcQHvjLBbVp3rW6JDHYNQ7sbf1YlAoLiyzuo6eeQwn9NZwjme1ggD0b /q7QX0cd/ueErV/ZXOYUntVYhdf+SVTIuLVrLEywwZrG2Akoxiu++TQWuxuci/0Ykw1d jFBcQpT4vIfPNiHpZ5+urL/hFN+KpaJ7X5nc9j0vz/K81aAFjt4Ag7qjKBi9UHQPP6Wx 2MPALTI03955RMwUvXJdg7Pj+leeAfmJV5FjaBHpbadOMWm6Rf3UZsEuC3lu1BKmmRs8 Ko+qJA0nDAdLGKVlXbWUqHh5Xn5rgM+3YLteHjuR8C82iLdBbLfLB/N2FDUAE+36aEVU VKWQ== X-Gm-Message-State: AO0yUKX3MOac0B2/+kFvIVS7dGajplnrpekvluZHFoXgJmbVnP1pudXI DVUQxtlEufEDFFTWdGaPPmx1ZQ== X-Google-Smtp-Source: AK7set96h7J2Kq+YCW0rrA126qgFYtYnjjnV1UcYlNIWEQFzEGEqGjhS2hxkh502vg/Y/dsdojxVPw== X-Received: by 2002:a05:6000:11c7:b0:2c3:eeeb:b2f7 with SMTP id i7-20020a05600011c700b002c3eeebb2f7mr2432637wrx.62.1677599843225; Tue, 28 Feb 2023 07:57:23 -0800 (PST) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id t14-20020adfe44e000000b002c5503a8d21sm10387625wrm.70.2023.02.28.07.57.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Feb 2023 07:57:22 -0800 (PST) Message-ID: <0d319988-e4fe-3c67-fca6-fee3ff94f673@linaro.org> Date: Tue, 28 Feb 2023 15:57:21 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 18/18] media: venus: hfi_venus: Restrict writing SCIACMDARG3 to Venus V1/V2 Content-Language: en-US To: Konrad Dybcio , Stanimir Varbanov , Vikash Garodia , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Dikshita Agarwal , Dikshita Agarwal , Mansur Alisha Shaik , Jonathan Marek Cc: Mauro Carvalho Chehab , Stanimir Varbanov , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Vikash Garodia References: <20230228-topic-venus-v1-0-58c2c88384e9@linaro.org> <20230228-topic-venus-v1-18-58c2c88384e9@linaro.org> From: Bryan O'Donoghue In-Reply-To: <20230228-topic-venus-v1-18-58c2c88384e9@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/02/2023 15:24, Konrad Dybcio wrote: > This write was last present on msm-3.10, which means before HFI3XX > platforms were introduced. Guard it with an appropriate if condition. > > Signed-off-by: Konrad Dybcio > --- > drivers/media/platform/qcom/venus/hfi_venus.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c > index c2d134e04c30..deeceb86414d 100644 > --- a/drivers/media/platform/qcom/venus/hfi_venus.c > +++ b/drivers/media/platform/qcom/venus/hfi_venus.c > @@ -463,7 +463,8 @@ static int venus_boot_core(struct venus_hfi_device *hdev) > } > > writel(mask_val, wrapper_base + WRAPPER_INTR_MASK); > - writel(1, cpu_cs_base + CPU_CS_SCIACMDARG3); > + if (IS_V1(hdev->core)) > + writel(1, cpu_cs_base + CPU_CS_SCIACMDARG3); > > writel(BIT(VIDC_CTRL_INIT_CTRL_SHIFT), cpu_cs_base + VIDC_CTRL_INIT); > while (!ctrl_status && count < max_tries) { > Looks good. Which platforms have you tested this change on ? Can you include that detail in the commit log ? --- bod