Re: [PATCH V3 4/5] arm64: dts: qcom: ipq9574: Add SMPA1 regulator node

[Devi Priya <quic_devipriy@quicinc.com>]

On 4/7/2023 1:17 AM, Konrad Dybcio wrote:
> 
> 
> On 6.04.2023 09:00, Devi Priya wrote:
>> Add support for SMPA1 regulator node in IPQ9574.
>>
>> Co-developed-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
>> ---
>>   Changes in V3:
>> 	- Updated the regulator-min-microvolt with the SVS voltage 725000uV
>>
>>   arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
>> index 3ae38cf327ea..06f579b1c590 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
>> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts
>> @@ -44,6 +44,25 @@
>>   	};
>>   };
>>   
>> +&rpm_requests {
>> +	regulators {
>> +		compatible = "qcom,rpm-mp5496-regulators";
>> +
>> +		ipq9574_s1: s1 {
>> +		/*
>> +		 * During kernel bootup, the SoC runs at 800MHz with 875mV set by the bootloaders.
>> +		 * During regulator registration, kernel not knowing the initial voltage,
>> +		 * considers it as zero and brings up the regulators with minimum supported voltage.
> 
>> +		 * Updating the regulator-min-microvolt with SVS voltage of 725000uV so that
> s/Updating/Update
> s/725000uV/725mV here and below (for consistency with the first mention
> of 800mV)
> 
Sure, will update!
> Konrad
>> +		 * the regulators are brought up with 725000uV which is sufficient for all the
>> +		 * corner parts to operate at 800MHz
>> +		 */
>> +			regulator-min-microvolt = <725000>;
>> +			regulator-max-microvolt = <1075000>;
>> +		};
>> +	};
>> +};
>> +
>>   &pcie1_phy {
>>   	status = "okay";
>>   };