From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B57630DEB7 for ; Mon, 1 Dec 2025 12:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764593745; cv=none; b=HEZNCN3llMjYqb6EwmhHTRJ5gAujoPA+G89iEWVcFiW7iKj4Yv12vAeTTaaEVn7tUoMzDEuM+6eUth3FVu5grAZ6JddILXMNq47PHkwsRRFqR8nvzUainUAi3TJgygtNkVNVOHRttXgIIqCplAyvU0sDfS+my2qq3hycD7r93tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764593745; c=relaxed/simple; bh=qjX1boH73SydNBCKz6rHEzs7qKGoe+IFikmqMqToHyw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CwQ13i4jTUVfgVtrgJC7uuHdZMtQC2ADEgZjjUCM5AkNyV0wJurPdUiUwYyRLiVqspWOVDc+S++KFA8IEzjIbprt9yEEy3Pbjc4XAUT9h9aap+MSIcKQGiHyoLy7+PTVSSVzH6q6aCA3VhGQZ3nCdTuTEZhEI8UrsKNI8l/i6ng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S0BfY/UJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Dk77N16E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S0BfY/UJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Dk77N16E" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B19MAhi3361535 for ; Mon, 1 Dec 2025 12:55:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P0bpogltmQbh7eQJBYiW+bKvhzS+VMTMFejGkBnimcE=; b=S0BfY/UJX158Rdxn eaO7DsrRTqxR9Jeg3D3Dquagr/XXW/x8NUqoq2cnpVD91mHI6awFGb+0+Rh3jhTz +RFjp5IIpVPa+hLr6H1xMi1C9p+Sitjxv9/agGXN+9XWNPAxscy2ZbVwZyXpXIeF Vfizccnc0lNSpk2ejy8tgz4zUr1Mkb0KBIhYW4K1EI7cGhA9fiS7ve4QiRscIJpe 9OV0Py2i+Ygxd/PFdidpBGHb9QZbDEvKBr1YxrJt/kUTLkkbbYjKMQrj9rSN2CUK kg4dEySdiOqhvvm5Gf973QBVxGR27ox+rRYj5vUy5N1u2GKZug8jxuVqbs1+5HMd fKTMSg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4as8b00k9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Dec 2025 12:55:42 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ede0bd2154so15108331cf.1 for ; Mon, 01 Dec 2025 04:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764593741; x=1765198541; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P0bpogltmQbh7eQJBYiW+bKvhzS+VMTMFejGkBnimcE=; b=Dk77N16EBC7xrAX9Z6slMdyv3QO3I9v84DS2czXq66Ai6XPq00KJXDrF7uo0fgVjem Cs0KVdfKXBenocsYljEFH+0Qbrp8026oQSdWaMTt6Na4Bq1ficWdxFYmtYOGub0bvEIn z25oEZJqEZfZ1YOpIcQ7E5Tu0oKZzMjl2df+Ltm9H0vfY1IaVqof3XWTMg353l0ZqLZj i3GgoILlQz40F+BSwnTt2FrOIN5UnAUbVxw+QIu9aAY6p8Sunz4IG6m9vkyb5Qh3IobP XdgUEiDlNJu8EeD9xGAJQOmpPhISsWANwhaaKWkV2equKDUqi9k/ud5zYyTsNX8Ib1Sh TmIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764593741; x=1765198541; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P0bpogltmQbh7eQJBYiW+bKvhzS+VMTMFejGkBnimcE=; b=JKLDlYSx+/Ad/D8tB8hVdzsQyQym+t76uMzsATkD9SNLpvLs2LK02MPvuVzA6hIVn2 QrIk+W031iaexJG3gddVEnklHCBjcsG2fohyr08Zdq+8WtDWRHFt0+b0QuqHioiztEdw nMfzmTfrRt5+NR+UkSPuRRmjTCM+ePjmW/hDwZLQsm8QF+CiCqP5OKSAqFo3N9cRU8f1 0k7RugEWvFtc778TWeV5sOE7AuK1k0eUmNl3C5ogxNKjLHySosMznYp5o5XtTZ7dE9Xt 43Ul+A1O7cxSM7mCARQw0M9q4du2Gf28Tukd0lgjdrH6urpLgpLAZLZxK+u7Q0rMVDfF zuYw== X-Gm-Message-State: AOJu0Ywivi1v9Ckq2yrY5mEeOX7Uwi4WIoTwdFhEjb7Axb2bVGvYWFwf Lm4cGoHAw1flCs/sl3WUiPcZnhXRoYqlFWohHg6iNxqGHjFvsGMJBmP61UGBTH71EpIaLTaPERh jYJ0qUL+Ndhlc0lP6Q+5f8RDxqFMQ/TfOif9scEgR0dh6GIsaVZkQz6ueINDDz4RHLEF9 X-Gm-Gg: ASbGncu2fZo5ayAGsLr7f8bQLinIHxb6/A49Q9Ey2ku5kmQHJOqd6/U2apLOJd1Z/EN Uw2BLGX6hoVeOHDuytLG06+vJKzcG0bBr+4Et3FlHwnd2VyEXnbCbLu7g+4dskLqkPSFOKZx5mI gU+iyLWJbIF3Y7Y1/rGzXKrskbwsnuDYWm/jvlcOijT9ixwoCuogb35qyXdQRYuzdE/oqCTopBT WDp0m/vEbSkPFgUQQNQmOGlU7TwoAbvxIna4LERVdc6NuAUpAz/F50A68ZiedS5qleAstzpKh7X esBd27yz9y0+Vl0nPFKAlJC19goKv7zxv3VM38vHA0vR6kAyr5aqImvkqQKmGH7/v3NBHgKfgOk +XRgOrKu/IIz5EtchItNfHdFB3rw3Uh2iHSTsQ2F7rnE1sMCWHh7YxBj33NqMv2D091o= X-Received: by 2002:a05:622a:1108:b0:4ed:a574:64cb with SMTP id d75a77b69052e-4ee58850982mr407107051cf.3.1764593740995; Mon, 01 Dec 2025 04:55:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmjj0MqTTdL7Sg51Iv8ThAIsd2fTvcywFmFZkGgrzSN/jzajCzDAtkVxmT1U936hxOLJRBSQ== X-Received: by 2002:a05:622a:1108:b0:4ed:a574:64cb with SMTP id d75a77b69052e-4ee58850982mr407106831cf.3.1764593740545; Mon, 01 Dec 2025 04:55:40 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64750a90c93sm12300309a12.9.2025.12.01.04.55.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 04:55:40 -0800 (PST) Message-ID: <0d63bddf-7a88-4c59-8ba3-6655e7a8854e@oss.qualcomm.com> Date: Mon, 1 Dec 2025 13:55:38 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: labibb is not used on OnePlus 6/6T To: Casey Connolly , david@ixit.cz, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251130-oneplus-labibb-v1-1-bb3653e43120@ixit.cz> <3fcfc5b8-7509-4e4c-a1cd-e973d7e1d091@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TcKbdBQh c=1 sm=1 tr=0 ts=692d904e cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=4_HY7mAHSgI59XXtPg4A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: 3jlBhwiQWG3zz-9yteAkz84yDVcYh1jk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDEwNSBTYWx0ZWRfX4DxJk6Xu8eiX 2novXFzQXk+F6XIkrSc3EoeglLfKUHv9Q0vS64UwloAwH1xEcYEbKkhuZ7AnSFNd/j3JT/i96M9 uliNfq7iSBtFTY9Did3QYTA+DFlBkhti9Ds0zc63lE1S/a2Y+2wk8SpgWqVjDQwKoBMBdsleg0R x6/Gik4i7b+FE6ltTzDYprHELtUcCC2pErietLW+OQIqMNNxkplq62ygz/VxbiUUd2a+M/ELWhZ lJee2yqhQh4JjeftTmzjOYSdCt69+ffPhOoZUl6Sdl2wXhHGEL9LWEPElPy0erfJHDxevI/n3qL RXeINQTX0D9Td6bJ0kKN90lGm4ZecAqbG1HH0kbMTHkHf39bB6HEgpw3i2YHuAJ2Hee47SJVrrm ZCmW+7/rLLrX1NMCWnqAEzpQZ32zRw== X-Proofpoint-GUID: 3jlBhwiQWG3zz-9yteAkz84yDVcYh1jk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512010105 On 12/1/25 1:50 PM, Casey Connolly wrote: > > > On 01/12/2025 13:48, Konrad Dybcio wrote: >> On 11/30/25 1:08 AM, David Heidelberg via B4 Relay wrote: >>> From: David Heidelberg >>> >>> The lab and ibb regulators aren't used here. Disable them. >>> >>> Removes following warnings: >>> qcom-lab-ibb-regulator c440000.spmi:pmic@3:labibb: Failed to create device link (0x180) with supplier c440000.spmi for /soc@0/spmi@c440000/pmic@3/labibb/lab >>> qcom-lab-ibb-regulator c440000.spmi:pmic@3:labibb: Failed to create device link (0x180) with supplier c440000.spmi for /soc@0/spmi@c440000/pmic@3/labibb/ibb >> >> These are only vaguely related, as there's nothing to be wary about that's >> specific to these devices - it's just devlink being grumpy >> >>> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices") >>> Signed-off-by: David Heidelberg >>> --- >>> I assume this is right approach, as OLEDs on both devices are driven by >>> different regulators. >>> >>> Question is, if should be labibb nodes enabled by default? >> >> They're onboard. I'd rather keep them predictably parked than left in >> whatever (potentially ON) state the bootloader may leave them at > > Shouldn't they be default disabled in the pmic dtsi and only enabled on > the devices that actually use them? Many SDM845 devices with OLED panels > don't use these regulators. As I said, I wouldn't be surprised if they were enabled by the bootloader as part of some reference/common routine and left hanging. Linux will switch them off if they're never used and I'm fairly sure the users won't mind the odd couple dozen bytes of runtime kernel memory usage (which if we go that route probably balance out with the added couple characters for status=disabled in the resulting DTB) Konrad