From: Daniel Mack <daniel@zonque.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Rob Clark <rclark@redhat.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Sushmita Susheelendra <ssusheel@codeaurora.org>,
Vinay Simha <simhavcs@gmail.com>
Subject: Re: [PATCH RESEND 1/2] drm/msm: remove unbalanced mutex unlock
Date: Thu, 3 May 2018 19:59:55 +0200 [thread overview]
Message-ID: <0eb26699-afcf-171e-ea99-80247a74d1fc@zonque.org> (raw)
In-Reply-To: <CAF6AEGs5NeLr9xp8ALYowhw9yV8UYCdyV07Tca4xE9Kwq+QyPA@mail.gmail.com>
On Thursday, May 03, 2018 02:24 PM, Rob Clark wrote:
> On Thu, May 3, 2018 at 8:00 AM, Daniel Mack <daniel@zonque.org> wrote:
>> This regression stems from 0e08270a1f01 ("drm/msm: Separate locking of
>> buffer resources from struct_mutex").
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
>> Cc: Sushmita Susheelendra <ssusheel@codeaurora.org>
>> Cc: Rob Clark <rclark@redhat.com>
>> Fixes: 0e08270a1f01 ("drm/msm: Separate locking of buffer resources from struct_mutex")
>> ---
>> I'm resending these two patches as I got no reply last time.
>
> I've applied these two to msm-next. Sorry I missed them before...
> for some reason they don't seem to show up in the dri-devel
> patchworks[1]
No problem, and thanks for applying them :)
Daniel
>
> BR,
> -R
>
> [1] https://patchwork.freedesktop.org/project/dri-devel/series/
>
>>
>> drivers/gpu/drm/msm/dsi/dsi_host.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> index 0f7324a686ca..27637d8a99ff 100644
>> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
>> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
>> @@ -994,7 +994,6 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size)
>>
>> ret = msm_gem_get_iova(msm_host->tx_gem_obj,
>> priv->kms->aspace, &iova);
>> - mutex_unlock(&dev->struct_mutex);
>> if (ret) {
>> pr_err("%s: failed to get iova, %d\n", __func__, ret);
>> return ret;
>> --
>> 2.14.3
>>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-05-03 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 12:00 [PATCH RESEND 1/2] drm/msm: remove unbalanced mutex unlock Daniel Mack
2018-05-03 12:00 ` [PATCH RESEND 2/2] drm/msm: use correct aspace pointer in msm_gem_put_iova() Daniel Mack
2018-05-03 12:24 ` [PATCH RESEND 1/2] drm/msm: remove unbalanced mutex unlock Rob Clark
2018-05-03 17:59 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eb26699-afcf-171e-ea99-80247a74d1fc@zonque.org \
--to=daniel@zonque.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=rclark@redhat.com \
--cc=robdclark@gmail.com \
--cc=simhavcs@gmail.com \
--cc=ssusheel@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox