From: Dikshita Agarwal <quic_dikshita@quicinc.com>
To: Patrick Whewell <patrick.whewell@sightlineapplications.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
William Gray <william.gray@linaro.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
<linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] media: venus: Fix firmware path for resources
Date: Fri, 28 Jul 2023 14:35:48 +0530 [thread overview]
Message-ID: <0ec5202e-02c0-2df4-42bf-e4faa824f243@quicinc.com> (raw)
In-Reply-To: <20230719214943.22641-1-patrick.whewell@sightlineapplications.com>
On 7/20/2023 3:19 AM, Patrick Whewell wrote:
> The firmware path for some of the resources is still the old format. This
> fixes the path to address the firmware correctly using the new .mbn
> format.
>
> Signed-off-by: Patrick Whewell <patrick.whewell@sightlineapplications.com>
> ---
the changes look good to me.
Reviewed-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
> I've updated all .fwname to match the .mbn format. There is a
> qcom/venus-4.4/venus.mdt for the sdm660 that still remains but the linux-firmware
> package does not contain that firmware file anymore, so i left as is.
>
> drivers/media/platform/qcom/venus/core.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 2ae867cb4c48..2d62669d99e1 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -548,7 +548,7 @@ static const struct venus_resources msm8916_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xddc00000 - 1,
> - .fwname = "qcom/venus-1.8/venus.mdt",
> + .fwname = "qcom/venus-1.8/venus.mbn",
> };
>
> static const struct freq_tbl msm8996_freq_table[] = {
> @@ -581,7 +581,7 @@ static const struct venus_resources msm8996_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xddc00000 - 1,
> - .fwname = "qcom/venus-4.2/venus.mdt",
> + .fwname = "qcom/venus-4.2/venus.mbn",
> };
>
> static const struct freq_tbl sdm660_freq_table[] = {
> @@ -688,7 +688,7 @@ static const struct venus_resources sdm845_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xe0000000 - 1,
> - .fwname = "qcom/venus-5.2/venus.mdt",
> + .fwname = "qcom/venus-5.2/venus.mbn",
> };
>
> static const struct venus_resources sdm845_res_v2 = {
> @@ -717,7 +717,7 @@ static const struct venus_resources sdm845_res_v2 = {
> .cp_size = 0x70800000,
> .cp_nonpixel_start = 0x1000000,
> .cp_nonpixel_size = 0x24800000,
> - .fwname = "qcom/venus-5.2/venus.mdt",
> + .fwname = "qcom/venus-5.2/venus.mbn",
> };
>
> static const struct freq_tbl sc7180_freq_table[] = {
> @@ -760,7 +760,7 @@ static const struct venus_resources sc7180_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xe0000000 - 1,
> - .fwname = "qcom/venus-5.4/venus.mdt",
> + .fwname = "qcom/venus-5.4/venus.mbn",
> };
>
> static const struct freq_tbl sm8250_freq_table[] = {
> @@ -814,7 +814,7 @@ static const struct venus_resources sm8250_res = {
> .vmem_size = 0,
> .vmem_addr = 0,
> .dma_mask = 0xe0000000 - 1,
> - .fwname = "qcom/vpu-1.0/venus.mdt",
> + .fwname = "qcom/vpu-1.0/venus.mbn",
> };
>
> static const struct freq_tbl sc7280_freq_table[] = {
next prev parent reply other threads:[~2023-07-28 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 18:53 [PATCH] media: venus: Fix firmware path for sm8250 Patrick Whewell
2023-07-12 9:50 ` Bryan O'Donoghue
2023-07-19 13:03 ` Dmitry Baryshkov
2023-07-19 13:04 ` Bryan O'Donoghue
2023-07-19 21:49 ` [PATCH v2] media: venus: Fix firmware path for resources Patrick Whewell
2023-07-28 9:05 ` Dikshita Agarwal [this message]
2023-09-12 16:26 ` William Breathitt Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ec5202e-02c0-2df4-42bf-e4faa824f243@quicinc.com \
--to=quic_dikshita@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=patrick.whewell@sightlineapplications.com \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox