From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: "Barnabás Czémán" <trabarni@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Andy Gross" <agross@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: qcom: gcc-msm8953: fix stuck gcc_usb30_master_clk
Date: Sat, 7 Oct 2023 01:50:18 +0200 [thread overview]
Message-ID: <0eebfc14-dbcd-4987-9e94-ea5630b6c268@linaro.org> (raw)
In-Reply-To: <20231002170021.192740-1-trabarni@gmail.com>
On 2.10.2023 19:00, Barnabás Czémán wrote:
> According to downstream dwc3-msm source this clock has FSM dependency on
> gcc_pcnoc_usb30_clk so enabling it would fail if latter isn't enabled.
> This patch add works around this issue by changing parent of
> gcc_usb30_master_clk to gcc_pcnoc_usb30_clk. This is acceptable because
> both clocks have same parent and are branches/gates.
>
> Signed-off-by: Barnabás Czémán <trabarni@gmail.com>
> ---
"meh"
There are multiple cases, especially with qcom, where there are some
magic "dependencies" without parent-child relationship. The common
clock framework doesn't currently have any good way to handle this,
other than some mind gymnastics like you had to do here with matching
them against a common parent/ancestor..
Stephen, what do you say?
Konrad
next prev parent reply other threads:[~2023-10-06 23:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 17:00 [PATCH] clk: qcom: gcc-msm8953: fix stuck gcc_usb30_master_clk Barnabás Czémán
2023-10-06 23:50 ` Konrad Dybcio [this message]
2023-10-24 2:59 ` Stephen Boyd
2023-11-18 0:48 ` Konrad Dybcio
2023-11-22 6:09 ` Krishna Kurapati PSSNV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0eebfc14-dbcd-4987-9e94-ea5630b6c268@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=trabarni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox