From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD71C77B73 for ; Thu, 20 Apr 2023 19:51:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232134AbjDTTv1 (ORCPT ); Thu, 20 Apr 2023 15:51:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232045AbjDTTv0 (ORCPT ); Thu, 20 Apr 2023 15:51:26 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CACA54C26 for ; Thu, 20 Apr 2023 12:51:24 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2a8ba23a2abso7748961fa.2 for ; Thu, 20 Apr 2023 12:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682020283; x=1684612283; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/a0xpbCUh8XvBFyvG3Vr8vwGN+W0r6uMQEO9ehg+QV4=; b=zBr3TpHqf1AS9j2rsa0zNinD/3EVDw8o66VhW6Cs1x9gQZOqenezbfaXcgGGI+wHd9 7E2v5qh2QaItjfhTeNhXKUB9yuikZWqg9lrIiTaWWO86IteWxF7PKcSxKhhgpe7hlzIv +Ra8UnT08hKJttPIuAkoOFBSBg1+jkqWVeS9dOiQhpUAwB7+kA5rmprYuoaXUuKRGJva c/CscWhbir1fbJ8aTrJiFgOGZ9nVf2IFVk3Mg8GiDVk3wL0v4e6NHF04VJ8vZm8Ss/BG xPn6mh1eNYUmkFAh1ek0NJ7HQdzf9PHSYa1Yxh/g9At0nlp991N6Z7gaGb3Eu6HoGeer x+Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682020283; x=1684612283; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/a0xpbCUh8XvBFyvG3Vr8vwGN+W0r6uMQEO9ehg+QV4=; b=Xk7z02se3JeHDWrY6TM8L7Sbzn9F8Zjif7tPPayWENoq7+mryotrmq8juMitNwXT+T 3FNA/YomFQRUb//xa3p8vxNc7Cl3JziPdV3c/eFqLDLCzFdjy5T3+VYqOfc2p2kmnj88 N6H96f/NSl+5gdn6oKG82P3vKJ29x9QbjljTlU9Ln3TWwf/TFoyzytDBkFCZehqn9Dai 0HAsTGMyVQXRocN84KmTTWcb6E2xhCAmHJKqwhx6K4+paM6vRS6jfk2boolUqpgI1brm N42ZCeiY4wsnbeCplFUunlQWazOJdwafdji5mPQe5qzNO2rdGQYNVQ2LdVuKhVG+mEVy xXZg== X-Gm-Message-State: AAQBX9d+Z9vPYv04WIcCq6apBcN7aEgfmC4U2U5Gp+UJyoOUHa6xCvJk 2U/m1BlmsjwgQi57fGMYF8k5HA== X-Google-Smtp-Source: AKy350bJOaN/yiqVcikZK2R1lIXdVY7PZHt7PQe9jzpzreObSOXLbS7TfSQAXyaEMHcVORKfBHdasQ== X-Received: by 2002:a05:6512:61:b0:4ef:5a59:12f6 with SMTP id i1-20020a056512006100b004ef5a5912f6mr17552lfo.16.1682020283052; Thu, 20 Apr 2023 12:51:23 -0700 (PDT) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id l13-20020ac24a8d000000b004eb3b6acfe6sm311735lfp.213.2023.04.20.12.51.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Apr 2023 12:51:22 -0700 (PDT) Message-ID: <0f469b3c-5f0f-e027-8a9f-d1233169c04a@linaro.org> Date: Thu, 20 Apr 2023 22:51:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 0/2] DPU1 GC1.8 wiring-up Content-Language: en-GB To: Abhinav Kumar , Konrad Dybcio , Rob Clark , Sean Paul , David Airlie , Daniel Vetter Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20230420-topic-dpu_gc-v1-0-d9d1a5e40917@linaro.org> <5b133c55-e4f5-bfd2-b542-a7d44313c038@linaro.org> <3f3b3637-ed85-09a1-22b7-3ccd4bc929bb@quicinc.com> <2dff9d62-cffe-c66f-9e50-3ecd64e44d37@linaro.org> <6a335df7-ff0b-098a-feec-45714159df04@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 20/04/2023 22:47, Abhinav Kumar wrote: > > > On 4/20/2023 11:01 AM, Dmitry Baryshkov wrote: >> On 20/04/2023 04:36, Konrad Dybcio wrote: >>> >>> >>> On 20.04.2023 03:28, Abhinav Kumar wrote: >>>> >>>> >>>> On 4/19/2023 6:26 PM, Konrad Dybcio wrote: >>>>> >>>>> >>>>> On 20.04.2023 03:25, Dmitry Baryshkov wrote: >>>>>> On 20/04/2023 04:14, Konrad Dybcio wrote: >>>>>>> Almost all SoCs from SDM845 to SM8550 inclusive feature a GC1.8 >>>>>>> dspp sub-block in addition to PCCv4. The other block differ a bit >>>>>>> more, but none of them are supported upstream. >>>>>>> >>>>>>> This series adds configures the GCv1.8 on all the relevant SoCs. >>>>>> >>>>>> Does this mean that we will see gamma_lut support soon? >>>>> No promises, my plate is not even full, it's beyond overflowing! :P >>>>> >>>>> Konrad >>>> >>>> So I think I wrote about this before during the catalog rework/fixes >>>> that the gc registers are not written to / programmed. >>>> >>>> If thats not done, is there any benefit to this series? >>> Completeness and preparation for the code itself, if nothing else? >> >> The usual problem is that if something is not put to use, it quickly >> rots or becomes misused for newer platforms. We have seen this with >> the some of DPU features. >> >> In case of GC (and the freshly defined DPU_DSPP_IGC, but not used) we >> have three options: >> - drop the unused GC from msm8998_sblk. >> - keep things as is, single unused GC entry >> - fill all the sblk with the correct information in hope that it stays >> correct >> >> Each of these options has its own drawbacks. I have slight bias >> towards the last option, to have the information in place (as long as >> it is accurate). >> > > My vote is for (1) . Today, GC is unused and from the discussion here, > there is no concrete plan to add it. If we keep extending an unused > bitmask for all the chipsets including the ones which will get added in > the future in the hope that someday the feature comes, it doesnt sound > like a good idea. > > I would rather do (1), if someone has time. Agree, this was the second item on my preference list. Could you please send this oneliner? > OR lets stay at (2) till > someone does (1). > > When someone implements GC, we can re-use this patch and that time keep > konrad's author rights or co-developed by. > > -- With best wishes Dmitry