linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeykumar Sankaran <jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
Cc: Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Subject: Re: [PATCH 2/6] drm/msm: dpu: Remove unused functions from msm_media_info.h
Date: Mon, 08 Oct 2018 15:27:36 -0700	[thread overview]
Message-ID: <10534a4df9830bd00d2e4f5ab12dc657@codeaurora.org> (raw)
In-Reply-To: <20180920145818.32468-3-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>

On 2018-09-20 07:58, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> These functions aren't used anywhere, remove them.
> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>

Reviewed-by: Jeykumar Sankaran <jsanka@codeaurora.org>

> ---
>  .../gpu/drm/msm/disp/dpu1/msm_media_info.h    | 171 ------------------
>  1 file changed, 171 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/msm_media_info.h
> b/drivers/gpu/drm/msm/disp/dpu1/msm_media_info.h
> index 4f12e5c534c8..1a35dfb4a4e5 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/msm_media_info.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/msm_media_info.h
> @@ -813,18 +813,6 @@ enum color_fmts {
>  #define COLOR_FMT_P010_UBWC		COLOR_FMT_P010_UBWC
>  #define COLOR_FMT_P010		COLOR_FMT_P010
> 
> -static inline unsigned int VENUS_EXTRADATA_SIZE(int width, int height)
> -{
> -	(void)height;
> -	(void)width;
> -
> -	/*
> -	 * In the future, calculate the size based on the w/h but just
> -	 * hardcode it for now since 16K satisfies all current usecases.
> -	 */
> -	return 16 * 1024;
> -}
> -
>  /*
>   * Function arguments:
>   * @color_fmt
> @@ -1214,163 +1202,4 @@ static inline unsigned int
> VENUS_RGB_META_SCANLINES(int color_fmt, int height)
>  	return rgb_meta_scanlines;
>  }
> 
> -/*
> - * Function arguments:
> - * @color_fmt
> - * @width
> - * Progressive: width
> - * Interlaced: width
> - * @height
> - * Progressive: height
> - * Interlaced: height
> - */
> -static inline unsigned int VENUS_BUFFER_SIZE(
> -	int color_fmt, int width, int height)
> -{
> -	const unsigned int extra_size = VENUS_EXTRADATA_SIZE(width,
> height);
> -	unsigned int uv_alignment = 0, size = 0;
> -	unsigned int y_plane, uv_plane, y_stride,
> -		uv_stride, y_sclines, uv_sclines;
> -	unsigned int y_ubwc_plane = 0, uv_ubwc_plane = 0;
> -	unsigned int y_meta_stride = 0, y_meta_scanlines = 0;
> -	unsigned int uv_meta_stride = 0, uv_meta_scanlines = 0;
> -	unsigned int y_meta_plane = 0, uv_meta_plane = 0;
> -	unsigned int rgb_stride = 0, rgb_scanlines = 0;
> -	unsigned int rgb_plane = 0, rgb_ubwc_plane = 0, rgb_meta_plane =
> 0;
> -	unsigned int rgb_meta_stride = 0, rgb_meta_scanlines = 0;
> -
> -	if (!width || !height)
> -		goto invalid_input;
> -
> -	y_stride = VENUS_Y_STRIDE(color_fmt, width);
> -	uv_stride = VENUS_UV_STRIDE(color_fmt, width);
> -	y_sclines = VENUS_Y_SCANLINES(color_fmt, height);
> -	uv_sclines = VENUS_UV_SCANLINES(color_fmt, height);
> -	rgb_stride = VENUS_RGB_STRIDE(color_fmt, width);
> -	rgb_scanlines = VENUS_RGB_SCANLINES(color_fmt, height);
> -
> -	switch (color_fmt) {
> -	case COLOR_FMT_NV21:
> -	case COLOR_FMT_NV12:
> -	case COLOR_FMT_P010:
> -		uv_alignment = 4096;
> -		y_plane = y_stride * y_sclines;
> -		uv_plane = uv_stride * uv_sclines + uv_alignment;
> -		size = y_plane + uv_plane +
> -				MSM_MEDIA_MAX(extra_size, 8 * y_stride);
> -		size = MSM_MEDIA_ALIGN(size, 4096);
> -		break;
> -	case COLOR_FMT_NV12_MVTB:
> -		uv_alignment = 4096;
> -		y_plane = y_stride * y_sclines;
> -		uv_plane = uv_stride * uv_sclines + uv_alignment;
> -		size = y_plane + uv_plane;
> -		size = 2 * size + extra_size;
> -		size = MSM_MEDIA_ALIGN(size, 4096);
> -		break;
> -	case COLOR_FMT_NV12_UBWC:
> -		y_sclines = VENUS_Y_SCANLINES(color_fmt, (height+1)>>1);
> -		y_ubwc_plane = MSM_MEDIA_ALIGN(y_stride * y_sclines,
> 4096);
> -		uv_sclines = VENUS_UV_SCANLINES(color_fmt, (height+1)>>1);
> -		uv_ubwc_plane = MSM_MEDIA_ALIGN(uv_stride * uv_sclines,
> 4096);
> -		y_meta_stride = VENUS_Y_META_STRIDE(color_fmt, width);
> -		y_meta_scanlines =
> -			VENUS_Y_META_SCANLINES(color_fmt, (height+1)>>1);
> -		y_meta_plane = MSM_MEDIA_ALIGN(
> -			y_meta_stride * y_meta_scanlines, 4096);
> -		uv_meta_stride = VENUS_UV_META_STRIDE(color_fmt, width);
> -		uv_meta_scanlines =
> -			VENUS_UV_META_SCANLINES(color_fmt, (height+1)>>1);
> -		uv_meta_plane = MSM_MEDIA_ALIGN(uv_meta_stride *
> -			uv_meta_scanlines, 4096);
> -
> -		size = (y_ubwc_plane + uv_ubwc_plane + y_meta_plane +
> -			uv_meta_plane)*2 +
> -			MSM_MEDIA_MAX(extra_size + 8192, 48 * y_stride);
> -		size = MSM_MEDIA_ALIGN(size, 4096);
> -		break;
> -	case COLOR_FMT_NV12_BPP10_UBWC:
> -		y_ubwc_plane = MSM_MEDIA_ALIGN(y_stride * y_sclines,
> 4096);
> -		uv_ubwc_plane = MSM_MEDIA_ALIGN(uv_stride * uv_sclines,
> 4096);
> -		y_meta_stride = VENUS_Y_META_STRIDE(color_fmt, width);
> -		y_meta_scanlines = VENUS_Y_META_SCANLINES(color_fmt,
> height);
> -		y_meta_plane = MSM_MEDIA_ALIGN(
> -				y_meta_stride * y_meta_scanlines, 4096);
> -		uv_meta_stride = VENUS_UV_META_STRIDE(color_fmt, width);
> -		uv_meta_scanlines = VENUS_UV_META_SCANLINES(color_fmt,
> height);
> -		uv_meta_plane = MSM_MEDIA_ALIGN(uv_meta_stride *
> -					uv_meta_scanlines, 4096);
> -
> -		size = y_ubwc_plane + uv_ubwc_plane + y_meta_plane +
> -			uv_meta_plane +
> -			MSM_MEDIA_MAX(extra_size + 8192, 48 * y_stride);
> -		size = MSM_MEDIA_ALIGN(size, 4096);
> -		break;
> -	case COLOR_FMT_P010_UBWC:
> -		y_ubwc_plane = MSM_MEDIA_ALIGN(y_stride * y_sclines,
> 4096);
> -		uv_ubwc_plane = MSM_MEDIA_ALIGN(uv_stride * uv_sclines,
> 4096);
> -		y_meta_stride = VENUS_Y_META_STRIDE(color_fmt, width);
> -		y_meta_scanlines = VENUS_Y_META_SCANLINES(color_fmt,
> height);
> -		y_meta_plane = MSM_MEDIA_ALIGN(
> -				y_meta_stride * y_meta_scanlines, 4096);
> -		uv_meta_stride = VENUS_UV_META_STRIDE(color_fmt, width);
> -		uv_meta_scanlines = VENUS_UV_META_SCANLINES(color_fmt,
> height);
> -		uv_meta_plane = MSM_MEDIA_ALIGN(uv_meta_stride *
> -					uv_meta_scanlines, 4096);
> -
> -		size = y_ubwc_plane + uv_ubwc_plane + y_meta_plane +
> -			uv_meta_plane;
> -		size = MSM_MEDIA_ALIGN(size, 4096);
> -		break;
> -	case COLOR_FMT_RGBA8888:
> -		rgb_plane = MSM_MEDIA_ALIGN(rgb_stride  * rgb_scanlines,
> 4096);
> -		size = rgb_plane;
> -		size =  MSM_MEDIA_ALIGN(size, 4096);
> -		break;
> -	case COLOR_FMT_RGBA8888_UBWC:
> -	case COLOR_FMT_RGBA1010102_UBWC:
> -	case COLOR_FMT_RGB565_UBWC:
> -		rgb_ubwc_plane = MSM_MEDIA_ALIGN(rgb_stride *
> rgb_scanlines,
> -							4096);
> -		rgb_meta_stride = VENUS_RGB_META_STRIDE(color_fmt, width);
> -		rgb_meta_scanlines = VENUS_RGB_META_SCANLINES(color_fmt,
> -					height);
> -		rgb_meta_plane = MSM_MEDIA_ALIGN(rgb_meta_stride *
> -					rgb_meta_scanlines, 4096);
> -		size = rgb_ubwc_plane + rgb_meta_plane;
> -		size = MSM_MEDIA_ALIGN(size, 4096);
> -		break;
> -	default:
> -		break;
> -	}
> -invalid_input:
> -	return size;
> -}
> -
> -static inline unsigned int VENUS_VIEW2_OFFSET(
> -	int color_fmt, int width, int height)
> -{
> -	unsigned int offset = 0;
> -	unsigned int y_plane, uv_plane, y_stride,
> -		uv_stride, y_sclines, uv_sclines;
> -	if (!width || !height)
> -		goto invalid_input;
> -
> -	y_stride = VENUS_Y_STRIDE(color_fmt, width);
> -	uv_stride = VENUS_UV_STRIDE(color_fmt, width);
> -	y_sclines = VENUS_Y_SCANLINES(color_fmt, height);
> -	uv_sclines = VENUS_UV_SCANLINES(color_fmt, height);
> -	switch (color_fmt) {
> -	case COLOR_FMT_NV12_MVTB:
> -		y_plane = y_stride * y_sclines;
> -		uv_plane = uv_stride * uv_sclines;
> -		offset = y_plane + uv_plane;
> -		break;
> -	default:
> -		break;
> -	}
> -invalid_input:
> -	return offset;
> -}
> -
>  #endif

-- 
Jeykumar S
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

  parent reply	other threads:[~2018-10-08 22:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 14:58 [PATCH 0/6] drm/msm: dpu: Various cleanup patches Sean Paul
     [not found] ` <20180920145818.32468-1-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-09-20 14:58   ` [PATCH 1/6] drm/msm: Remove dpu_encoder_phys_ops->hw_reset() Sean Paul
     [not found]     ` <20180920145818.32468-2-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-10-08 22:27       ` Jeykumar Sankaran
2018-09-20 14:58   ` [PATCH 2/6] drm/msm: dpu: Remove unused functions from msm_media_info.h Sean Paul
     [not found]     ` <20180920145818.32468-3-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-10-08 22:27       ` Jeykumar Sankaran [this message]
2018-09-20 14:58   ` [PATCH 3/6] drm/msm: dpu: Remove _dpu_encoder_power_enable() Sean Paul
     [not found]     ` <20180920145818.32468-4-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-10-08 22:27       ` Jeykumar Sankaran
2018-09-20 14:58   ` [PATCH 4/6] drm/msm: dpu: Remove 'inline' from several functions Sean Paul
     [not found]     ` <20180920145818.32468-5-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-10-08 22:29       ` Jeykumar Sankaran
2018-09-20 14:58   ` [PATCH 5/6] drm/msm: dpu: Remove empty/useless labels Sean Paul
     [not found]     ` <20180920145818.32468-6-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-10-08 22:24       ` Jeykumar Sankaran
     [not found]         ` <f27fd1ba508b4b3efdd17b31971d37c7-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-10-08 22:30           ` Jeykumar Sankaran
2018-09-20 14:58   ` [PATCH 6/6] drm/msm: dpu: Clean up _dpu_core_video_mode_intf_connected() Sean Paul
     [not found]     ` <20180920145818.32468-7-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2018-10-08 22:28       ` Jeykumar Sankaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10534a4df9830bd00d2e4f5ab12dc657@codeaurora.org \
    --to=jsanka-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
    --cc=abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org \
    --cc=seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).