From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH 00/10] Venus stateful Codec API Date: Thu, 24 Jan 2019 12:12:56 +0200 Message-ID: <10deb3d1-2b10-43fe-bc77-4465f561c90a@linaro.org> References: <20190117162008.25217-1-stanimir.varbanov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Courbot Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Hans Verkuil , LKML , linux-arm-msm@vger.kernel.org, Vikash Garodia , Tomasz Figa , Malathi Gottam List-Id: linux-arm-msm@vger.kernel.org Hi Alex, Thank you for review and valuable comments! On 1/24/19 10:43 AM, Alexandre Courbot wrote: > Hi Stanimir, > > On Fri, Jan 18, 2019 at 1:20 AM Stanimir Varbanov > wrote: >> >> Hello, >> >> This aims to make Venus decoder compliant with stateful Codec API [1]. >> The patches 1-9 are preparation for the cherry on the cake patch 10 >> which implements the decoder state machine similar to the one in the >> stateful codec API documentation. > > Thanks *a lot* for this series! I am still stress-testing it against > the Chromium decoder tests, but so far it has been rock-solid. I have > a few inline comments on some patches ; I will also want to review the > state machine more thoroughly after refreshing my mind on Tomasz doc, > but this looks pretty promising already. I'm expecting problems with ResetAfterFirstConfigInfo. I don't know why but this test case is very dirty. I'd appreciate any help to decipher what is the sequence of v4l2 calls made by this unittest case. -- regards, Stan