From: Dikshita Agarwal <quic_dikshita@quicinc.com>
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: "Hans Verkuil" <hverkuil@xs4all.nl>,
"Sebastian Fricke" <sebastian.fricke@collabora.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nicolas Dufresne" <nicolas@ndufresne.ca>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Jianhua Lu" <lujianhua000@gmail.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 03/28] media: iris: implement iris v4l2 file ops
Date: Wed, 13 Nov 2024 10:45:01 +0530 [thread overview]
Message-ID: <11191c49-3a05-e97c-0d17-592074f5acff@quicinc.com> (raw)
In-Reply-To: <841a9469-4fa1-443f-88a6-bfbe11b74487@nexus-software.ie>
On 11/10/2024 8:40 AM, Bryan O'Donoghue wrote:
> On 05/11/2024 06:55, Dikshita Agarwal wrote:
>> Implement open, close and poll ops.
>>
>> Open:
>> Configure the vb2 queue and v4l2 file handler. Allocate a video instance
>> and add the instance to core instance list.
>>
>> Close:
>> Free the instance and remove it from core instance list.
>
> Its a bit odd that you describe the purpose of open and close but not poll,
> despite listing poll along with open and close at the very top.
>
> Consider adding that text if you do a next version.
>
We didn't describe the poll since we are making use of m2m API for that.
but sure can describe that as well.
Thanks,
Dikshita
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>
> ---
> bod
next prev parent reply other threads:[~2024-11-13 5:15 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 6:55 [PATCH v5 00/28] Qualcomm iris video decoder driver Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 01/28] dt-bindings: media: Add video support for QCOM SM8550 SoC Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 02/28] media: iris: add platform driver for iris video device Dikshita Agarwal
2024-11-09 17:32 ` Bryan O'Donoghue
2024-11-13 5:07 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 03/28] media: iris: implement iris v4l2 file ops Dikshita Agarwal
2024-11-10 3:10 ` Bryan O'Donoghue
2024-11-13 5:15 ` Dikshita Agarwal [this message]
2024-11-10 3:11 ` Bryan O'Donoghue
2024-11-05 6:55 ` [PATCH v5 04/28] media: iris: introduce iris core state management with shared queues Dikshita Agarwal
2024-11-10 21:37 ` Bryan O'Donoghue
2024-11-14 7:01 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 05/28] media: iris: implement video firmware load/unload Dikshita Agarwal
2024-11-11 9:59 ` Bryan O'Donoghue
2024-11-13 5:20 ` Dikshita Agarwal
2024-11-13 15:56 ` Bryan O'Donoghue
2024-11-14 5:47 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 06/28] media: iris: implement boot sequence of the firmware Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 07/28] imedia: iris: introduce host firmware interface with necessary hooks Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 08/28] media: iris: implement power management Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 09/28] media: iris: implement reqbuf ioctl with vb2_queue_setup Dikshita Agarwal
2024-11-12 9:50 ` Hans Verkuil
2024-11-13 6:19 ` Dikshita Agarwal
2024-11-13 7:48 ` Hans Verkuil
2024-11-13 9:00 ` Dikshita Agarwal
2024-11-13 9:22 ` Hans Verkuil
2024-11-13 10:32 ` Dikshita Agarwal
2024-11-13 11:15 ` Hans Verkuil
2024-11-13 11:20 ` Dikshita Agarwal
2024-11-13 12:14 ` Hans Verkuil
2024-11-13 12:44 ` Dikshita Agarwal
2024-11-13 12:50 ` Hans Verkuil
2024-11-13 13:05 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 10/28] media: iris: implement s_fmt, g_fmt and try_fmt ioctls Dikshita Agarwal
2024-11-12 10:18 ` Hans Verkuil
2024-11-13 5:25 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 11/28] media: iris: implement g_selection ioctl Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 12/28] media: iris: implement enum_fmt and enum_frameintervals ioctls Dikshita Agarwal
2024-11-12 10:23 ` Hans Verkuil
2024-11-13 5:27 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 13/28] media: iris: implement subscribe_event and unsubscribe_event ioctls Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 14/28] media: iris: implement iris v4l2_ctrl_ops Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 15/28] media: iris: implement query_cap ioctl Dikshita Agarwal
2024-11-12 10:24 ` Hans Verkuil
2024-11-13 5:27 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 16/28] media: iris: implement vb2 streaming ops Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 17/28] media: iris: implement set properties to firmware during streamon Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 18/28] media: iris: subscribe parameters and properties to firmware for hfi_gen2 Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 19/28] media: iris: allocate, initialize and queue internal buffers Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 20/28] media: iris: implement vb2 ops for buf_queue and firmware response Dikshita Agarwal
2024-11-12 10:49 ` Hans Verkuil
2024-11-13 5:30 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 21/28] media: iris: add support for dynamic resolution change Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 22/28] media: iris: handle streamoff/on from client in " Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 23/28] media: iris: add support for drain sequence Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 24/28] media: iris: add check whether the video session is supported or not Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 25/28] media: iris: implement power scaling for vpu2 and vpu3 Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 26/28] media: iris: add check to allow sub states transitions Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 27/28] media: iris: enable video driver probe of SM8250 SoC Dikshita Agarwal
2024-11-05 14:22 ` Jianhua Lu
2024-11-05 14:34 ` Jianhua Lu
2024-11-13 6:40 ` Dikshita Agarwal
2024-11-05 6:55 ` [PATCH v5 28/28] media: MAINTAINERS: add Qualcomm iris video accelerator driver Dikshita Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11191c49-3a05-e97c-0d17-592074f5acff@quicinc.com \
--to=quic_dikshita@quicinc.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=pure.logic@nexus-software.ie \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_vgarodia@quicinc.com \
--cc=robh@kernel.org \
--cc=sebastian.fricke@collabora.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox