From: Daniel Walker <dwalker@codeaurora.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/7] arm: msm: smd: checkpatch clean up of smd/proc_comm
Date: Sat, 27 Mar 2010 07:30:29 -0700 [thread overview]
Message-ID: <1269700229.18193.19.camel@desktop> (raw)
In-Reply-To: <20100327061430.GG18689@elf.ucw.cz>
On Sat, 2010-03-27 at 07:14 +0100, Pavel Machek wrote:
> On Fri 2010-03-26 16:55:19, Daniel Walker wrote:
> > This cleans up codeing style. There are no run time changes.
> >
> > Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
>
> ACK.
>
> > @@ -904,9 +902,9 @@ static irqreturn_t smsm_irq_handler(int irq, void *data)
> >
> > if (msm_smd_debug_mask & MSM_SMSM_DEBUG)
> > pr_info("<SM %08x %08x>\n", apps, modm);
> > - if (modm & SMSM_RESET) {
> > + if (modm & SMSM_RESET)
> > handle_modem_crash();
> > - }
> > +
> > do_smd_probe();
> >
> > spin_unlock_irqrestore(&smem_lock, flags);
>
> Even through I do not think this is an improvement. Especially
> considering the if() immediately before that.
I could add a space in there, might make it more clear.
Daniel
prev parent reply other threads:[~2010-03-27 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 23:55 [PATCH 1/7] arm: msm: smd: checkpatch clean up of smd/proc_comm Daniel Walker
2010-03-27 6:14 ` Pavel Machek
2010-03-27 14:30 ` Daniel Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269700229.18193.19.camel@desktop \
--to=dwalker@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).