From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97D29C6FA82 for ; Thu, 22 Sep 2022 11:47:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231571AbiIVLr2 (ORCPT ); Thu, 22 Sep 2022 07:47:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231593AbiIVLr1 (ORCPT ); Thu, 22 Sep 2022 07:47:27 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E1CC1CB02 for ; Thu, 22 Sep 2022 04:47:26 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id j24so10142120lja.4 for ; Thu, 22 Sep 2022 04:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=lfIzVvJwH59qn/BWWHJMkL6Oq/PiOvW3+SknpjmQRfE=; b=E2Ad53XZwhUsT1gispneQUgEJHMdy0oc3PAffMB/gOabR58mMlzPNR/9gDfrbkIU2a Ypj9T7uKEvLvZ0Ry4F+nA2ALzMFZKha87yssWTeO+SRIkagqChqI3siudGei2VsR4BuC ziFnvQHRnaCer0x9CU0kmoiD30GTDFDfaJ2MIV3IqpQP2byxVAd4c5Qry2eA0PxdW4od 96le7BrnxkFQy38M4QJ+0diTdMs6ZppNqcL/g6fPGYVtFZIECTMhhUhvrrANQCKtQIlK En9ApHWuGMD536ri1ohXBFOGYSljnRx305RXQR8ut3u3wzgDZFyIxSKjhRZreQOMUXnI 7IzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=lfIzVvJwH59qn/BWWHJMkL6Oq/PiOvW3+SknpjmQRfE=; b=Q8DxsJlFg9j+imDiD36S+1PpfbND9IETLaSVZI9kIGea+xP0LFCfq0jXRSKxJoUB63 RXULmoAn4Vp5JPo5TmTmoY647JfeB8mGwrMpbyJQUEYvcSRkUP1hKgUShs+4+7a7ulCY Z45tIUq56Khell6uLkrg1dC802kS5+4uQF9mvd9NQBd1bHA7W0Soie5Yl1ooavsOxSMa t2c1OaBF4Eqe5LiOBH1Q0piN85lLEpV6KVwtircOspbi0I4IY7kRtqoUcOBWTlGa+5fy mnCgbN12JYxGn5w4UWa1T/30+wdj1jLf7KbNktnL2LD6jB6NG3HLJdrmhDYWyUUqrN5I x8BA== X-Gm-Message-State: ACrzQf2IQDi/4Mr/lbLyvrfM3OHleK5nT9BDj9yqE/DlmrBdAKjCObr3 5x6oI7Q5mnxH3qvw6luWVwR2gA== X-Google-Smtp-Source: AMsMyM4jIlvZc1M/djOM/cHTTMsiKvPP6k7AvneFFRmoWo4a7UvSO3X4IHrXVUP63Spk/Cpb1uo8QA== X-Received: by 2002:a05:651c:227:b0:26a:b322:b243 with SMTP id z7-20020a05651c022700b0026ab322b243mr893160ljn.13.1663847244282; Thu, 22 Sep 2022 04:47:24 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id b25-20020a2ebc19000000b0026c4e922fb2sm879687ljf.48.2022.09.22.04.47.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 04:47:23 -0700 (PDT) Message-ID: <126cd061-173d-62c1-a61d-06c191b13cb9@linaro.org> Date: Thu, 22 Sep 2022 14:47:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Content-Language: en-GB To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20220915133742.115218-1-dmitry.baryshkov@linaro.org> <20220915133742.115218-6-dmitry.baryshkov@linaro.org> <84c599c7-421a-78ed-b33e-ce1a4bd4356e@linaro.org> <01baf27b-8257-aa08-d61f-a427c5056715@linaro.org> From: Dmitry Baryshkov In-Reply-To: <01baf27b-8257-aa08-d61f-a427c5056715@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 22/09/2022 14:43, Krzysztof Kozlowski wrote: > On 22/09/2022 09:53, Dmitry Baryshkov wrote: >> On Thu, 22 Sept 2022 at 10:05, Krzysztof Kozlowski >> wrote: >>> >>> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>>> Move properties common to all MDSS DT nodes to the mdss-common.yaml. >>>> >>>> This extends qcom,msm8998-mdss schema to allow interconnect nodes, which >>>> will be added later, once msm8998 gains interconnect support. >>>> >>>> Signed-off-by: Dmitry Baryshkov >>>> --- >>>> .../bindings/display/msm/dpu-msm8998.yaml | 41 +-------- >>>> .../bindings/display/msm/dpu-qcm2290.yaml | 51 ++---------- >>>> .../bindings/display/msm/dpu-sc7180.yaml | 50 ++--------- >>>> .../bindings/display/msm/dpu-sc7280.yaml | 50 ++--------- >>>> .../bindings/display/msm/dpu-sdm845.yaml | 54 ++---------- >>>> .../bindings/display/msm/mdss-common.yaml | 83 +++++++++++++++++++ >>>> 6 files changed, 111 insertions(+), 218 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/display/msm/mdss-common.yaml >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml >>>> index 200eeace1c71..67791dbc3b5d 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml >>>> @@ -14,20 +14,13 @@ description: | >>>> sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree >>>> bindings of MDSS and DPU are mentioned for MSM8998 target. >>>> >>> >>> missing allOf >> >> Rob asked to remove this while reviewing v6 ([1]). And indeed the >> allOf's around a single $ref do not seem to be necessary > > He commented on one of properties, not top-level, maybe it is different > case for dtschema. In the past it was required, so are you sure > something changed in dtschema? I do not know if something has changed or not. But judging from the fact that unevaluatedProperties:false do not generate any warnings, the referenced schema is processed and applied. > > Best regards, > Krzysztof > -- With best wishes Dmitry