From: Daniel Walker <dwalker@codeaurora.org>
To: Gregory Bean <gbean@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] msm: Add gpio register address mapping information.
Date: Mon, 21 Jun 2010 10:30:34 -0700 [thread overview]
Message-ID: <1277141434.17092.17.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <1276964944-11063-2-git-send-email-gbean@codeaurora.org>
On Sat, 2010-06-19 at 09:29 -0700, Gregory Bean wrote:
> +#if defined(CONFIG_ARCH_MSM7X30)
> +#define GPIO1_REG(off) (MSM_GPIO1_BASE + (off))
> +#define GPIO2_REG(off) (MSM_GPIO2_BASE + 0x400 + (off))
> +#else
> +#define GPIO1_REG(off) (MSM_GPIO1_BASE + 0x800 + (off))
> +#define GPIO2_REG(off) (MSM_GPIO2_BASE + 0xC00 + (off))
> +#endif
> +
> +#if defined(CONFIG_ARCH_QSD8X50)
> +#include "gpio_hw-8x50.h"
> +#elif defined(CONFIG_ARCH_MSM7X30)
> +#include "gpio_hw-7x30.h"
> +#else
> +#include "gpio_hw-7xxx.h"
> +#endif
I don't think this compiles for 7xxx , since your adding the ifdef block
but not the header.. It would be nice to also include that.
don't respin till the license thing is settled ..
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-06-21 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 16:29 [PATCH 0/3 v2] msm: Add gpiolib devices to MSM7x30 and QSD8x50 Gregory Bean
2010-06-19 16:29 ` [PATCH 1/3 v2] msm: Add gpio register address mapping information Gregory Bean
2010-06-21 17:30 ` Daniel Walker [this message]
2010-06-19 16:29 ` [PATCH 2/3 v2] msm: 7x30: Add gpio device configuration Gregory Bean
2010-06-19 16:29 ` [PATCH 3/3 v2] msm: 8x50: add " Gregory Bean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277141434.17092.17.camel@c-dwalke-linux.qualcomm.com \
--to=dwalker@codeaurora.org \
--cc=gbean@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).