From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:58565 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176Ab0GFRGL (ORCPT ); Tue, 6 Jul 2010 13:06:11 -0400 Subject: Re: [PATCH v2] msm: gpio: Add set_wake support to msm7200a-gpio's irq_chip. From: Daniel Walker In-Reply-To: <4C336020.3090206@codeaurora.org> References: <1278185128-29161-1-git-send-email-gbean@codeaurora.org> <1278434857.27490.2.camel@c-dwalke-linux.qualcomm.com> <4C336020.3090206@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 06 Jul 2010 10:06:08 -0700 Message-ID: <1278435968.27490.5.camel@c-dwalke-linux.qualcomm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Greg Bean Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org On Tue, 2010-07-06 at 09:56 -0700, Greg Bean wrote: > >> Add power-management and irq_chip hooks to allow configuration > >> of msm-gpio irq lines as wakeup sources. > > > > What level of correlation is there between power management and the wake > > up hooks? Just irq_masks ? > > When the system sleeps, gpio-based irqs which are not configured as wake-up > sources are disabled in the controller hardware to prevent latching and > unwanted wakeups. So you could make these two patches? It seems like they're relatively distinct other than the one fairly ordered dependency you mention above. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.