From: Patrick Pannuto <ppannuto@codeaurora.org>
To: linux-kernel@vger.kernel.org
Cc: ppannuto@codeaurora.org, apw@canonical.com, corbet@lwn.net,
arjan@linux.intel.com, linux-arm-msm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Joe Perches <joe@perches.com>
Subject: [PATCH 3/4] Checkpatch: prefer usleep_range over udelay
Date: Mon, 2 Aug 2010 15:01:06 -0700 [thread overview]
Message-ID: <1280786467-26999-4-git-send-email-ppannuto@codeaurora.org> (raw)
In-Reply-To: <1280786467-26999-1-git-send-email-ppannuto@codeaurora.org>
When possible, sleeping is (usually) better than delaying;
however, don't bother callers of udelay < 10us, as those
cases are generally not worth the switch to usleep
Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
---
scripts/checkpatch.pl | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd88f11..1698c63 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2570,6 +2570,14 @@ sub process {
}
}
+# prefer usleep_range over udelay
+ if (($line =~ /\budelay\s*\(\s*(\w+)\s*\)/ {
+ # ignore udelay's < 10, however
+ if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) {
+ CHK("usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
+ }
+ }
+
# warn about #ifdefs in C files
# if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
# print "#ifdef in C files should be avoided\n";
--
1.7.2
next prev parent reply other threads:[~2010-08-02 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 22:01 [PATCH v3 0/4] Add usleep_range Patrick Pannuto
2010-08-02 22:01 ` [PATCH 1/4] timer: Added usleep_range timer Patrick Pannuto
2010-08-03 22:51 ` Andrew Morton
2010-08-02 22:01 ` [PATCH 2/4] Documentation: Add timers/timers-howto.txt Patrick Pannuto
2010-08-02 22:01 ` Patrick Pannuto [this message]
2010-08-02 22:01 ` [PATCH 4/4] Checkpatch: warn about unexpectedly long msleep's Patrick Pannuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280786467-26999-4-git-send-email-ppannuto@codeaurora.org \
--to=ppannuto@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=arjan@linux.intel.com \
--cc=corbet@lwn.net \
--cc=joe@perches.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).