linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] checkpatch: Fix extraneous EXPORT_SYMBOL* warnings
@ 2010-08-05  1:32 Patrick Pannuto
  0 siblings, 0 replies; only message in thread
From: Patrick Pannuto @ 2010-08-05  1:32 UTC (permalink / raw)
  To: linux-kernel
  Cc: ppannuto, linux-arm-msm, Andy Whitcroft, Andrew Morton,
	Joe Perches

These are caused by checkpatch incorrectly parsing its
internal representation of a statement block for struct's
(or anything else that is a statement block encapsulated
in {}'s that also ends with a ';'). Fix this by properly
parsing a statement block.

An example:
	diff --git a/dummy.c b/dummy.c
	new file mode 100644
	index 0000000..3a932a5
	--- /dev/null
	+++ b/dummy.c
	@@ -0,0 +1,12 @@
	+struct dummy_type dummy = {
	+	.foo	= "baz",
	+};
	+EXPORT_SYMBOL_GPL(dummy);
	+
	+static int dummy_func(void)
	+{
	+	return -EDUMMYCODE;
	+}
	+EXPORT_SYMBOL_GPL(dummy_func);

	WARNING: EXPORT_SYMBOL(foo); should immediately \
		follow its function/variable
	#19: FILE: dummy.c:4:
	+EXPORT_SYMBOL_GPL(dummy);

The above warning is issued when it should not be.

Signed-off-by: Patrick Pannuto <ppannuto@codeaurora.org>
---
 scripts/checkpatch.pl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index bd88f11..6affee2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -552,6 +552,9 @@ sub ctx_statement_block {
 			$type = ($level != 0)? '{' : '';
 
 			if ($level == 0) {
+				if (substr($blk, $off + 1, 1) eq ';') {
+					$off++;
+				}
 				last;
 			}
 		}
-- 
1.7.2


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-08-05  1:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-05  1:32 [PATCH] checkpatch: Fix extraneous EXPORT_SYMBOL* warnings Patrick Pannuto

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).