From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from senator.holtmann.net ([87.106.208.187]:38947 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757936Ab0HJVik (ORCPT ); Tue, 10 Aug 2010 17:38:40 -0400 Subject: Re: [RFC 4/7] Bluetooth: Linearize received L2CAP skbuffs. From: Marcel Holtmann In-Reply-To: <1281467704-5378-5-git-send-email-mathewm@codeaurora.org> References: <1281467704-5378-1-git-send-email-mathewm@codeaurora.org> <1281467704-5378-5-git-send-email-mathewm@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 10 Aug 2010 17:38:33 -0400 Message-ID: <1281476313.12579.229.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Mat Martineau Cc: linux-bluetooth@vger.kernel.org, gustavo@padovan.org, rshaffer@codeaurora.org, linux-arm-msm@vger.kernel.org Hi Mat, > Fragmented skbs are only encountered by in-kernel protocols and > profiles when receiving ERTM or streaming mode L2CAP data. BNEP, > CMTP, HIDP, and RFCOMM generally use basic mode, so will not > generally need the extra memcpy's necessary to put the L2CAP > payload in to a linear buffer. However, it is possible to > use enhanced L2CAP in these modes so the possibility needs > to be handled. > > Signed-off-by: Mat Martineau > --- > net/bluetooth/bnep/core.c | 5 ++++- > net/bluetooth/cmtp/core.c | 5 ++++- > net/bluetooth/hidp/core.c | 10 ++++++++-- > net/bluetooth/rfcomm/core.c | 5 ++++- > 4 files changed, 20 insertions(+), 5 deletions(-) in general I am fine with this. Regards Marcel