From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:37005 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751885Ab0I3UIc (ORCPT ); Thu, 30 Sep 2010 16:08:32 -0400 Subject: Re: [PATCH 2/4] arm: dis-allow hotplug on MSM From: Daniel Walker In-Reply-To: <20100930200246.GB2174@elf.ucw.cz> References: <1284062289-10914-1-git-send-email-dwalker@codeaurora.org> <1284062289-10914-3-git-send-email-dwalker@codeaurora.org> <20100930071919.GA6434@ucw.cz> <1285865137.14953.4.camel@c-dwalke-linux.qualcomm.com> <1285870183.14953.7.camel@c-dwalke-linux.qualcomm.com> <20100930195237.GA2174@elf.ucw.cz> <1285876546.14953.10.camel@c-dwalke-linux.qualcomm.com> <20100930200246.GB2174@elf.ucw.cz> Content-Type: text/plain; charset="UTF-8" Date: Thu, 30 Sep 2010 13:08:07 -0700 Message-ID: <1285877287.14953.13.camel@c-dwalke-linux.qualcomm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Pavel Machek Cc: Catalin Marinas , Russell King - ARM Linux , Jeff Ohlstein , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org On Thu, 2010-09-30 at 22:02 +0200, Pavel Machek wrote: > Hi! > > > > > > > This is goodbye to s2ram support, AFAICT. > > > > > > > > > > This depends on SMP tho. It's like saying, > > > > > > > > > > depends on > > > > > > > > That's weird, there was more to this email.. > > > > > > > > It's like saying, > > > > > > > > depends on SMP && HOTPLUG && EXPERIMENTAL && !ARCH_MSM > > > > > > > > But ARCH_MSM has no SMP, so the whole thing should short circuit right > > > > at the start. It's only when you bring in SMP that it get interesting. > > > > > > If arch_msm has no SMP, then why is change needed? > > > > I'm getting it ready for SMP .. It's not there yet but will be. > > Ok. It makes sense, then. > > > > (I was trying to warn you that you'll need HOTPLUG support to get SMP > > > suspend support.) > > > > Yeah, I'm aware of it.. We haven't implemented hotplug yet, so we don't > > have suspend support yet for SMP. > > Still, it might be better to just provide stubs that return -ENOTSUPP > or something, and leave it enabled in config. Same results, you'll > need to provide full functions in future, anyway, and no churn in > shared config files. That's actually what I had original, Russell offered this as an alternative. Now that I think about the stubs tho, I'm not sure it's that bad an idea. All the stubs would do is not put the core into a lower powermode, but would allow suspend. It wouldn't be very efficient , but suspend would work. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.