From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:27325 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081Ab0I3XF0 (ORCPT ); Thu, 30 Sep 2010 19:05:26 -0400 Subject: Re: [PATCH] [Streak] Add workaround for TTY kernel OOPS at the cost of performance. From: Daniel Walker In-Reply-To: <1285886565.11486.26.camel@wing> References: <1285886565.11486.26.camel@wing> Content-Type: text/plain; charset="UTF-8" Date: Thu, 30 Sep 2010 16:04:14 -0700 Message-ID: <1285887854.14953.46.camel@c-dwalke-linux.qualcomm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Tomasz Sterna Cc: linux-arm-msm@vger.kernel.org On Fri, 2010-10-01 at 00:42 +0200, Tomasz Sterna wrote: > The current framebuffer driver oopses when used as a console (kernel > parameter: console=tty ). > Here is a patch that makes it work - at the cost of performance. > > Signed-off-by: Bradley Smith > (cherry picked from commit 28d06a6366c851c6e0c5b954353bf82cb641d4e7) Your submitting this for Bradley? If so you need to have a line like this at the top, From: Bradley Smith That denotes that your not the author of the commit.. Also this is against v2.6.36-rcX right ? > --- > drivers/video/msm/Kconfig | 4 ++++ > drivers/video/msm/mdp.c | 20 ++++++++++++++++++++ > drivers/video/msm/mdp.h | 3 +++ > drivers/video/msm/mdp_dma.c | 15 +++++++++++++++ > drivers/video/msm/mdp_dma_s.c | 28 ++++++++++++++++++++++++++++ > drivers/video/msm/msm_fb.c | 2 ++ > drivers/video/msm/msm_fb.h | 14 ++++++++++++++ > 7 files changed, 86 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/msm/Kconfig b/drivers/video/msm/Kconfig > index e887a2d..cff8435 100644 > --- a/drivers/video/msm/Kconfig > +++ b/drivers/video/msm/Kconfig > @@ -14,3 +14,7 @@ config FB_MSM_LCDC > depends on FB_MSM && MSM_MDP31 > default y > > +config MSM_FB_TTY_WORKAROUND > + bool "Workaround TTY kernel OOPS at the cost of performance" > + depends on FB_MSM > + default n We can't have this selectable , especially if the kernel will OOPS if it's off .. I need a better description of the problem. What was the oops? This looks DMA related, is that accurate and could you expand on why DMA was causing a problem? Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.