From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:24418 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757001Ab0J1Qat (ORCPT ); Thu, 28 Oct 2010 12:30:49 -0400 Subject: Re: [PATCH] msm: fix debug-macro.S build failure From: Daniel Walker In-Reply-To: References: <1288216688-718-1-git-send-email-dwalker@codeaurora.org> <20101027221428.GB28391@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="UTF-8" Date: Thu, 28 Oct 2010 09:30:13 -0700 Message-ID: <1288283413.2683.2.camel@c-dwalke-linux.qualcomm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Nicolas Pitre Cc: Russell King - ARM Linux , linux-arm-msm@vger.kernel.org, linux-arm-kernel , Jeremy Kerr , Lorenzo Pieralisi , Jason Wang , Tony Lindgren On Wed, 2010-10-27 at 22:30 -0400, Nicolas Pitre wrote: > On Wed, 27 Oct 2010, Russell King - ARM Linux wrote: > > > > +#else > > > + .macro addruart, rx, tmp > > > > addruart is now expected to return two values, and 'tmp' ends up being > > misleading. This is a recipe for mistakes unless this is corrected. > > It should be 'rp, rv' instead of 'rx, tmp'. > > Also, it is probably not a good idea to return nothing. Otherwise the > code using those macros will then work on random values that just > happened to be in the corresponding register at the call location. Should we have something in generic arm code that allows this to just be turned off? Ideally we don't want any of this stuff even running. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.