From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:40422 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933945Ab0J1S2L (ORCPT ); Thu, 28 Oct 2010 14:28:11 -0400 Subject: Re: [PATCH] msm: fix debug-macro.S build failure From: Daniel Walker In-Reply-To: References: <1288216688-718-1-git-send-email-dwalker@codeaurora.org> <20101027221428.GB28391@n2100.arm.linux.org.uk> <1288283413.2683.2.camel@c-dwalke-linux.qualcomm.com> <20101028163518.GG3122@n2100.arm.linux.org.uk> <1288284066.2683.9.camel@c-dwalke-linux.qualcomm.com> <20101028174653.GH3122@n2100.arm.linux.org.uk> <1288288824.2683.24.camel@c-dwalke-linux.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 28 Oct 2010 11:27:38 -0700 Message-ID: <1288290458.2683.25.camel@c-dwalke-linux.qualcomm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Nicolas Pitre Cc: Russell King - ARM Linux , linux-arm-msm@vger.kernel.org, linux-arm-kernel , Jeremy Kerr , Lorenzo Pieralisi , Jason Wang , Tony Lindgren On Thu, 2010-10-28 at 14:24 -0400, Nicolas Pitre wrote: > On Thu, 28 Oct 2010, Daniel Walker wrote: > > > This is what the function currently has, > > > > .macro addruart, rp, rv > > ldr \rp, =MSM_DEBUG_UART_PHYS > > ldr \rv, =MSM_DEBUG_UART_BASE > > .endm > > > > So if we have a MSM_DEBUG_UART_PHYS and MSM_DEBUG_UART_BASE we're > > returning it. We don't actually have those values for all the boards > > tho. My understanding was that there are some generic arm changes > > needed, but I need to confirm that. > > Just return 0 in both registers when you have nothing better to return. What about the other functions ? Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.