[RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[Tatyana Brokhman]

This patch series adds Super Speed support to the Gadget framework.
This is a third version of an already sent series. It was split into additional 
two patches.

Tatyana Brokhman (4):
  usb: Add usb_endpoint_descriptor to be part of the struct usb_ep
  usb: Configure endpoint according to gadget speed.
  usb: Modify existing gadget drivers to use config_ep_by_speed()
    instead of ep_choose.
  usb:gadget: Add SuperSpeed support to the Gadget Framework

 drivers/usb/gadget/Kconfig          |   12 +
 drivers/usb/gadget/composite.c      |  440 +++++++++++++++++++++++++++++++++--
 drivers/usb/gadget/config.c         |   25 --
 drivers/usb/gadget/dbgp.c           |    8 +-
 drivers/usb/gadget/epautoconf.c     |    1 +
 drivers/usb/gadget/f_acm.c          |   50 ++---
 drivers/usb/gadget/f_audio.c        |    5 +-
 drivers/usb/gadget/f_ecm.c          |   54 ++---
 drivers/usb/gadget/f_eem.c          |   36 +--
 drivers/usb/gadget/f_fs.c           |    3 +-
 drivers/usb/gadget/f_hid.c          |   22 +--
 drivers/usb/gadget/f_loopback.c     |   17 +-
 drivers/usb/gadget/f_mass_storage.c |    3 +-
 drivers/usb/gadget/f_obex.c         |   32 +--
 drivers/usb/gadget/f_phonet.c       |   17 +-
 drivers/usb/gadget/f_rndis.c        |   52 ++---
 drivers/usb/gadget/f_serial.c       |   32 +--
 drivers/usb/gadget/f_sourcesink.c   |   14 +-
 drivers/usb/gadget/f_subset.c       |   33 +--
 drivers/usb/gadget/f_uvc.c          |    6 +-
 drivers/usb/gadget/file_storage.c   |    3 +-
 drivers/usb/gadget/gmidi.c          |    6 +-
 drivers/usb/gadget/inode.c          |    6 +-
 drivers/usb/gadget/printer.c        |   26 ++-
 drivers/usb/gadget/u_ether.c        |   12 +-
 drivers/usb/gadget/u_ether.h        |    4 -
 drivers/usb/gadget/u_serial.c       |    4 +-
 drivers/usb/gadget/u_serial.h       |    2 -
 include/linux/usb/composite.h       |   55 ++++-
 include/linux/usb/gadget.h          |   64 ++++--
 30 files changed, 741 insertions(+), 361 deletions(-)

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[tlinder]

Hello All

I've sent the bellow patch series for review more then a week ago and got
only one comment on one of the patches. I'm not sure what I'm supposed to
do next. Does this mean that the rest of them are ok? Should I resend
them?

Right after this series I've uploaded another patch series adding
SuperSpeed support to the dummy_hcd framework. The above applies to that
as well.

I'm sorry if this email is not inappropriate; I'm new at this and still
learning the code release process.

Thank you for your support
Best Regards
Tanya Brokhman

> This patch series adds Super Speed support to the Gadget framework.
> This is a third version of an already sent series. It was split into
> additional
> two patches.
>
> Tatyana Brokhman (4):
>   usb: Add usb_endpoint_descriptor to be part of the struct usb_ep
>   usb: Configure endpoint according to gadget speed.
>   usb: Modify existing gadget drivers to use config_ep_by_speed()
>     instead of ep_choose.
>   usb:gadget: Add SuperSpeed support to the Gadget Framework
>
>  drivers/usb/gadget/Kconfig          |   12 +
>  drivers/usb/gadget/composite.c      |  440
> +++++++++++++++++++++++++++++++++--
>  drivers/usb/gadget/config.c         |   25 --
>  drivers/usb/gadget/dbgp.c           |    8 +-
>  drivers/usb/gadget/epautoconf.c     |    1 +
>  drivers/usb/gadget/f_acm.c          |   50 ++---
>  drivers/usb/gadget/f_audio.c        |    5 +-
>  drivers/usb/gadget/f_ecm.c          |   54 ++---
>  drivers/usb/gadget/f_eem.c          |   36 +--
>  drivers/usb/gadget/f_fs.c           |    3 +-
>  drivers/usb/gadget/f_hid.c          |   22 +--
>  drivers/usb/gadget/f_loopback.c     |   17 +-
>  drivers/usb/gadget/f_mass_storage.c |    3 +-
>  drivers/usb/gadget/f_obex.c         |   32 +--
>  drivers/usb/gadget/f_phonet.c       |   17 +-
>  drivers/usb/gadget/f_rndis.c        |   52 ++---
>  drivers/usb/gadget/f_serial.c       |   32 +--
>  drivers/usb/gadget/f_sourcesink.c   |   14 +-
>  drivers/usb/gadget/f_subset.c       |   33 +--
>  drivers/usb/gadget/f_uvc.c          |    6 +-
>  drivers/usb/gadget/file_storage.c   |    3 +-
>  drivers/usb/gadget/gmidi.c          |    6 +-
>  drivers/usb/gadget/inode.c          |    6 +-
>  drivers/usb/gadget/printer.c        |   26 ++-
>  drivers/usb/gadget/u_ether.c        |   12 +-
>  drivers/usb/gadget/u_ether.h        |    4 -
>  drivers/usb/gadget/u_serial.c       |    4 +-
>  drivers/usb/gadget/u_serial.h       |    2 -
>  include/linux/usb/composite.h       |   55 ++++-
>  include/linux/usb/gadget.h          |   64 ++++--
>  30 files changed, 741 insertions(+), 361 deletions(-)
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[David Brownell]

--- On Tue, 11/9/10, tlinder@codeaurora.org <tlinder@codeaurora.org> wrote:

> Hello All
> 
> I've sent the bellow patch series for review more then a
> week ago

And that wasn't the first iteration (v1,v2,v3).

 and got
> only one comment on one of the patches. I'm not sure what
> I'm supposed to
> do next.

You could try responding to the questions that
I asked a while back (probably for V1 or V2).

There were both "why" questions, and another
approach to handling the endpoint descriptors.

Lack of answers to those questions is why your
last post of these framework patches is still
sitting in my mailbox waiting for review (or
more likely deletion).






 Does this mean that the rest of them are ok?
> Should I resend
> them?
 
Answer to both questions is "NO".  First deal
with those ignored questions. They're surely
at least a month old by now.  They should have
gone to the list, but maybe mailer misbehavior
sent them to a smaller audience (just you, etc).

If absolutely necessary, I can probably dig up
those emails again and re-send; better if you
try to find them first, and respond.
I think they're the last emails from me on
these threads.

- Dave

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[Daniel Walker]

On Wed, 2010-11-10 at 07:37 -0800, David Brownell wrote:

> If absolutely necessary, I can probably dig up
> those emails again and re-send; better if you
> try to find them first, and respond.
> I think they're the last emails from me on
> these threads.

These questions?

http://www.spinics.net/lists/linux-usb/msg36962.html
http://www.spinics.net/lists/linux-usb/msg37285.html

It looks like the first round of these patches didn't CC linux-arm-msm,
so I didn't see your questions.

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[David Brownell]

 
> > If absolutely necessary, I can probably dig up
> > those emails again and re-send; better if you
> > try to find them first, and respond.
> > I think they're the last emails from me on
> > these threads.
> 
> These questions?
> 
> http://www.spinics.net/lists/linux-usb/msg36962.html
> http://www.spinics.net/lists/linux-usb/msg37285.html

No; those are old, not the most
recent questions.

> 
> It looks like the first round of these patches didn't CC
> linux-arm-msm,
> so I didn't see your questions.

Is that an open list, or one that trashes email
from non-subscribers?

Regardless, linux-usb is where I'd expect to
see such discussions archived.

- Dave

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[David Brownell]

> On Wed, 2010-11-10 at 07:37 -0800,
> David Brownell wrote:
> 
> > If absolutely necessary, I can probably dig up
> > those emails again and re-send; better if you
> > try to find them first, and respond.
> > I think they're the last emails from me on
> > these threads.
> 

Ffor the record:  I did dig up a copy from
my "sent" file and forwarded it to
both tlinder and dwalker.

I didn't make time to find a ref into one of
the linux-usb archives though.

Original $SUBJECT was " [RFC/PATCH 1/2] Add usb_endpoint_descriptor to be part of the struct usb_ep" dated Wednesday, October 6, 2010, 9:34 PM
and with a long CC list (that included the MSM
list that allegedly didn't receive it).  That info
may help sort out where the email went astray, if
we assume that's why it got no response.


- Dave

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[Felipe Balbi]

Hi,

On Wed, 2010-11-10 at 12:15 -0800, David Brownell wrote:
> Original $SUBJECT was "[RFC/PATCH 1/2] Add usb_endpoint_descriptor to be part of the struct usb_ep" dated Wednesday, October 6, 2010, 9:34 PM
> and with a long CC list (that included the MSM
> list that allegedly didn't receive it).  That info
> may help sort out where the email went astray, if
> we assume that's why it got no response.

you mean this [1]

[1] http://marc.info/?t=128612384500006&r=1&w=2

-- 
balbi

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[Daniel Walker]

On Wed, 2010-11-10 at 11:23 -0800, David Brownell wrote:
> > > If absolutely necessary, I can probably dig up
> > > those emails again and re-send; better if you
> > > try to find them first, and respond.
> > > I think they're the last emails from me on
> > > these threads.
> > 
> > These questions?
> > 
> > http://www.spinics.net/lists/linux-usb/msg36962.html
> > http://www.spinics.net/lists/linux-usb/msg37285.html
> 
> No; those are old, not the most
> recent questions.

Ok.

> > 
> > It looks like the first round of these patches didn't CC
> > linux-arm-msm,
> > so I didn't see your questions.
> 
> Is that an open list, or one that trashes email
> from non-subscribers?

open list. It's on vger.

Daniel

-- 

Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[David Brown]

On Wed, Nov 10, 2010 at 11:23:03AM -0800, David Brownell wrote:

> > It looks like the first round of these patches didn't CC
> > linux-arm-msm,
> > so I didn't see your questions.
> 
> Is that an open list, or one that trashes email
> from non-subscribers?

It's on vger, same place as most of the lists.  The archives don't
seem to be working, I'll look into that.

David

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[David Brownell]

> you mean this [1]
> 
> [1] http://marc.info/?t=128612384500006&r=1&w=2

No; that seemed mostly nontechnical (at the
level of "those changes were too minor to rate
authorship/copyright credit), going by normal
kernel conventions).

Re: [RFC/PATCH v3 0/4] usb: Add SuperSpeed support to the Gadget Framework

[tlinder]

Hello Dave,

Thank you for your quick response!
This is a surprise to me since I did address all the comments/questions I
got, especially the ones from so long ago. The only thing in my TODO list
is the comment on the latest version of this series but I'm waiting for
more inputs.

I've located all your questions and my answers to them in my sent-items
and will resend them all in a sec.
Please let me know if I did miss something and if this is the case accept
my apology. I'll be happy to address any questions/comments you might
have.

Thanks
Tanya Brokhman

>
>
> --- On Tue, 11/9/10, tlinder@codeaurora.org <tlinder@codeaurora.org>
> wrote:
>
>> Hello All
>>
>> I've sent the bellow patch series for review more then a
>> week ago
>
> And that wasn't the first iteration (v1,v2,v3).
>
>  and got
>> only one comment on one of the patches. I'm not sure what
>> I'm supposed to
>> do next.
>
> You could try responding to the questions that
> I asked a while back (probably for V1 or V2).
>
> There were both "why" questions, and another
> approach to handling the endpoint descriptors.
>
> Lack of answers to those questions is why your
> last post of these framework patches is still
> sitting in my mailbox waiting for review (or
> more likely deletion).
>
>
>
>
>
>
>  Does this mean that the rest of them are ok?
>> Should I resend
>> them?
>
> Answer to both questions is "NO".  First deal
> with those ignored questions. They're surely
> at least a month old by now.  They should have
> gone to the list, but maybe mailer misbehavior
> sent them to a smaller audience (just you, etc).
>
> If absolutely necessary, I can probably dig up
> those emails again and re-send; better if you
> try to find them first, and respond.
> I think they're the last emails from me on
> these threads.
>
> - Dave
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>