From: Felipe Balbi <me@felipebalbi.com>
To: Greg KH <greg@kroah.com>
Cc: Maya Erez <merez@codeaurora.org>,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Mike Frysinger <vapier@gentoo.org>,
Cliff Cai <cliff.cai@analog.com>,
Michal Nazarewicz <m.nazarewicz@samsung.com>,
Fabien Chouteau <fabien.chouteau@barco.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC/PATCH] usb: Add streams support to epautoconf.
Date: Sun, 14 Nov 2010 22:15:33 +0200 [thread overview]
Message-ID: <1289765733.15533.4.camel@eowin> (raw)
In-Reply-To: <20101114182915.GA20922@kroah.com>
Hi,
On Sun, 2010-11-14 at 10:29 -0800, Greg KH wrote:
> > + if (USB_ENDPOINT_XFER_BULK == type) {
>
> Ick, no, don't do comparisons like this. The compiler will let you know
> if you acidentally get it wrong with only one '=' character, don't do
> things "backward" like this just to work around stupid compilers.
we actually have helpers for this and usb_endpoint_xfer_bulk(desc)
would do it.
--
balbi
next prev parent reply other threads:[~2010-11-14 20:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 6:23 [RFC/PATCH] usb: Add streams support to epautoconf Maya Erez
2010-11-14 18:29 ` Greg KH
2010-11-14 20:15 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-12-06 20:42 Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289765733.15533.4.camel@eowin \
--to=me@felipebalbi.com \
--cc=cliff.cai@analog.com \
--cc=dbrownell@users.sourceforge.net \
--cc=fabien.chouteau@barco.com \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=merez@codeaurora.org \
--cc=tj@kernel.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).