From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:2336 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768Ab0LGCwV (ORCPT ); Mon, 6 Dec 2010 21:52:21 -0500 Subject: Re: [PATCH] regulator: debugfs: Adding debugfs functions into regulator framework From: Daniel Walker In-Reply-To: <20101206222907.GA2425@opensource.wolfsonmicro.com> References: <1291668763-15734-1-git-send-email-bleong@codeaurora.org> <20101206222907.GA2425@opensource.wolfsonmicro.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 06 Dec 2010 18:52:00 -0800 Message-ID: <1291690320.4150.1.camel@m0nster> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-arm-msm-owner@vger.kernel.org List-ID: To: Mark Brown Cc: Brandon Leong , lrg@slimlogic.co.uk, davidb@codeaurora.org, linux-arm-msm@vger.kernel.org On Mon, 2010-12-06 at 22:29 +0000, Mark Brown wrote: > > +static int reg_debug_enable_set(void *data, u64 val) > > +{ > > + int err_info; > > + if (IS_ERR(data) || data == NULL) { > > + pr_err("Function Input Error %ld\n", PTR_ERR(data)); > > Please Try To Make Your Log Messages A Bit More Descriptive And > Typographically Correct - I'd not expect a user to have a hope of > figuring out what's gone wrong here. That said, I suspect you're > looking for BUG_ON() here... Could we do WARN_ON() here? Unless this is a really serious problem. Daniel -- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.