linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavankumar Kondeti <pkondeti@codeaurora.org>
To: linux-usb@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
	Pavankumar Kondeti <pkondeti@codeaurora.org>
Subject: [RFC v2 4/4] USB: Eliminate delays involved in root hub initialization during HNP
Date: Thu, 16 Dec 2010 16:39:02 +0530	[thread overview]
Message-ID: <1292497742-2618-5-git-send-email-pkondeti@codeaurora.org> (raw)
In-Reply-To: <1292497742-2618-1-git-send-email-pkondeti@codeaurora.org>

Some USB controllers have common resources (IRQ, register address
space) for Host, Peripheral and OTG.  So HCD is added only before
entering into Host mode.  Root hub initialization is done in
different steps to decrease boot up time.  But this makes B-device
difficult to meet HNP timings.  Hence eliminate delays involved in
root hub initialization for B-host.

This patch also marks hnp_supported flag TRUE for B-host while
registering the bus.

Change-Id: I821775e8c90bd71a7abbe17176f189664a1841e1
Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
---
 drivers/usb/core/hcd.c |    2 ++
 drivers/usb/core/hub.c |    9 +++++++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 5dd59e9..07e6903 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -900,6 +900,8 @@ static int usb_register_bus(struct usb_bus *bus)
 	list_add (&bus->bus_list, &usb_bus_list);
 	mutex_unlock(&usb_bus_list_lock);
 
+	if (bus->is_b_host)
+		bus->hnp_support = 1;
 	usb_notify_add_bus(bus);
 
 	dev_info (bus->controller, "new USB bus registered, assigned bus "
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index ac79fd5..2df61ba 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -680,6 +680,7 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
 	int status;
 	bool need_debounce_delay = false;
 	unsigned delay;
+	bool hnp_in_progress = hdev->bus->is_b_host && (type == HUB_INIT);
 
 	/* Continue a partial initialization */
 	if (type == HUB_INIT2)
@@ -706,6 +707,8 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
 		 */
 		if (type == HUB_INIT) {
 			delay = hub_power_on(hub, false);
+			if (hnp_in_progress)
+				goto init2;
 			PREPARE_DELAYED_WORK(&hub->init_work, hub_init_func2);
 			schedule_delayed_work(&hub->init_work,
 					msecs_to_jiffies(delay));
@@ -811,6 +814,9 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
 		}
 	}
 
+		if (hnp_in_progress)
+			goto init3;
+
 	/* If no port-status-change flags were set, we don't need any
 	 * debouncing.  If flags were set we can try to debounce the
 	 * ports all at once right now, instead of letting khubd do them
@@ -844,6 +850,9 @@ static void hub_activate(struct usb_hub *hub, enum hub_activation_type type)
 	/* Scan all ports that need attention */
 	kick_khubd(hub);
 
+	if (hnp_in_progress)
+		return;
+
 	/* Allow autosuspend if it was suppressed */
 	if (type <= HUB_INIT3)
 		usb_autopm_put_interface_async(to_usb_interface(hub->intfdev));
-- 
1.7.1

--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  parent reply	other threads:[~2010-12-16 11:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-16 11:08 [RFC v2 0/4] USB core changes for supporting OTG on MSM SoC Pavankumar Kondeti
2010-12-16 11:08 ` [RFC v2 1/4] USB: core: OTG Supplement Revision 2.0 updates Pavankumar Kondeti
2010-12-16 15:34   ` Alan Stern
2010-12-16 15:53     ` Pavan Kondeti
2010-12-16 11:09 ` [RFC v2 2/4] USB: gadget: OTG supplement revision " Pavankumar Kondeti
2010-12-16 11:09 ` [RFC v2 3/4] USB: EHCI: Notify HCD about HNP enabled port suspend Pavankumar Kondeti
2010-12-16 11:09 ` Pavankumar Kondeti [this message]
2010-12-16 12:39   ` [RFC v2 4/4] USB: Eliminate delays involved in root hub initialization during HNP Sergei Shtylyov
2010-12-16 13:07     ` Felipe Balbi
2010-12-16 13:13       ` Pavan Kondeti
2010-12-16 13:17       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292497742-2618-5-git-send-email-pkondeti@codeaurora.org \
    --to=pkondeti@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).