From: Daniel Walker <dwalker@codeaurora.org>
To: davidb@codeaurora.org
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Walker <dwalker@codeaurora.org>
Subject: [PATCH 3/5] mmc: msm: fix msmsdcc_disable_clocks spinlock protection
Date: Mon, 20 Dec 2010 15:16:49 -0800 [thread overview]
Message-ID: <1292887011-30006-3-git-send-email-dwalker@codeaurora.org> (raw)
In-Reply-To: <1292887011-30006-1-git-send-email-dwalker@codeaurora.org>
The function msmsdcc_disable_clocks needs to be called with
the host lock held.
Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
---
drivers/mmc/host/msm_sdcc.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/msm_sdcc.c b/drivers/mmc/host/msm_sdcc.c
index 01bb684..c64a659 100644
--- a/drivers/mmc/host/msm_sdcc.c
+++ b/drivers/mmc/host/msm_sdcc.c
@@ -261,10 +261,10 @@ msmsdcc_dma_complete_func(struct msm_dmov_cmd *cmd,
host->curr.cmd = NULL;
mrq->data->bytes_xfered = host->curr.data_xfered;
- spin_unlock_irqrestore(&host->lock, flags);
-
msmsdcc_disable_clocks(host, 1);
+ spin_unlock_irqrestore(&host->lock, flags);
+
mmc_request_done(host->mmc, mrq);
return;
} else
--
1.7.0.4
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-12-20 23:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 23:16 [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE Daniel Walker
2010-12-20 23:16 ` [PATCH 2/5] mmc: msm: convert int bools to actual bool type Daniel Walker
2010-12-20 23:16 ` Daniel Walker [this message]
2010-12-20 23:16 ` [PATCH 4/5] mmc: msm: fix non-tab spacing Daniel Walker
2010-12-20 23:16 ` [PATCH 5/5] mmc: msm: fix weird spacing Daniel Walker
2010-12-20 23:35 ` [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE David Brown
2010-12-20 23:39 ` Daniel Walker
2010-12-20 23:42 ` David Brown
2010-12-20 23:45 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292887011-30006-3-git-send-email-dwalker@codeaurora.org \
--to=dwalker@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).