From: Daniel Walker <dwalker@codeaurora.org>
To: David Brown <davidb@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE
Date: Mon, 20 Dec 2010 15:39:10 -0800 [thread overview]
Message-ID: <1292888350.27552.22.camel@m0nster> (raw)
In-Reply-To: <20101220233519.GA14582@huya.qualcomm.com>
On Mon, 2010-12-20 at 15:35 -0800, David Brown wrote:
> On Mon, Dec 20, 2010 at 03:16:47PM -0800, Daniel Walker wrote:
>
> > It's cleaner to have ifdef's consolidated in one specific
> > area. This change pulls adds one ifdef which will swap
> > out of the function with a stub function if the ifdef is
> > false.
>
> It also changes the define from #if checks to #ifdef which changes how
> it would be used.
True, but it's defined in the code. So you have to comment the line out
now instead of change it to "0" ..
> I this feature even used? It looks like some kind debug feature.
Yeah it's used, it's default on..
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
next prev parent reply other threads:[~2010-12-20 23:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 23:16 [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE Daniel Walker
2010-12-20 23:16 ` [PATCH 2/5] mmc: msm: convert int bools to actual bool type Daniel Walker
2010-12-20 23:16 ` [PATCH 3/5] mmc: msm: fix msmsdcc_disable_clocks spinlock protection Daniel Walker
2010-12-20 23:16 ` [PATCH 4/5] mmc: msm: fix non-tab spacing Daniel Walker
2010-12-20 23:16 ` [PATCH 5/5] mmc: msm: fix weird spacing Daniel Walker
2010-12-20 23:35 ` [PATCH 1/5] mmc: msm: consolidate ifdefs for BUSCLK_PWRSAVE David Brown
2010-12-20 23:39 ` Daniel Walker [this message]
2010-12-20 23:42 ` David Brown
2010-12-20 23:45 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292888350.27552.22.camel@m0nster \
--to=dwalker@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).