From: Daniel Walker <dwalker@codeaurora.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: davidb@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] drivers: mmc: msm: update to new arm pfn_to_dma API
Date: Tue, 18 Jan 2011 12:22:14 -0800 [thread overview]
Message-ID: <1295382134.26904.7.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <20110118182826.GI16980@n2100.arm.linux.org.uk>
On Tue, 2011-01-18 at 18:28 +0000, Russell King - ARM Linux wrote:
> On Tue, Jan 18, 2011 at 10:04:04AM -0800, Daniel Walker wrote:
> > The page_to_dma() API call was removed. It caused this build
> > failure,
>
> Because it's an API internal interface. Don't use it. Why is this
> driver poking about in API internals all over the place?
If it's internal why is this driver able to call it?
> That is completely broken. Please use the official APIs - it's not
> hard. Here's how to do it correctly:
Can you make this into a patch and send it to David Brown ?
>
> and when you use writel() etc afterwards, those non-cacheable writes to
> box-> will be ordered with your device write.
>
> So that's a NAK for your original patch.
Are you given us alternative to my fix yet? I didn't see any of your
comments touching that area?
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-01-18 20:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 18:04 [PATCH] drivers: mmc: msm: update to new arm pfn_to_dma API Daniel Walker
2011-01-18 18:28 ` Russell King - ARM Linux
2011-01-18 20:22 ` Daniel Walker [this message]
2011-01-18 20:44 ` Russell King - ARM Linux
2011-01-18 21:00 ` Daniel Walker
2011-01-18 21:16 ` Russell King - ARM Linux
2011-01-18 21:28 ` Daniel Walker
2011-01-18 22:41 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295382134.26904.7.camel@c-dwalke-linux.qualcomm.com \
--to=dwalker@codeaurora.org \
--cc=davidb@quicinc.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).