From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: [PATCH 1/4] msm: clock: Remove unused code and definitions Date: Wed, 26 Jan 2011 14:03:02 -0800 Message-ID: <1296079382.29801.45.camel@c-dwalke-linux.qualcomm.com> References: <1295927118-27591-1-git-send-email-sboyd@codeaurora.org> <1295927118-27591-2-git-send-email-sboyd@codeaurora.org> <1295991537.25496.49.camel@c-dwalke-linux.qualcomm.com> <4D3F4609.3000808@codeaurora.org> <1295992937.25496.75.camel@c-dwalke-linux.qualcomm.com> <8ya1v3z8gu6.fsf@huya.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8ya1v3z8gu6.fsf@huya.qualcomm.com> Sender: linux-kernel-owner@vger.kernel.org To: David Brown Cc: Saravana Kannan , Stephen Boyd , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-arm-msm@vger.kernel.org On Wed, 2011-01-26 at 14:01 -0800, David Brown wrote: > On Tue, Jan 25 2011, Daniel Walker wrote: > > > On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote: > >> On 01/25/2011 01:38 PM, Daniel Walker wrote: > >> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote: > >> >> Remove dead code and push out clock-7x30.h and clock-pcom.h to > >> >> where they are actually used. > >> >> > >> > > >> > I'd do two patches for this. The stuff your doing is too disconnected. > >> > > >> > Daniel > >> > > >> There is a whole bunch of unused code in the clock files and it's being > >> deleted. I don't see a point of splitting it up per file. > > > > It's easier to review when changes aren't merged that don't related to > > each other. > > In this particular case, the patch is a bunch of removal of dead code, > and kind of makes sense to keep it together. I'm fine with it as is. He's adding stuff too .. So it's not _just_ removal which is what I was getting at. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.