From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone. Date: Mon, 21 Mar 2011 09:12:31 +0200 Message-ID: <1300691551.2761.8.camel@localhost> References: <1299542935-20291-1-git-send-email-mnalajal@codeaurora.org> <1299570622.2754.4.camel@localhost> <4D766A2F.9080001@codeaurora.org> <4D86F295.8040409@codeaurora.org> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:35858 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624Ab1CUHOJ (ORCPT ); Mon, 21 Mar 2011 03:14:09 -0400 Received: by eyx24 with SMTP id 24so1423818eyx.19 for ; Mon, 21 Mar 2011 00:14:07 -0700 (PDT) In-Reply-To: <4D86F295.8040409@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Murali Nalajala Cc: dwmw2@infradead.org, linux-arm-msm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Dima Zavin On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote: > On 3/8/2011 11:11 PM, Murali Nalajala wrote: > > On 3/8/2011 12:50 AM, Artem Bityutskiy wrote: > >> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote: > >>> Lets non-standard NAND drivers take advantage of known NAND > >>> chip information. > >>> > >>> The initial development of msm nand driver, driver uses the suppo= rted > >>> NAND devices information as a hardcoded table. Remove the existin= g > >>> hardcoded supported flash device table and read the flash device > >>> information from the flash id table which are part of the mtd sub= system. > >> > >> Why this initial version should be upstream? Why wouldn't you make= it > >> "standard" first? > >> > > > > Currently we are not fully using the MTD nand subsystem. That's the > > intention author has introduced "non-standard" here!!! > > > > Thanks, > > Murali N > > >=20 > Any reviews comments on this change? No, I think you should "sell" your driver better than that. Indeed, Q: "Why this initial version should be upstream? Why wouldn't you make it "standard" first?" A: Currently we are not fully using the MTD nand subsystem. That's the intention author has introduced "non-standard" here!!! --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9)