From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH 2/2] mtd: msm_nand: Add initial msm nand driver support. Date: Sat, 16 Apr 2011 17:19:50 +0300 Message-ID: <1302963590.2308.9.camel@koala> References: <1298940450-27365-1-git-send-email-mnalajal@codeaurora.org> <1298940450-27365-2-git-send-email-mnalajal@codeaurora.org> <1302861097.3220.12.camel@localhost> <4DA85B24.50807@codeaurora.org> <1302942029.2308.1.camel@koala> <4DA96890.2070207@codeaurora.org> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:55998 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381Ab1DPOT4 (ORCPT ); Sat, 16 Apr 2011 10:19:56 -0400 In-Reply-To: <4DA96890.2070207@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Murali Nalajala Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dima Zavin , Brian Swetland , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= > Can i export this variable now? I do not think so, we do not export random variables. > What is your suggestion? But I already did provide you suggestions - kill this global variable completely. I provided the reasons: 1. It is error prone to hide functions behind something which looks lik= e a constant. 2. Multiple controllers with different base addresses wouldn't work - your driver has to be able to at least theoretically handle multiple controllers with different bases. --=20 Best Regards, Artem Bityutskiy (=D0=91=D0=B8=D1=82=D1=8E=D1=86=D0=BA=D0=B8=D0=B9 =D0=90= =D1=80=D1=82=D1=91=D0=BC)