From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Bityutskiy Subject: Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support. Date: Mon, 18 Apr 2011 10:56:06 +0300 Message-ID: <1303113366.2815.31.camel@localhost> References: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org> <4DABE8FE.5040300@parrot.com> Reply-To: dedekind1@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-ey0-f174.google.com ([209.85.215.174]:33373 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411Ab1DRH7F (ORCPT ); Mon, 18 Apr 2011 03:59:05 -0400 Received: by eyx24 with SMTP id 24so1270896eyx.19 for ; Mon, 18 Apr 2011 00:59:03 -0700 (PDT) In-Reply-To: <4DABE8FE.5040300@parrot.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Matthieu CASTET Cc: Murali Nalajala , "linux-arm-msm@vger.kernel.org" , Dima Zavin , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , "linux-mtd@lists.infradead.org" , Brian Swetland , "dwmw2@infradead.org" , "linux-arm-kernel@lists.infradead.org" On Mon, 2011-04-18 at 09:32 +0200, Matthieu CASTET wrote: > Hi, >=20 > Murali Nalajala a =C3=A9crit : > > Add initial msm nand driver support for Qualcomm MSM platforms. > > This driver is capable of handling both 2k and 4k page support > > nand devices. > >=20 > > This driver was originally developed by Arve Hj=C3=B8nnev=C3=A5g at= google. > > Its source is available at > > http://android.git.kernel.org/?p=3Dkernel/msm.git under > > android-msm-2.6.35 branch. > >=20 > > CC: Dima Zavin > > CC: Brian Swetland > > CC: Arve Hj=C3=B8nnev=C3=A5g > > Signed-off-by: Murali Nalajala > > --- > > Changes in V2 > > * Turn most of the pr_info() calls into pr_debug(). > >=20 > > drivers/mtd/devices/Kconfig | 11 + > > drivers/mtd/devices/Makefile | 1 + > > drivers/mtd/devices/msm_nand.c | 1597 ++++++++++++++++++++++++++++= ++++++++++++ > > drivers/mtd/devices/msm_nand.h | 77 ++ > > 4 files changed, 1686 insertions(+), 0 deletions(-) > > create mode 100644 drivers/mtd/devices/msm_nand.c > > create mode 100644 drivers/mtd/devices/msm_nand.h > >=20 >=20 > For the record, I am not sure it is a great idea to make nand drivers > independent of the nand layer. This is not acceptable. Nand drivers should use the nand_base framework= =2E If the framework is limiting, buggy, slow, etc for your case (which is quite possible) - the framework should be improved. --=20 Best Regards, Artem Bityutskiy (=D0=90=D1=80=D1=82=D1=91=D0=BC =D0=91=D0=B8=D1=82=D1=8E= =D1=86=D0=BA=D0=B8=D0=B9)