From: Tatyana Brokhman <tlinder@codeaurora.org>
To: greg@kroah.com
Cc: linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org,
balbi@ti.com, ablay@codeaurora.org,
Tatyana Brokhman <tlinder@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v12 8/8] usb:gadget: coding style fixes
Date: Mon, 23 May 2011 09:41:17 +0300 [thread overview]
Message-ID: <1306132882-9668-9-git-send-email-tlinder@codeaurora.org> (raw)
In-Reply-To: <1306132882-9668-1-git-send-email-tlinder@codeaurora.org>
Signed-off-by: Tatyana Brokhman <tlinder@codeaurora.org>
---
drivers/usb/gadget/composite.c | 20 +++++++++++----
drivers/usb/gadget/dummy_hcd.c | 52 ++++++++++++++++++++++++++++++----------
2 files changed, 54 insertions(+), 18 deletions(-)
diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 7738302..bee33d2 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -629,11 +629,21 @@ static int set_config(struct usb_composite_dev *cdev,
INFO(cdev, "%s speed config #%d: %s\n",
({ char *speed;
switch (gadget->speed) {
- case USB_SPEED_LOW: speed = "low"; break;
- case USB_SPEED_FULL: speed = "full"; break;
- case USB_SPEED_HIGH: speed = "high"; break;
- case USB_SPEED_SUPER: speed = "super"; break;
- default: speed = "?"; break;
+ case USB_SPEED_LOW:
+ speed = "low";
+ break;
+ case USB_SPEED_FULL:
+ speed = "full";
+ break;
+ case USB_SPEED_HIGH:
+ speed = "high";
+ break;
+ case USB_SPEED_SUPER:
+ speed = "super";
+ break;
+ default:
+ speed = "?";
+ break;
} ; speed; }), number, c ? c->label : "unconfigured");
if (!c)
diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
index c2731d3..abfafd6 100644
--- a/drivers/usb/gadget/dummy_hcd.c
+++ b/drivers/usb/gadget/dummy_hcd.c
@@ -546,10 +546,18 @@ dummy_enable (struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc)
(desc->bEndpointAddress & USB_DIR_IN) ? "in" : "out",
({ char *val;
switch (desc->bmAttributes & 0x03) {
- case USB_ENDPOINT_XFER_BULK: val = "bulk"; break;
- case USB_ENDPOINT_XFER_ISOC: val = "iso"; break;
- case USB_ENDPOINT_XFER_INT: val = "intr"; break;
- default: val = "ctrl"; break;
+ case USB_ENDPOINT_XFER_BULK:
+ val = "bulk";
+ break;
+ case USB_ENDPOINT_XFER_ISOC:
+ val = "iso";
+ break;
+ case USB_ENDPOINT_XFER_INT:
+ val = "intr";
+ break;
+ default:
+ val = "ctrl";
+ break;
}; val; }),
max);
@@ -2151,19 +2159,37 @@ show_urb (char *buf, size_t size, struct urb *urb)
urb,
({ char *s;
switch (urb->dev->speed) {
- case USB_SPEED_LOW: s = "ls"; break;
- case USB_SPEED_FULL: s = "fs"; break;
- case USB_SPEED_HIGH: s = "hs"; break;
- case USB_SPEED_SUPER: s = "ss"; break;
- default: s = "?"; break;
+ case USB_SPEED_LOW:
+ s = "ls";
+ break;
+ case USB_SPEED_FULL:
+ s = "fs";
+ break;
+ case USB_SPEED_HIGH:
+ s = "hs";
+ break;
+ case USB_SPEED_SUPER:
+ s = "ss";
+ break;
+ default:
+ s = "?";
+ break;
}; s; }),
ep, ep ? (usb_pipein (urb->pipe) ? "in" : "out") : "",
({ char *s; \
switch (usb_pipetype (urb->pipe)) { \
- case PIPE_CONTROL: s = ""; break; \
- case PIPE_BULK: s = "-bulk"; break; \
- case PIPE_INTERRUPT: s = "-int"; break; \
- default: s = "-iso"; break; \
+ case PIPE_CONTROL: \
+ s = ""; \
+ break; \
+ case PIPE_BULK: \
+ s = "-bulk"; \
+ break; \
+ case PIPE_INTERRUPT: \
+ s = "-int"; \
+ break; \
+ default: \
+ s = "-iso"; \
+ break; \
}; s;}),
urb->actual_length, urb->transfer_buffer_length);
}
--
1.7.3.3
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
prev parent reply other threads:[~2011-05-23 6:41 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 6:41 [PATCH v12 0/8] usb gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-05-23 6:41 ` [PATCH v12 2/8] usb: Configure endpoint according to gadget speed Tatyana Brokhman
2011-05-23 6:41 ` [PATCH/RESEND v12 3/8] usb: Modify existing gadget drivers to use config_ep_by_speed() instead of ep_choose Tatyana Brokhman
[not found] ` <1306132882-9668-1-git-send-email-tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-23 6:41 ` [PATCH/RESEND v12 1/8] usb: Add usb_endpoint_descriptor to be part of the struct usb_ep Tatyana Brokhman
2011-05-23 6:41 ` [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework Tatyana Brokhman
2011-05-23 12:31 ` Sebastian Andrzej Siewior
2011-05-23 22:18 ` Mike Frysinger
2011-05-24 5:10 ` Tanya Brokhman
2011-05-24 5:14 ` Mike Frysinger
2011-05-24 5:37 ` Tanya Brokhman
2011-05-24 17:12 ` Mike Frysinger
2011-05-23 6:41 ` [PATCH/RESEND v12 5/8] usb: Add streams support to the gadget framework Tatyana Brokhman
2011-05-23 6:41 ` [PATCH v12 6/8] usb:dummy_hcd: use the shared_hcd infrastructure Tatyana Brokhman
2011-05-23 6:41 ` [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd Tatyana Brokhman
[not found] ` <1306132882-9668-8-git-send-email-tlinder-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-23 7:05 ` Felipe Balbi
2011-05-23 7:20 ` Tanya Brokhman
2011-05-23 7:21 ` Felipe Balbi
2011-05-23 8:18 ` Tanya Brokhman
2011-05-23 8:32 ` Felipe Balbi
2011-05-23 9:16 ` Tanya Brokhman
2011-05-23 14:22 ` Alan Stern
2011-05-23 16:08 ` Sarah Sharp
2011-05-23 16:28 ` Alan Stern
2011-05-23 21:06 ` Felipe Balbi
[not found] ` <BD27AEAC-1E6D-480C-9E18-A970B992AD75-l0cyMroinI0@public.gmane.org>
2011-05-23 21:21 ` Alan Stern
2011-05-24 5:53 ` Tanya Brokhman
2011-05-24 10:18 ` Felipe Balbi
2011-05-24 10:31 ` Tanya Brokhman
2011-05-24 10:33 ` Felipe Balbi
2011-05-24 10:43 ` Tanya Brokhman
2011-05-24 14:20 ` Alan Stern
2011-05-25 4:46 ` Tanya Brokhman
2011-05-25 9:21 ` Felipe Balbi
[not found] ` <20110525092124.GI14556-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-25 9:26 ` Tanya Brokhman
2011-05-25 9:27 ` Felipe Balbi
2011-05-25 9:43 ` Tanya Brokhman
2011-05-25 9:49 ` Felipe Balbi
2011-05-25 10:03 ` Tanya Brokhman
2011-05-25 10:29 ` Felipe Balbi
2011-05-25 10:52 ` Tanya Brokhman
2011-05-25 11:23 ` Felipe Balbi
2011-05-25 11:33 ` Tanya Brokhman
2011-05-25 12:42 ` Felipe Balbi
2011-05-25 14:23 ` Alan Stern
2011-05-25 14:39 ` Alan Stern
2011-05-28 11:05 ` Tanya Brokhman
2011-05-28 14:15 ` Alan Stern
2011-06-07 10:33 ` Felipe Balbi
2011-05-25 17:07 ` Brokhman Tatyana
2011-05-25 17:29 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1105251316170.1987-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2011-05-25 18:13 ` Brokhman Tatyana
2011-05-25 18:59 ` Alan Stern
2011-05-26 6:51 ` Tanya Brokhman
2011-05-26 14:31 ` Alan Stern
2011-05-26 16:15 ` Brokhman Tatyana
2011-05-25 9:20 ` Felipe Balbi
2011-05-23 15:55 ` Sarah Sharp
[not found] ` <20110523072142.GK3095-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-23 14:20 ` Alan Stern
[not found] ` <20110523070556.GJ3095-UiBtZHVXSwEVvW8u9ZQWYwjfymiNCTlR@public.gmane.org>
2011-05-23 14:18 ` Alan Stern
2011-05-23 6:41 ` Tatyana Brokhman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306132882-9668-9-git-send-email-tlinder@codeaurora.org \
--to=tlinder@codeaurora.org \
--cc=ablay@codeaurora.org \
--cc=balbi@ti.com \
--cc=greg@kroah.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).