From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeykumar Sankaran Subject: Re: [PATCH v2 6/7] drm/msm: dpu: Make dpu_plane_sspp_atomic_update() void Date: Thu, 13 Sep 2018 15:33:34 -0700 Message-ID: <13179388a83d9500ed023063acbeac57@codeaurora.org> References: <20180912135459.216217-1-sean@poorly.run> <20180912135459.216217-6-sean@poorly.run> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180912135459.216217-6-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Sean Paul Cc: bzwang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sean Paul , abhinavk-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOC0wOS0xMiAwNjo1NCwgU2VhbiBQYXVsIHdyb3RlOgo+IEZyb206IFNlYW4gUGF1bCA8 c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IAo+IEFsbCBvZiB0aGUgY2hlY2tzIGluIGRwdV9wbGFu ZV9zc3BwX2F0b21pY191cGRhdGUoKSBhcmUgaW1wb3NzaWJsZSwgc28KPiByZW1vdmUgdGhlbSBh bmQgbWFrZSB0aGUgZnVuY3Rpb24gdm9pZC4gVGhpcyByZW1vdmVzIHRoZSBuZWVkIHRvIGVycm9y Cj4gY2hlY2sgaW4gZHB1X3BsYW5lX2F0b21pY191cGRhdGUoKS4gQWRkaXRpb25hbGx5LCByZW1v dmUgaW1wb3NzaWJsZSAKPiBjaGVja3MKPiBpbiBkcHVfcGxhbmVfYXRvbWljX3VwZGF0ZSgpLgo+ IAo+IENoYW5nZXMgaW4gdjI6Cj4gLSBOb25lCj4gCj4gU2lnbmVkLW9mZi1ieTogU2VhbiBQYXVs IDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gLS0tCgpSZXZpZXdlZC1ieTogSmV5a3VtYXIgU2Fu a2FyYW4gPGpzYW5rYUBjb2RlYXVyb3JhLm9yZz4KCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vZGlz cC9kcHUxL2RwdV9wbGFuZS5jIHwgNzEgKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDU3IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1MS9kcHVfcGxhbmUuYwo+IGIvZHJpdmVy cy9ncHUvZHJtL21zbS9kaXNwL2RwdTEvZHB1X3BsYW5lLmMKPiBpbmRleCBjZTgwYzUxYjEwYWEu LjJjZmE1NTgzNDYzZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL2Rpc3AvZHB1 MS9kcHVfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9kcHUxL2RwdV9w bGFuZS5jCj4gQEAgLTExOTIsNDUgKzExOTIsMTcgQEAgdm9pZCBkcHVfcGxhbmVfc2V0X2Vycm9y KHN0cnVjdCBkcm1fcGxhbmUgCj4gKnBsYW5lLAo+IGJvb2wgZXJyb3IpCj4gIAlwZHB1LT5pc19l cnJvciA9IGVycm9yOwo+ICB9Cj4gCj4gLXN0YXRpYyBpbnQgZHB1X3BsYW5lX3NzcHBfYXRvbWlj X3VwZGF0ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAtCQkJCXN0cnVjdCBkcm1fcGxhbmVf c3RhdGUgKm9sZF9zdGF0ZSkKPiArc3RhdGljIHZvaWQgZHB1X3BsYW5lX3NzcHBfYXRvbWljX3Vw ZGF0ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiArCQkJCQkgc3RydWN0IGRybV9wbGFuZV9z dGF0ZQo+ICpvbGRfc3RhdGUpCj4gIHsKPiAtCXVpbnQzMl90IG5wbGFuZXMsIHNyY19mbGFnczsK PiAtCXN0cnVjdCBkcHVfcGxhbmUgKnBkcHU7Cj4gLQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpz dGF0ZTsKPiAtCXN0cnVjdCBkcHVfcGxhbmVfc3RhdGUgKnBzdGF0ZTsKPiAtCXN0cnVjdCBkcHVf cGxhbmVfc3RhdGUgKm9sZF9wc3RhdGU7Cj4gLQljb25zdCBzdHJ1Y3QgZHB1X2Zvcm1hdCAqZm10 Owo+IC0Jc3RydWN0IGRybV9jcnRjICpjcnRjOwo+IC0Jc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAq ZmI7Cj4gLQo+IC0JaWYgKCFwbGFuZSkgewo+IC0JCURQVV9FUlJPUigiaW52YWxpZCBwbGFuZVxu Iik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9IGVsc2UgaWYgKCFwbGFuZS0+c3RhdGUpIHsK PiAtCQlEUFVfRVJST1IoImludmFsaWQgcGxhbmUgc3RhdGVcbiIpOwo+IC0JCXJldHVybiAtRUlO VkFMOwo+IC0JfSBlbHNlIGlmICghb2xkX3N0YXRlKSB7Cj4gLQkJRFBVX0VSUk9SKCJpbnZhbGlk IG9sZCBzdGF0ZVxuIik7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9Cj4gLQo+IC0JcGRwdSA9 IHRvX2RwdV9wbGFuZShwbGFuZSk7Cj4gLQlzdGF0ZSA9IHBsYW5lLT5zdGF0ZTsKPiAtCj4gLQlw c3RhdGUgPSB0b19kcHVfcGxhbmVfc3RhdGUoc3RhdGUpOwo+IC0KPiAtCW9sZF9wc3RhdGUgPSB0 b19kcHVfcGxhbmVfc3RhdGUob2xkX3N0YXRlKTsKPiAtCj4gLQljcnRjID0gc3RhdGUtPmNydGM7 Cj4gLQlmYiA9IHN0YXRlLT5mYjsKPiAtCWlmICghY3J0YyB8fCAhZmIpIHsKPiAtCQlEUFVfRVJS T1JfUExBTkUocGRwdSwgImludmFsaWQgY3J0YyAlZCBvciBmYiAlZFxuIiwKPiAtCQkJCWNydGMg IT0gMCwgZmIgIT0gMCk7Cj4gLQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQl9Cj4gLQlmbXQgPSB0b19k cHVfZm9ybWF0KG1zbV9mcmFtZWJ1ZmZlcl9mb3JtYXQoZmIpKTsKPiAtCW5wbGFuZXMgPSBmbXQt Pm51bV9wbGFuZXM7Cj4gKwl1aW50MzJfdCBzcmNfZmxhZ3M7Cj4gKwlzdHJ1Y3QgZHB1X3BsYW5l ICpwZHB1ID0gdG9fZHB1X3BsYW5lKHBsYW5lKTsKPiArCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUg KnN0YXRlID0gcGxhbmUtPnN0YXRlOwo+ICsJc3RydWN0IGRwdV9wbGFuZV9zdGF0ZSAqcHN0YXRl ID0gdG9fZHB1X3BsYW5lX3N0YXRlKHN0YXRlKTsKPiArCXN0cnVjdCBkcm1fY3J0YyAqY3J0YyA9 IHN0YXRlLT5jcnRjOwo+ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBzdGF0ZS0+ZmI7 Cj4gKwljb25zdCBzdHJ1Y3QgZHB1X2Zvcm1hdCAqZm10ID0KPiArCQl0b19kcHVfZm9ybWF0KG1z bV9mcmFtZWJ1ZmZlcl9mb3JtYXQoZmIpKTsKPiAKPiAgCW1lbXNldCgmKHBkcHUtPnBpcGVfY2Zn KSwgMCwgc2l6ZW9mKHN0cnVjdCBkcHVfaHdfcGlwZV9jZmcpKTsKPiAKPiBAQCAtMTI2MSw3ICsx MjMzLDcgQEAgc3RhdGljIGludCBkcHVfcGxhbmVfc3NwcF9hdG9taWNfdXBkYXRlKHN0cnVjdAo+ IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkvKiBvdmVycmlkZSBmb3IgY29sb3IgZmlsbCAqLwo+ICAJ aWYgKHBkcHUtPmNvbG9yX2ZpbGwgJiBEUFVfUExBTkVfQ09MT1JfRklMTF9GTEFHKSB7Cj4gIAkJ Lyogc2tpcCByZW1haW5pbmcgcHJvY2Vzc2luZyBvbiBjb2xvciBmaWxsICovCj4gLQkJcmV0dXJu IDA7Cj4gKwkJcmV0dXJuOwo+ICAJfQo+IAo+ICAJaWYgKHBkcHUtPnBpcGVfaHctPm9wcy5zZXR1 cF9yZWN0cykgewo+IEBAIC0xMzMyLDcgKzEzMDQsNiBAQCBzdGF0aWMgaW50IGRwdV9wbGFuZV9z c3BwX2F0b21pY191cGRhdGUoc3RydWN0Cj4gZHJtX3BsYW5lICpwbGFuZSwKPiAgCX0KPiAKPiAg CV9kcHVfcGxhbmVfc2V0X3Fvc19yZW1hcChwbGFuZSk7Cj4gLQlyZXR1cm4gMDsKPiAgfQo+IAo+ ICBzdGF0aWMgdm9pZCBfZHB1X3BsYW5lX2F0b21pY19kaXNhYmxlKHN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lLAo+IEBAIC0xMzcxLDMxICsxMzQyLDE3IEBAIHN0YXRpYyB2b2lkIF9kcHVfcGxhbmVf YXRvbWljX2Rpc2FibGUoc3RydWN0Cj4gZHJtX3BsYW5lICpwbGFuZSwKPiAgc3RhdGljIHZvaWQg ZHB1X3BsYW5lX2F0b21pY191cGRhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJCQlz dHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpvbGRfc3RhdGUpCj4gIHsKPiAtCXN0cnVjdCBkcHVfcGxh bmUgKnBkcHU7Cj4gLQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZTsKPiAtCj4gLQlpZiAo IXBsYW5lKSB7Cj4gLQkJRFBVX0VSUk9SKCJpbnZhbGlkIHBsYW5lXG4iKTsKPiAtCQlyZXR1cm47 Cj4gLQl9IGVsc2UgaWYgKCFwbGFuZS0+c3RhdGUpIHsKPiAtCQlEUFVfRVJST1IoImludmFsaWQg cGxhbmUgc3RhdGVcbiIpOwo+IC0JCXJldHVybjsKPiAtCX0KPiArCXN0cnVjdCBkcHVfcGxhbmUg KnBkcHUgPSB0b19kcHVfcGxhbmUocGxhbmUpOwo+ICsJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAq c3RhdGUgPSBwbGFuZS0+c3RhdGU7Cj4gCj4gLQlwZHB1ID0gdG9fZHB1X3BsYW5lKHBsYW5lKTsK PiAgCXBkcHUtPmlzX2Vycm9yID0gZmFsc2U7Cj4gLQlzdGF0ZSA9IHBsYW5lLT5zdGF0ZTsKPiAK PiAgCURQVV9ERUJVR19QTEFORShwZHB1LCAiXG4iKTsKPiAKPiAgCWlmICghc3RhdGUtPnZpc2li bGUpIHsKPiAgCQlfZHB1X3BsYW5lX2F0b21pY19kaXNhYmxlKHBsYW5lLCBvbGRfc3RhdGUpOwo+ ICAJfSBlbHNlIHsKPiAtCQlpbnQgcmV0Owo+IC0KPiAtCQlyZXQgPSBkcHVfcGxhbmVfc3NwcF9h dG9taWNfdXBkYXRlKHBsYW5lLCBvbGRfc3RhdGUpOwo+IC0JCS8qIGF0b21pY19jaGVjayBzaG91 bGQgaGF2ZSBlbnN1cmVkIHRoYXQgdGhpcyBkb2Vzbid0IGZhaWwKPiAqLwo+IC0JCVdBUk5fT04o cmV0IDwgMCk7Cj4gKwkJZHB1X3BsYW5lX3NzcHBfYXRvbWljX3VwZGF0ZShwbGFuZSwgb2xkX3N0 YXRlKTsKPiAgCX0KPiAgfQoKLS0gCkpleWt1bWFyIFMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5vIG1haWxpbmcgbGlzdApGcmVlZHJlbm9A bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZnJlZWRyZW5vCg==