From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B679C433EF for ; Tue, 1 Mar 2022 15:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230189AbiCAPp7 (ORCPT ); Tue, 1 Mar 2022 10:45:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233364AbiCAPp7 (ORCPT ); Tue, 1 Mar 2022 10:45:59 -0500 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30E554ECC8; Tue, 1 Mar 2022 07:45:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1646149518; x=1677685518; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=C/BjzGXxbcQNucZ4IX+eGwpvmWxMB4jt2HQM1WP1dbg=; b=MQteWPZW0dA6PEbnQ5k5EHn4JgBDd7WOjqwTiipPVWNnfCOXrbhz0n+8 5+edV8OxUj1I/3SYDgeGMGbKlcWdwABaxiroXsncX082w68AM5tyaF/d6 9IAaK1bxygdDKQyFrSVx50oppQTCwSdDdUDW+sTszrVPVZVyBWt2F6rRQ A=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-02.qualcomm.com with ESMTP; 01 Mar 2022 07:45:17 -0800 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2022 07:45:07 -0800 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Tue, 1 Mar 2022 07:45:07 -0800 Received: from [10.216.24.177] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.15; Tue, 1 Mar 2022 07:45:00 -0800 Message-ID: <134a64a9-abab-df25-a613-2d01ac7e5ee5@quicinc.com> Date: Tue, 1 Mar 2022 21:14:56 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v5 1/2] soundwire: qcom: Add compatible name for v1.6.0 Content-Language: en-US To: Stephen Boyd , , , , , , , , , , , , , , , , , , , CC: Venkata Prasad Potturu References: <1646030377-12092-1-git-send-email-quic_srivasam@quicinc.com> <1646030377-12092-2-git-send-email-quic_srivasam@quicinc.com> From: Srinivasa Rao Mandadapu Organization: Qualcomm In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/1/2022 2:32 AM, Stephen Boyd wrote: > Quoting Srinivasa Rao Mandadapu (2022-02-27 22:39:36) >> Update compatible string and master data information in soundwire driver >> to support v1.6.0 in lpass sc7280 based platform. >> >> Signed-off-by: Srinivasa Rao Mandadapu >> Co-developed-by: Venkata Prasad Potturu >> Signed-off-by: Venkata Prasad Potturu >> --- >> drivers/soundwire/qcom.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c >> index 9eb31ba..fb183bd 100644 >> --- a/drivers/soundwire/qcom.c >> +++ b/drivers/soundwire/qcom.c >> @@ -175,6 +175,11 @@ static struct qcom_swrm_data swrm_v1_5_data = { >> .default_cols = 16, >> }; >> >> +static struct qcom_swrm_data swrm_v1_6_data = { > Why not const? Okay. > >> + .default_rows = 50, >> + .default_cols = 16, > This is the same as swrm_v1_5_data so just use that struct again? Okay. Will use  swrm_v1_5_data. > >> +}; >> + >> #define to_qcom_sdw(b) container_of(b, struct qcom_swrm_ctrl, bus) >> >> static int qcom_swrm_ahb_reg_read(struct qcom_swrm_ctrl *ctrl, int reg, >> @@ -1343,6 +1348,7 @@ static int qcom_swrm_remove(struct platform_device *pdev) >> static const struct of_device_id qcom_swrm_of_match[] = { >> { .compatible = "qcom,soundwire-v1.3.0", .data = &swrm_v1_3_data }, >> { .compatible = "qcom,soundwire-v1.5.1", .data = &swrm_v1_5_data }, > These other structs for v1.5 and v1.3 could also be const. Okay. Will add const and re post. > >> + { .compatible = "qcom,soundwire-v1.6.0", .data = &swrm_v1_6_data }, >> {/* sentinel */},