From: Dolev Raviv <draviv@codeaurora.org>
To: linux-scsi@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
Dolev Raviv <draviv@codeaurora.org>,
Seungwon Jeon <tgih.jun@samsung.com>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH V1 5/8] scsi: ufs: fix interrupt status clears
Date: Sun, 12 May 2013 17:23:57 +0300 [thread overview]
Message-ID: <1368368640-10167-6-git-send-email-draviv@codeaurora.org> (raw)
In-Reply-To: <1368368640-10167-1-git-send-email-draviv@codeaurora.org>
There is no need to check the version to clear
the interrupt status. And the order is changed
prior to actual handling.
Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
Tested-by: Maya Erez <merez@codeaurora.org>
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index c342a38..f4293d1 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1478,11 +1478,8 @@ static irqreturn_t ufshcd_intr(int irq, void *__hba)
intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS);
if (intr_status) {
+ ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS);
ufshcd_sl_intr(hba, intr_status);
-
- /* If UFSHCI 1.0 then clear interrupt status register */
- if (hba->ufs_version == UFSHCI_VERSION_10)
- ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS);
retval = IRQ_HANDLED;
}
spin_unlock(hba->host->host_lock);
--
1.7.6
--
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-05-12 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-12 14:23 [PATCH V1 0/8] ufs patch siries Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 1/8] Documentation: devicetree: Add DT bindings for UFS host controller Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 2/8] scsi: ufs: Fix the response UPIU length setting Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 3/8] scsi: ufs: wrap the i/o access operations Dolev Raviv
2013-05-13 4:07 ` Seungwon Jeon
2013-05-13 6:29 ` Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 4/8] scsi: ufs: amend interrupt configuration Dolev Raviv
2013-05-12 14:23 ` Dolev Raviv [this message]
2013-05-12 14:23 ` [PATCH V1 6/8] scsi: ufs: rework link start-up process Dolev Raviv
2013-05-12 14:23 ` [PATCH V1 7/8] scsi: ufs: Add support for sending NOP OUT UPIU Dolev Raviv
2013-05-12 14:24 ` [PATCH V1 8/8] scsi: ufs: Set fDeviceInit flag to initiate device initialization Dolev Raviv
-- strict thread matches above, loose matches on Subject: below --
2013-05-13 10:02 [PATCH V1 0/8] ufs patch siries Dolev Raviv
2013-05-13 10:02 ` [PATCH V1 5/8] scsi: ufs: fix interrupt status clears Dolev Raviv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368368640-10167-6-git-send-email-draviv@codeaurora.org \
--to=draviv@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).