From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DC483033F7 for ; Mon, 26 Jan 2026 10:00:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769421632; cv=none; b=ev6mJ0azDnA+BSXpENmcwTasxWU0hdoTuV1b5STkmQgtm5KO2XmWOKtSIRUY7BJPWPc+pMK7uR6uHbGosb5fGqB9wx2vA+M3VHLcAxLWcmPUTyKIQ/66aZ8JcGrEcbiohIe/yCxQV6OY+4wO7OJNMZEVkOFbIbjokDNegPUPdEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769421632; c=relaxed/simple; bh=0nx8zUDWkK9WrQ3HjuMSpxEdNZinAHVQoSH+iyhLpws=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RRiMexTLcEI9Hw2WS70dpM0CWxGszkTeZjnHC1bbYqY9mpWaF7iewu+jpzDnsLEMSIxJ3TR8MUPi6MNXCaC57CzB6ZRvP0x/ykciUUIJkqe+drSB9eF79AU8lNln0ieSW1HCodFEiKlxwM20Gc5HBDZJQ9ZLJOI7iyTI/jAhU0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cCBEKBAi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ej4gTfxf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cCBEKBAi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ej4gTfxf" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60Q40lVX1361526 for ; Mon, 26 Jan 2026 10:00:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z2NcQNiRQpQSmkaW1sS83QhtWA//oCEj7r8nYuk+mDs=; b=cCBEKBAiAM9UYNh+ bwXW90fzwGCbzbdjXsedo1MtwV40rM0/CY8MEZ38ARuMRKLI9fE/cd6N1MVryEM9 llGLPxCLduW0JaiQKtH+pKE+C7i8ouMphTBD1YicvnofiBK/c/Uy45qEIjF66nin kvngx7NQs5VyH41j6QNJjL+MWEr/9U3p4GlnLr5IKPIkitpdiHR4r3jR9QpUzvxl qzS1SWEhEedPvW3XDq+fKwvb7IQDfa3zp8jjDqs6GUTbGqox+LdZcCLHlchWgMIr VlhAobO5QU8ibSKP4nUAKoqvHbJRm8KnyIORflU4EL0sRHR598hpOAPI6T2AjfZr 1sO6lw== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bx0v30t7v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 26 Jan 2026 10:00:30 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-894662cba4fso12863566d6.2 for ; Mon, 26 Jan 2026 02:00:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769421630; x=1770026430; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z2NcQNiRQpQSmkaW1sS83QhtWA//oCEj7r8nYuk+mDs=; b=ej4gTfxf08DCr/XUHW5XkfK6NSuIFPmZuYRB17M8KPv/8SG7b6vssoJBn6YmAvqw1M DUE7trrCr7BZo6DQfbwnLgEKzILNl0vAZdgHfRVr+sGYApRUkA8Cxo88YvtrauGxvavC 4xrd2fu5MCb49hrkIE7GStrRDnXeBxNrXlIjCliPq6QzNPFrjkG3qxdYES+/sTuDjyBt KzzSgNUnw7ASVsQQI7Z+V60CBdZSlyL2RZ5V3kwj0rUC3lH48vyBkxfwOox58dpioNC0 FhKjC31d+Ib2igE5M6/jPACeFBKdLutxrisBwA3+G7+wOUu0gd49wVB4xbUKk7JkCeh9 y4uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769421630; x=1770026430; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z2NcQNiRQpQSmkaW1sS83QhtWA//oCEj7r8nYuk+mDs=; b=WFFpnN0+9dUN2h8YRt2GnyHBe3kUN8sbwSDGrpeyfID3lKU98JWusF5wmOwBFjykRC CIwcT+2sXmwAPd9SGEkMuuhdBSROHhhP9TYK6bppxA4FsDzafuWvXIFfBav5uX0awFKl J0aOC8Qq8Fu5/TeObc8ZbBenKcgJUy03AFKjwqy9bGYPzUJhbOYHM/4iszlBBKtb76xr fiQ0a6TdOXDWD9LqiGyxEnUN1+9cTM5mpgcMLdQgiL3vV08WACH2bntlnI1S71QBQPpW oWggYkiZ84JjjIXjEAw5tdkc0mY8VSdhyh1/pMaeJPWOMBVHQy5deNxwdMgv2txceCwM PXeg== X-Forwarded-Encrypted: i=1; AJvYcCU/SPY5qe3s9j96AQld00EZV0YbFjreVnjQb3Z080WsMR1SCjNJyJj3zoqAlLfBrEJdNCu4JPb+iLqXPocl@vger.kernel.org X-Gm-Message-State: AOJu0Yyui51xmTjgU2k4ZsNujLvaHK3gEedCio+salXOAKrwWKiBNKRX eSKPdZ/4tcaw7MSumxb1aP9xUbi5tt5NaO1B70Skbh7oFqf09k0hlu1qTqOJhUFuGfkPmR+CTab EqnDitwNVK6dzSb/YKB/SBu2vqCGpaizSmFYDKp+yGdO164ejmxSWegj0SvpuC7bpSOmz X-Gm-Gg: AZuq6aJGSUeufD9FdBN59PJVUe74nqc3biEzjfVUoDRjti2qtD8uWSdMnrXuk02RYqv Ee6TiNt9jqOXPePYOroDBxXZ86sl2RlLdfLSkbUtwXSPnl0QWBQEL+DGPdOonTXZ9g6OnEYOWmW P0y3QtH5nnblOtQAokEtGqgrRpbhh87I82neZSiDQYHOa4hsQz25vpg/P6N5vhCYM7+HL/dBDl5 b2zl4clWMfZPGUX3DxUQPZHEK3ySzriMJED4evlJlm9AR2S0pQ37kLtY4ERhkfmg3GXi4eX26nB 9+tqcccB0NS6TIHcfOVtQMdBUvP1H4GQ5JYGfbrzSxp3k6KA50N3qv8MF2icr7KSvLdWSFF944E cNsrz7Bs/z1ysZRxyzel8KiT0S/Ve1QxpppBEaDoLIKJhX4INzFSzzetbTlnpD5S+q1c= X-Received: by 2002:a05:6214:3303:b0:889:e38c:d13a with SMTP id 6a1803df08f44-894b07941dfmr34993746d6.5.1769421629532; Mon, 26 Jan 2026 02:00:29 -0800 (PST) X-Received: by 2002:a05:6214:3303:b0:889:e38c:d13a with SMTP id 6a1803df08f44-894b07941dfmr34993366d6.5.1769421629019; Mon, 26 Jan 2026 02:00:29 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-385da1a6c87sm27374691fa.36.2026.01.26.02.00.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 02:00:28 -0800 (PST) Message-ID: <136bf12f-cead-4485-b689-af780c937e2d@oss.qualcomm.com> Date: Mon, 26 Jan 2026 11:00:25 +0100 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/7] arm64: dts: qcom: sc8280xp: Add Venus To: Dmitry Baryshkov , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Abhinav Kumar , Bjorn Andersson , David Heidelberg Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Bryan O'Donoghue References: <20260125-iris-sc8280xp-v3-0-d21861a9ea33@oss.qualcomm.com> <20260125-iris-sc8280xp-v3-4-d21861a9ea33@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260125-iris-sc8280xp-v3-4-d21861a9ea33@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI2MDA4NSBTYWx0ZWRfX4JpeBLW3YEj/ 0GNoXbMI0xIAZlvceR05WDz7k9tSvgWzgOSIN+o64y3qUgN1Ssf1H5pYcd3vHdF8xxJlbD+tCYF vzzWoD2EH71/k6pIVwRZFrhRtAGBxyH/ZYeZXy7y+e6or94iQuaOakpJL1p026GlaOFUzVZV6iB RB6Z3bJElABkX+2/ut8IrJCd1G1ERcxJUnBURoi7gkSR3G5Mxr//C4PyWsd/gTybwXV3GyZmgkC baKwG52iYHpmewwOZYcQRE02v2rnDfAFXuUaMm7Pat//lDhI3bFScRs6+62wM4tMvTcrm8imFAm n4Gjk/xuAQOc9hUcGRMSBL3kW+BXNruOyP5lX683mYo2gtY0tZ15u+GDE7M5OpRIgAmFvhPvs9D MksKE6/EI/y7kUHUQ9RS5qWS2f/M8pvkWD/gONCy/j0EXDcVK3nI43w5tMGZDiN2Tbp/uDRKCmo 33VWYHtBMzSjf1B4row== X-Proofpoint-GUID: LZAqqQpFi5Vyyi9HWYw8BTXxfIB3_J0b X-Proofpoint-ORIG-GUID: LZAqqQpFi5Vyyi9HWYw8BTXxfIB3_J0b X-Authority-Analysis: v=2.4 cv=JYyxbEKV c=1 sm=1 tr=0 ts=69773b3e cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=q7sET-JBz6qvjIJve7kA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-26_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601260085 On 1/25/26 4:33 PM, Dmitry Baryshkov wrote: > From: Konrad Dybcio > > Add the required nodes to enable Venus on sc8280xp. > > [ bod: added interconnect tags ] > > Signed-off-by: Konrad Dybcio > [ johan: use sm8350 videocc defines ] > Signed-off-by: Johan Hovold > [ bod: dropped video encoder/decoder declarations ] > Signed-off-by: Bryan O'Donoghue > [ db: dropped llcc icc, switched to sc8280xp compat, added more freqs ] > Signed-off-by: Dmitry Baryshkov > --- [...] > + venus_opp_table: opp-table { > + compatible = "operating-points-v2"; > + > + opp-720000000 { > + opp-hz = /bits/ 64 <720000000>; You need to div3 all of these, otherwise this LOW_SVS OPP will actually apply a more-than-TURBO_L1-requiring frequency.. [...] > + videocc: clock-controller@abf0000 { > + compatible = "qcom,sc8280xp-videocc"; > + reg = <0 0x0abf0000 0 0x10000>; > + clocks = <&rpmhcc RPMH_CXO_CLK>, > + <&rpmhcc RPMH_CXO_CLK_A>, > + <&sleep_clk>; > + power-domains = <&rpmhpd SC8280XP_MMCX>; > + required-opps = <&rpmhpd_opp_low_svs>; AFAICS the PLLs will not turn on if *MX* is at < LOWSVS, but they still need to be scaled 1:1 with MMCX as the freuqency rises, so you need to wire up 2 power domains to the OPP table PLL0 supplies core0 (iris) and PLL1 supplies core1 (CVP) Konrad