linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jack Pham <jackp@codeaurora.org>
To: Alan Stern <stern@rowland.harvard.edu>, Greg KH <greg@kroah.com>,
	linux-usb@vger.kernel.org
Cc: Tim Sander <tim@krieglstein.org>,
	Manu Gautam <mgautam@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, Jack Pham <jackp@codeaurora.org>
Subject: [PATCH 0/2] usb: Add support for EHSET
Date: Tue,  2 Jul 2013 20:13:50 -0700	[thread overview]
Message-ID: <1372821232-7196-1-git-send-email-jackp@codeaurora.org> (raw)
In-Reply-To: <1591113.JYQdTBbFW7@dabox>

PATCH 1/2 is a device driver supporting the Embedded Host High-Speed
Electrical Test (EHSET) test fixture. This driver supports the set of
VID/PIDs specified in the EHSET and activates the various test (TEST_J,
TEST_K, et al) modes by issuing a USB_PORT_FEAT_TEST SetFeature request
to the hub, or by directly toggling USB_PORT_FEAT_SUSPEND, in the case
of the port suspend test.

In RFC/PATCH 2/2 *[1] the SINGLE_STEP_SET_FEATURE test is implemented. The
fixture driver designates test selector=6 and sends the USB_PORT_FEAT_TEST
request directly to the root hub. The EHCI hub driver is expected to handle
this by calling functions in the queue driver to submit separate QTDs for
the SETUP and DATA/STATUS stages of a GetDescriptor request, in essence
duplicating the work of ehci_urb_enqueue(), but with the requisite added
delay.

Alan Stern wrote:
> It does sound like a lot of mucking around inside ehci-hcd for a
> relatively small benefit.  But if people want it, I guess it can be
> added.

Thus this patch is an RFC because I'm pretty sure this method of "mucking
around" isn't gonna sit well with most folks. So any alternative suggestions
are welcome.

*[1] This second patch is mostly unmodified from the original commit made on
the out-of-tree MSM kernel, so please excuse trivial style inconsistencies:
https://www.codeaurora.org/cgit/quic/la/kernel/msm/commit?id=c2084930fd49f04571627be0762ff40e5c5d90d8

Manu Gautam (2):
  usb: misc: EHSET Test Fixture device driver for host compliance
  usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET

 drivers/usb/host/ehci-hub.c |  144 ++++++++++++++++++++++++++++++++++++++++-
 drivers/usb/host/ehci-q.c   |  101 ++++++++++++++++++++++++++++
 drivers/usb/misc/Kconfig    |   13 ++++
 drivers/usb/misc/Makefile   |    1 +
 drivers/usb/misc/ehset.c    |  152 +++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 410 insertions(+), 1 deletions(-)
 create mode 100644 drivers/usb/misc/ehset.c

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

       reply	other threads:[~2013-07-03  3:14 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1591113.JYQdTBbFW7@dabox>
2013-07-03  3:13 ` Jack Pham [this message]
2013-07-03  3:13   ` [PATCH 1/2] usb: misc: EHSET Test Fixture device driver for host compliance Jack Pham
2013-07-03  3:13   ` [RFC/PATCH 2/2] usb: ehci: Add support for SINGLE_STEP_SET_FEATURE test of EHSET Jack Pham
2013-07-25 18:46     ` Greg KH
2013-07-25 19:44       ` Alan Stern
2013-07-25 20:54         ` Felipe Balbi
2013-07-25 21:33           ` Alan Stern
2013-08-09 13:41             ` Felipe Balbi
2013-08-09 14:37               ` Alan Stern
2013-08-09 14:44                 ` Felipe Balbi
2013-08-09 15:04                   ` Alan Stern
     [not found]                     ` <Pine.LNX.4.44L0.1308091053450.1405-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2013-08-12 17:53                       ` Felipe Balbi
2013-08-12 18:52                         ` Alan Stern
2013-08-13 15:32                           ` Felipe Balbi
2013-08-13 16:47                             ` Alan Stern
2013-08-13 23:05                             ` Jack Pham
2013-08-14 14:10                               ` Alan Stern
2013-08-14 17:05                                 ` Jack Pham
2013-07-25 22:09     ` Jack Pham
     [not found]       ` <20130725220925.GA28634-NjF/qFWh7jSrUKQWM4GlyCPyLMyjRtWwAL8bYrjMMd8@public.gmane.org>
2013-08-08 23:49         ` [PATCH " Jack Pham
2013-08-09  0:05           ` Greg KH
2013-08-09  2:12             ` Jack Pham
2013-08-09  2:32               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372821232-7196-1-git-send-email-jackp@codeaurora.org \
    --to=jackp@codeaurora.org \
    --cc=greg@kroah.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mgautam@codeaurora.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tim@krieglstein.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).